From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] posix_spawn blocks SIGCHLD in spawned processes Date: Mon, 04 Apr 2022 16:13:43 +0200 Message-ID: <87ee2d6inc.fsf@gmail.com> References: <7CFD5E28-8266-4004-BF66-255146D72722@gnu.org> <83r18whunp.fsf@gnu.org> <36bbd45c-0a87-13b7-1589-afe943329e20@fastmail.com> <83ee4whqpf.fsf@gnu.org> <87v8y33hu1.fsf@rfc20.org> <83sft7aqxd.fsf@gnu.org> <3db6c69c-0c08-3f92-491b-0b715b18eb40@fastmail.com> <87pmo6c3h6.fsf@gmail.com> <86o82mvybj.fsf@hoetzel.info> <87zgm6ghdz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10218"; mail-complaints-to="usenet@ciao.gmane.io" Cc: alan@idiocy.org, emacs-devel@gnu.org, Saulius Menkevicius , p.stephani2@gmail.com, Matt Armstrong , Eli Zaretskii , mituharu@math.s.chiba-u.ac.jp To: =?utf-8?Q?J=C3=BCrgen_H=C3=B6tzel?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 04 16:14:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbNTP-0002V0-P8 for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Apr 2022 16:14:27 +0200 Original-Received: from localhost ([::1]:46220 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbNTO-0003CN-OQ for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Apr 2022 10:14:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbNSn-0002Wv-1J for emacs-devel@gnu.org; Mon, 04 Apr 2022 10:13:49 -0400 Original-Received: from [2a00:1450:4864:20::429] (port=38724 helo=mail-wr1-x429.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nbNSl-0002kN-KG; Mon, 04 Apr 2022 10:13:48 -0400 Original-Received: by mail-wr1-x429.google.com with SMTP id j12so7113391wrb.5; Mon, 04 Apr 2022 07:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=mIblMs1c6Gh2W7ircAvGL4X5kTeLyVJhHoDJTu9ys4U=; b=C8tkk/9S8y0aisvEWy8BeASMqQZrDdCA0pRxwYnXc4Crk842cLHzPTwJiHaY7djQxD zOKgWt07eGwDWzp41mI7m8N3kDLBzhPPj9Ho4jbNh+Hzk6KmsBhibrO9eqLGysEyHmsv xY0ylxivext99HKTkYlkC7GZgWhvYPzLnuowd2NDRYNimUXz7/bALuHn8Y+G4TBdps6K e11O0c8+vZcK78ziUnaHX9mVl0czmnHhtT81ljIG6b1wXX+dV1sTefisp2dPnTEegxUs Anc8LtRvULsSOpRPFsbHB0R/xn5YAp3X1prnMLXk3e0ethnUqSEVhrO2EWsNJtwqSpHb Sj5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=mIblMs1c6Gh2W7ircAvGL4X5kTeLyVJhHoDJTu9ys4U=; b=HoDAT5h6g0WGhlw/6/Za/yMdphChtn+GBpwOAVWbMckvKdJ/xe6uIwa4EaUBJ1spYa ZWkHKwiuLtTtLYZ6KbYdvN0hN/kN1EgOi8yxw8dC3yDqmGFiD1rXiUFMHcTmrJMUedTc rCHaCvg24mzzgnIiY/l6G3gYa8UhXv4FpvsBO6hxQ52B6LTpyJcBwAte+jgDJ+ujnvxb 8VepVix/EGMQEYSh64rkp2g7BwNHkLgAtn2NVXhZ+5zYZSMvBTb/XZbZffnIrnAredMG w1gTcnMZ1HMwq5ryBccEzJSUoAPQdjy6DZdZ4BPPYslWG+H/Vr2JvT4orbJhmakVN7b/ 0w2g== X-Gm-Message-State: AOAM532bAbWqd3mf9zWXhTER+TpCracXV4eVyvdzP+7NfKETQredKlmO E2mshewSUZXWMAAA/ttI6xS8la23Xcg= X-Google-Smtp-Source: ABdhPJzuNJ4wQrdyL41Qq5ILSqpvQDnLwxbUUBePoZm2sJlW9crQKh260mwh8fArAiB+Fwsyq7Uy3A== X-Received: by 2002:a05:6000:1449:b0:204:6d5:fb2b with SMTP id v9-20020a056000144900b0020406d5fb2bmr17181921wrx.421.1649081625336; Mon, 04 Apr 2022 07:13:45 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:63d3:852f:6a79:2aa0]) by smtp.gmail.com with ESMTPSA id v13-20020adfe28d000000b0020375f27a5asm9887326wri.4.2022.04.04.07.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 07:13:44 -0700 (PDT) In-Reply-To: <87zgm6ghdz.fsf@gmail.com> (Robert Pluim's message of "Fri, 04 Mar 2022 11:07:52 +0100") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::429 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=rpluim@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287762 Archived-At: >>>>> On Fri, 04 Mar 2022 11:07:52 +0100, Robert Pluim s= aid: >>>>> On Fri, 04 Mar 2022 09:38:25 +0100, J=C3=BCrgen H=C3=B6tzel said: J=C3=BCrgen> IMO the correct way to fix this issue is to use the oldset= passed by J=C3=BCrgen> emacs_spawn (patch enclosed) just like the fork/exec imple= mentation does. Robert> Sure, that would work as well. J=C3=BCrgen> I guess without a fix many forking commands (that don't ex= amine and J=C3=BCrgen> change mask of blocked signals) will "hang" in Emacs. Robert> Not really. It=CA=BCs a code path that=CA=BCs non-default, since Robert> process-connection-type defaults to t =3D> use pty's, and the c= ommand in Robert> question has to care about its children. But it needs to be fi= xed Robert> regardless. Robert> I don=CA=BCt have a test case, but the patch looks good to me. Now applied to master as 8103b060d8 in J=C3=BCrgen's name. Robert --=20