unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master 18ec3fcce9: Restore pending_signals at a point in the DND event loop
Date: Thu, 21 Apr 2022 08:29:50 +0800	[thread overview]
Message-ID: <87ee1rb7nl.fsf@yahoo.com> (raw)
In-Reply-To: <jwvtuan3ifc.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 20 Apr 2022 11:05:26 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Changing `process_pending_signals' to take into account a small
>> technicality in the X11 drag-and-drop code seems much less clean to me
>> than three lines of code accompanied by an explaining comment.
>
> To me, those 3 lines are impenetrable.
>
> So, if you could explain (or show) what it would take to do it more like
> what I suggest, maybe I can at least improve the comment.

That unblock_input might call XTread_socket, which returns in this
specific case since data is passed from the nested event loop to its
caller via the hold_quit parameter to handle_one_xevent, and the
hold_quit given to the read socket hook is not correct.

So XTread_socket always returns without reading input whenever the
nested event loop is active.  This is fine, but pending input might not
be read if the nested event loop stops after that, since
process_pending_input clears pending_signals, even if nothing was
actually read.



      reply	other threads:[~2022-04-21  0:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165015596397.5558.5393619769224500857@vcs2.savannah.gnu.org>
     [not found] ` <20220417003924.49D86C01684@vcs2.savannah.gnu.org>
2022-04-17  3:21   ` master 18ec3fcce9: Restore pending_signals at a point in the DND event loop Stefan Monnier
2022-04-17  3:55     ` Po Lu
2022-04-17  5:21       ` Stefan Monnier
2022-04-17  5:53         ` Po Lu
2022-04-20 15:05           ` Stefan Monnier
2022-04-21  0:29             ` Po Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee1rb7nl.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).