From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James N. V. Cash Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Handle case where `beg` and `end` are strings instead of markers Date: Wed, 04 May 2022 17:09:27 -0400 Message-ID: <87ee190zug.fsf@occasionallycogent.com> References: <87k0b84tfr.fsf@occasionallycogent.com> <87h76c4ruf.fsf@occasionallycogent.com> <86sfpwwerz.fsf@mail.linkov.net> <87czh03xa9.fsf@occasionallycogent.com> <87o80i3frf.fsf@occasionallycogent.com> <87ee1e374d.fsf@occasionallycogent.com> <861qxdf7pl.fsf@mail.linkov.net> <87wnf40x29.fsf@occasionallycogent.com> <86wnf3oi4e.fsf@mail.linkov.net> <87pmkt1owo.fsf@occasionallycogent.com> <86bkwdjeeg.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24559"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 04 23:32:42 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmMby-0006Cg-39 for ged-emacs-devel@m.gmane-mx.org; Wed, 04 May 2022 23:32:42 +0200 Original-Received: from localhost ([::1]:41208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmMbw-0005D5-MF for ged-emacs-devel@m.gmane-mx.org; Wed, 04 May 2022 17:32:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmMFc-0004ol-59 for emacs-devel@gnu.org; Wed, 04 May 2022 17:09:37 -0400 Original-Received: from mail-qt1-f182.google.com ([209.85.160.182]:44857) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmMFY-0008Ks-Eb for emacs-devel@gnu.org; Wed, 04 May 2022 17:09:35 -0400 Original-Received: by mail-qt1-f182.google.com with SMTP id t11so1836057qto.11 for ; Wed, 04 May 2022 14:09:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=JvwkQh2Q2qG7fZUULkUatNP5grIO/W4MokHTgPep5yI=; b=RMOWBIUcY+t+8QjF2jRDIBa7yB0mt/sVBaZs+fkMSgmi2hFhN8/xdSp4j5//9BZ+pb jQdFzifC66khXpbKP0SH49MD8gC44wKlwUQrfVgSCy5Pvgd49XjEPDDQ6GupGgCrWAmi eY/qMaKo6OohfiOA6ONNg3nSQmCfJ6XAkZCYA08D6ojjK6BUFKf1OmiiixuDJ2aj8ks1 25SVHPF9Z3fYVIg978PFMx3WDZKum2CFZm4fbWB3IvzoiVrTU0dvkLIOXtvH1GwWUyiQ +bpYWuRhZoVH+Uv57lKFarp4lybbzbIwsIBzjT6B6JvDCqtXvAyCtWbrS2Ov9rSV1wnJ /gCw== X-Gm-Message-State: AOAM5337krB1A4KtsJewRxGsPhDaRBbZmxeHsWGPcnESZjMiBkfKStiP uv2dx5yEMknS68yjrNasNouJAMyrd5k= X-Google-Smtp-Source: ABdhPJxHxAUIEaBYaLK16wL39aSxOpg8rtODxYrfDM0ruZbOXvvgiYOPFYvlYoOdOB7x29OwzIMdnw== X-Received: by 2002:ac8:588b:0:b0:2f3:92eb:16d4 with SMTP id t11-20020ac8588b000000b002f392eb16d4mr21233353qta.252.1651698569563; Wed, 04 May 2022 14:09:29 -0700 (PDT) Original-Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com. [66.111.4.227]) by smtp.gmail.com with ESMTPSA id g19-20020ac842d3000000b002f1f934bedfsm8552730qtm.3.2022.05.04.14.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 14:09:28 -0700 (PDT) Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 7875F27C0054; Wed, 4 May 2022 17:09:28 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 04 May 2022 17:09:28 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdelgdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkgggtsehttdertddttddtnecuhfhrohhmpeflrghmvghs ucfprdcuggdrucevrghshhcuoehjrghmvghsrdhnvhgtsehgmhgrihhlrdgtohhmqeenuc ggtffrrghtthgvrhhnpeduhedtueekkeeivdefkedufeekieeljeegheffhfeiveeuhfek uefffefgieelkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehjrghmvghspggtrghshhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihht hidquddvfedvtddvjeelvddqvdejkeegtdduhedvqdhjrghmvghsrdhnvhgtpeepghhmrg hilhdrtghomhesohgttggrshhiohhnrghllhihtghoghgvnhhtrdgtohhm X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 4 May 2022 17:09:28 -0400 (EDT) In-Reply-To: <86bkwdjeeg.fsf@mail.linkov.net> Received-SPF: pass client-ip=209.85.160.182; envelope-from=james.nvc@gmail.com; helo=mail-qt1-f182.google.com X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289215 Archived-At: Juri Linkov writes: >>>> The other approach, which the below patch implements, is try to find the >>>> bounds based on the strings, but if the contents been edited, find the >>>> nearest CRM separator. This is kind of nice in that it lets you edit >>>> other selections but then still select a candidate, but I don't know how >>>> useful/expected that really is. The logic could also be made somewhat >>>> more complex (count the number of separators in `start` and `end`, try >>>> to guess how many we should skip over in each direction) but I don't >>>> know if that's really worthwhile. >>> >>> I tried out this approach and it works nicely, except the case >>> when the CRM separator gets deleted by the user. But OTOH, >>> the user might want to delete the separator intentionally, >>> to reduce the number of selections. So it seems there is no need >>> to make the logic more complex. >> >> Should I make a new thread with this patch then, or is the one here okay? > > If you think your latest patch is safe enough to install and > you signed a copyright assignment for your changes, I could push it > without the need to create a bug report. It's been working okay for me for the past few days & I do indeed have a copyright assignment on file. Thanks! James