From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Tue, 30 Aug 2022 07:49:56 -0700 Message-ID: <87edwxwzu3.fsf@melete.silentflame.com> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <865yia2opx.fsf@mail.linkov.net> <83k06quetz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38489"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: Eli Zaretskii , Juri Linkov , dgutov@yandex.ru, larsi@gnus.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 16:51:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT2aY-0009ng-T4 for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 16:51:40 +0200 Original-Received: from localhost ([::1]:47748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT2aX-00078R-WF for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 10:51:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT2Z3-0005yq-Gv for emacs-devel@gnu.org; Tue, 30 Aug 2022 10:50:06 -0400 Original-Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:38613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT2Z1-0001jN-8I; Tue, 30 Aug 2022 10:50:05 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 519D032009D2; Tue, 30 Aug 2022 10:49:59 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 30 Aug 2022 10:49:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1661870998; x= 1661957398; bh=wVYZQOWnXw+18JQPgTt+QqYxnyWiQidvwosgKmhV2g8=; b=w c4EzPYSfSzzsriECp9Nkif3OTYEjXC2SRG6vSSiyk9e63YEXSRIurmVCt5A3kexf 0zLjAdxSBSNF1TibzPEQTpS8kDR67GOyApdYguNpfZaIj+NUQlf20rlDgae56rAK REAfIP32oIjjDqcVwTxgaOHVUa/6eeOP/9VC+jzBAi/DKm89X/EQJsrzykcgxekf Tqir9MheyE9DtrC/YPDyi6zWqxJV2TF+fwDo4ENeZBe9Bm6jkwowF7XDdFoQiJ5z PRJtVq2CTF7JtQZ/7T7R4RuGwNyiAMt3MV6RjFsg8g5cEREUZXyAx0HxTT4jFq2y 0ExHZv59Rbx5PyN7QqkGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1661870998; x=1661957398; bh=w VYZQOWnXw+18JQPgTt+QqYxnyWiQidvwosgKmhV2g8=; b=kxFesGZ7v0LkHFnNR /u8RTU2nWAG1N53iuxGHLCCUOZpOJTlPOPBuBdJ5/ExNNatRDhR5vjuq1yG2ljuw YDoBRNit+BT3c18JiUfuc1JsIlBIk46wTieeBJMUBYcCyvNryif/jquKhaLxQm9R Q/szYtFdVlJ0tbWmSHmBU8M5ckUcMY7hGU3xXnmEgxhx0e5Y6jQIix+hC6N7Ibnr s9WCAHaQeE0G7q+nplVbknNV+CLcWmw87NTHc3OxmDBPO5aytfcfuTCoeEKLZ4W6 hsWqi1Ro6Si5Q3J2o1RklUguwv19Ss5N7VLVgVYVZRwSFvAy/cw+6J+mYZej4zNv P0ToQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekfedgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfgfgggtgfesthhqtddttderjeenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedugfehledtgfegkedvudetheffvddvfeegveduleehhefg geehhffhveekteejfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 30 Aug 2022 10:49:58 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 00B6B7E8B53; Tue, 30 Aug 2022 07:49:56 -0700 (MST) In-Reply-To: <83k06quetz.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 30 Aug 2022 14:54:16 +0300") Received-SPF: pass client-ip=64.147.123.19; envelope-from=spwhitton@spwhitton.name; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GAPPY_SUBJECT=0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294349 Archived-At: Hello, On Tue 30 Aug 2022 at 02:54PM +03, Eli Zaretskii wrote: >> From: Juri Linkov >> Cc: Eli Zaretskii , Lars Ingebrigtsen , >> emacs-devel@gnu.org >> Date: Tue, 30 Aug 2022 10:20:10 +0300 >> >> Anyway, the main point is that adepts of any existing VCS or any future >> VCS can easily adapt their VCSes for this feature by just implementing >> the backend call 'checkin-patch'. > > I very much hope this is not going to be the official policy of VC > development in Emacs. VC should IMO remain VCS-agnostic in its most > important features, and "C-x v v" is definitely such a feature of VC. Surely leaving room for things to be implemented for other VCs means that it remains VC-agnostic. With e.g. Magit there isn't even that room. > That's basically the only real raison d'=C3=AAtre of VC nowadays, because > otherwise let's just obsolete VC and switch to Magit. VC is far more flexible and Emacs-y than Magit in how it handles buffers. E.g. in Magit if you C-x x u a log buffer, because you want to log something else at the same time, Magit will re-use the first log buffer anyway. So for those of us who like it when things are more buffer-oriented, it remains a good alternative. --=20 Sean Whitton