From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: Amending commits Date: Tue, 27 Sep 2022 09:10:36 -0700 Message-ID: <87edvwer2b.fsf@melete.silentflame.com> References: <87h70vbw2f.fsf@gnus.org> <877d1ru3rd.fsf@posteo.net> <87czbjbs4r.fsf@gnus.org> <834jwvmu84.fsf@gnu.org> <87mtama031.fsf@gnus.org> <83bkr2l61a.fsf@gnu.org> <87k05q73c7.fsf@gnus.org> <83a66mku8o.fsf@gnu.org> <878rm559qj.fsf@gnus.org> <87o7v0zv6t.fsf@melete.silentflame.com> <87bkr03jxh.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16763"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , philipk@posteo.net, Emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 27 18:18:36 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odDI1-000472-Uw for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 18:18:34 +0200 Original-Received: from localhost ([::1]:45578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odDI0-0000l3-Sd for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 12:18:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odDAT-0006wv-9e for Emacs-devel@gnu.org; Tue, 27 Sep 2022 12:10:45 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:36959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odDAR-0003bn-VZ; Tue, 27 Sep 2022 12:10:45 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 5B4E85C0154; Tue, 27 Sep 2022 12:10:37 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 27 Sep 2022 12:10:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1664295037; x=1664381437; bh=mR 502afhui+MwrRq1wwrHlP9BdHWNJP0u4VR86oUjro=; b=c/0e5eD1MBQX1HrahL /RsKkBirDltznOE7cXVQnQfyysAYYeiNdl/gfRxs4aGgiaV6J7oVPObgPpehrVa1 oNRsusaASGV5iKQQUVAIHlQtTe7k5tbcOQ6U18yJGIwzQS3uRq/Pf08qGCDx4ddV MV74WsUZ+Ou/GsexQx4eWND152aUBF/B3DWKkIZ6A0VFdYADZzGV0eHB2sO/o4h3 h2H7lE3MVyD08a7MysTF2c2uEebx4XSobsxfAedFNtoHSbjJzlrmXP+G8hqYPeJQ LaBCVPqciqUjKmKZ1TQzeUVTf7TqaPlLVlnWE8YjQp0VOr+vT+7PPpFSHpBktxOE 3Ucg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664295037; x=1664381437; bh=mR502afhui+MwrRq1wwrHlP9BdHW NJP0u4VR86oUjro=; b=ArmVOtLFHvYAUikv+gvDK2qxw0Jx1yz9/iWju4r4HfDY 49wq9cun43VfUFop9pgk+tZJ3wiDQKwhhLc83enphWZ8bJAfL5aRljS532hNgKSU mb8kCDh26SrDA44bjBXrfqf9EBcQg7WZOcg9QX08dfduCskp727M2pWc4BIMN/WT cPbjgu6+GdP6ztBnN5Njr940EgBDOA3K14caGnoUFyQ2yARMcgZbi93K0+LUF5VW rfFVwqxBUiTmiEShvPwrWK9w/VORCREVboEWpDrU9TMay+Lb7JB2YwYLchHdmFzG NA6MBzhEtBzJvPcJJSS/f04rAeyMcWyfgODpkDX7HA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegiedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Sep 2022 12:10:36 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 2F5EE7E0AE1; Tue, 27 Sep 2022 09:10:36 -0700 (MST) In-Reply-To: <87bkr03jxh.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 27 Sep 2022 17:40:10 +0200") Received-SPF: pass client-ip=66.111.4.27; envelope-from=spwhitton@spwhitton.name; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296344 Archived-At: Hello, On Tue 27 Sep 2022 at 05:40PM +02, Lars Ingebrigtsen wrote: > Sean Whitton writes: > >> There is already vc-modify-change-comment which I think just needs a Git >> backend implementation. Then it'll work from Log View. > > Makes sense. (The limitation in Git, of course, is that you can only > modify the last commit, but having it signal an error if that's not it's > being asked to amend would be fine.) Couldn't it do a rebase to reword the old commit? I often do 'git rebase -i' only for the purpose of rewording an unpushed, non-tip commit, and it would be nice for that to be automated (eventually!). -- Sean Whitton