From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: Call for volunteers: add tree-sitter support to major modes Date: Tue, 11 Oct 2022 09:41:47 +0200 Message-ID: <87edveeric.fsf@thornhill.no> References: <83czb1jrm3.fsf@gnu.org> <878rlo7on0.fsf@thornhill.no> <83o7uki5ol.fsf@gnu.org> <87tu4c5g9j.fsf@thornhill.no> <835ygshz6k.fsf@gnu.org> <87zge3jj0j.fsf@gnus.org> <83o7uig9dm.fsf@gnu.org> <9E2D0EEB-3910-4C58-96E7-68E7C84E5097@thornhill.no> <83k056g8ez.fsf@gnu.org> <87k056esci.fsf@thornhill.no> <83edveg6b1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36464"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, acm@muc.de, emacs-devel@gnu.org, jostein@kjonigsen.net To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 11 10:26:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiAb1-0009IB-HN for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 10:26:39 +0200 Original-Received: from localhost ([::1]:35532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiAb0-00036H-IN for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 04:26:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oi9tn-0006zS-Kx for emacs-devel@gnu.org; Tue, 11 Oct 2022 03:42:00 -0400 Original-Received: from out2.migadu.com ([188.165.223.204]:31237) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oi9th-00052g-HD; Tue, 11 Oct 2022 03:41:59 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1665474109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WpXTlXUVFTJaWcYBiMJ9WUX3BatCa6eGFSAOVIO2QYw=; b=P13zyo2xRGwSJtaQw0fDaHm7S/VFoIIUietrhFmfP+c3tRaz8OXkFTiMsMhlolRE6k3A/Y NUcfK693ZbIL21bzXCk5Na6K73Tu8IdGIvtoymLjdoorhQRHsBnJbIHHtdqQ+2t1fnTc8x vJm+M/8lzB+N2ak22muNSVKdg+bKExJ5mY2kDKBPt0Fz3/89EXjdqyvaM4hw9TzZiU4jq3 GaxsPoSXMt8iZ1Rx449yO+bI6Pt3UIT02ezpzcTH60Ylp+4LHkQ03KnXvQWVfaj9UGg0lt TsQMz+ZUooIZM8gHyGVGytt4OixMCtfc3X5OzGhLarHf3TvFM4mvT5WmbC66rQ== In-Reply-To: <83edveg6b1.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=188.165.223.204; envelope-from=theo@thornhill.no; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297449 Archived-At: Eli Zaretskii writes: >> From: Theodor Thornhill >> Cc: larsi@gnus.org, acm@muc.de, emacs-devel@gnu.org, jostein@kjonigsen.net >> Date: Tue, 11 Oct 2022 09:23:41 +0200 >> >> >> Sure, I can rename it to tsx-mode, because that's the parser being used. >> > >> > SGTM. >> > >> >> Good, I'll integrate js.el into typescript-mode.el >> >> >> Why is that desirable, though? >> > >> > It prevents user confusion and conflicts, I guess? >> >> In many cases, yes, but in the Typescript case most users will be >> advised to move on from that mode. I don't really think there should be >> an issue - that repo can be archived when we have reasonable support. >> Jostein and/or others should of course chime in on this. >> >> How about we let it live as typescript-mode.el for now, and I can >> absolutely make sure the renaming happens should we decide to do so. > > My personal preference is to avoid conflicts even if we consider them > unlikely and/or desirable. OK, I'll think of some name. Defaulting to js works just fine, btw. So now we have vanilla support also in the new typescript mode. In this case we avoided the tree-sitter requirement, which is nice! Theo