From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Monaco Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v3] Allow applying filters to summary consecutively Date: Thu, 20 Oct 2022 17:45:56 +0200 Message-ID: <87edv2ijm3.fsf@autistici.org> References: <87zgdruali.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32592"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rms@gnu.org, eliz@gnu.org, emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 20 18:03:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1olY0z-0008Kp-55 for ged-emacs-devel@m.gmane-mx.org; Thu, 20 Oct 2022 18:03:25 +0200 Original-Received: from localhost ([::1]:52030 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olY0x-0005dZ-8k for ged-emacs-devel@m.gmane-mx.org; Thu, 20 Oct 2022 12:03:23 -0400 Original-Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olXvn-0003Vy-6D for ged-emacs-devel@m.gmane-mx.org; Thu, 20 Oct 2022 11:58:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olXkV-0005Dw-JF for emacs-devel@gnu.org; Thu, 20 Oct 2022 11:46:24 -0400 Original-Received: from latitanza.investici.org ([2001:888:2000:56::19]:55535) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olXkH-00022x-Fm; Thu, 20 Oct 2022 11:46:23 -0400 Original-Received: from mx3.investici.org (unknown [127.0.0.1]) by latitanza.investici.org (Postfix) with ESMTP id 4MtX4j3JGSzGp5D; Thu, 20 Oct 2022 15:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1666280757; bh=Qwy4nNKCXWWUM/ZOAEZiX9UvTsdXlsQUGZq9FjWJtvM=; h=From:To:Cc:Subject:In-Reply-To:Date:From; b=nj16TbOhusCKiB0ZfxP8rhxBFLvpEQwaIDb3PNmtYSH4pmgoHExSpBzkQtanzopYG 7oFQS52x/ZKkrvtak9NKPFzVoa1FPpNm7wyU5J7WV9z2weTvIJxwHSrdS1lveNdfKe +m5YiVrvkhY5c6xAYLwZUYvjf4Gbb9HqE8Nawvaw= Original-Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234]) (Authenticated sender: andrea.monaco@autistici.org) by localhost (Postfix) with ESMTPSA id 4MtX4j0stpzGp59; Thu, 20 Oct 2022 15:45:57 +0000 (UTC) In-Reply-To: <87zgdruali.fsf@gmail.com> (message from Robert Pluim on Wed, 19 Oct 2022 16:55:21 +0200) Received-SPF: pass client-ip=2001:888:2000:56::19; envelope-from=andrea.monaco@autistici.org; helo=latitanza.investici.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:298153 Archived-At: > I=CA=BCd call it `rmail-summary-stack-filters' and say The metaphor of a stack is not perfect, as we don't have any "pop", that is there's no command to cancel the last filter. > I don=CA=BCt remember the details of rmail=CA=BCs summary line format, = but I > think you=CA=BCd be better served with (thing-at-point 'number) There is some padding with whitespace at the beginning of each line, so you'd still need a jump command. > I think you have this same lambda about 4 times in the code, perhaps > `defun' it (using "rmail-summary--" as a prefix to indicate that > it=CA=BCs intended for internal usage) The five lambdas I added (one for each rmail-summary-by-* command) are similar but not identical. Maybe I could write a general function, but I find it too much of a hassle for a little line saving. I agree on the other objections. Andrea Monaco