From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package-vc has been merged Date: Thu, 10 Nov 2022 18:18:50 +0000 Message-ID: <87edua7jw5.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <87ilk1bgvd.fsf@posteo.net> <87edupbdp0.fsf@posteo.net> <875yg1bc02.fsf@posteo.net> <878rkxgpms.fsf@posteo.net> <87sfiyk3a2.fsf_-_@posteo.net> <87mt948pmo.fsf@posteo.net> <87fsevyxnt.fsf@posteo.net> <87zgd1f70g.fsf@posteo.net> <878rkkbj90.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25231"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Richard Stallman , emacs-devel@gnu.org, 'Eli Zaretskii' To: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 10 19:19:34 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otC9G-0006KL-F7 for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Nov 2022 19:19:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otC8t-0005xv-2I; Thu, 10 Nov 2022 13:19:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otC8r-0005xF-9w for emacs-devel@gnu.org; Thu, 10 Nov 2022 13:19:09 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otC8b-00027b-8e for emacs-devel@gnu.org; Thu, 10 Nov 2022 13:19:08 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 543B8240104 for ; Thu, 10 Nov 2022 19:18:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668104331; bh=2dcgdGtJtI4M20klvP9C8/VAQKra8WD8VOhUzGqST1g=; h=From:To:Cc:Subject:Date:From; b=AuqZA52iIfHOlYMhhUFWzr2FS/ryuHdGB5yQLcPhRLfdaLDseLah8nSC+9fHfx9HV Ne88GLgTyCtby3fgTb//5aipdPTaefCSc1FY33N9lw2gBcslXCgBMHnTKsKWB/5xY5 InNBmrG++IeUGQ1l0RZvP8enisHOrlQ4OBlRcgvUiMinsXyS4dxCrvvk9/VPHXAcPV b1XKE10p10S+QfuUtsIfvAiA8uGgj2zfJ6/C8uobIMYroDuyfwUQkhhCuUWuamSTSi 3oHATXg1pZvOGkqcKAHnTXcJ60KPK+5RDCrA93ppa7QkJmzLrl/ONe+a4UACsR/ZLJ BuPzsa+psO2jQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N7VTQ1bkLz6tmJ; Thu, 10 Nov 2022 19:18:50 +0100 (CET) In-Reply-To: ("Rudolf =?utf-8?Q?Adamkovi=C4=8D=22'?= =?utf-8?Q?s?= message of "Thu, 10 Nov 2022 00:52:08 +0100") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299511 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Rudolf Adamkovi=C4=8D writes: > Philip Kaludercic writes: > >> To avoid unnecessary an back and forth, pushing commits and reverting >> them, I have pushed the proposed changes to the >> "scratch/package-vc-fixes" branch, that I will rebase onto master when >> the changes are ready. If you have the time, try it out and see if >> the issues you had were resolved. > > I have just tried it, and below, I summarize my experience. > > Please note that I have not read any source code, nor followed the > dicussion word for word. Thus, I write my reports as a new user. > Hopefully, you find them useful. > > 1. Simplify the configuration. >=20=20=20=20 > (add-hook 'after-init-hook > #'package-vc-install-selected-packages > -99) >=20=20=20=20 > No `require', no `closure', no nothing. Beautiful. > > Restart Emacs. > > 2. Try "refreshing" (no) packages. > > M-x package-vc-refresh As we seem to use package.el in different ways, can you clarify what your intention is when invoking `package-vc-refresh'? The documentation string tries to clarify what is does, but perhaps the name is confusing: "Refresh the installation for package given by PKG-DESC. Refreshing an installation means scraping for new autoload cookies, re-compiling Emacs Lisp files, building and installing any documentation, downloading any missing dependencies. This command does not fetch new revisions from a remote server. That is the responsibility of `package-vc-update'. Interactively, prompt for the name of the package to refresh." Reload? Regenerate? Redo? > Got: > > completing-read-default: Wrong type argument: stringp, t Found an fixed the bug: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index 726e21ee6d..70fb6ac399 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -534,7 +534,7 @@ package-vc--read-package-name (and-let* ((extras (package-desc-extras (cadr pkg))) (url (alist-get :url extras)) ((package-vc--guess-backend url))))))) - nil (not allow-url))) + (not allow-url))) (defun package-vc--read-package-desc (prompt &optional installed) "Query the user for a source package and return a description with PROMPT. --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable (Btw, I am trying to force-push to the scratch branch but this appears not to work. Wasn't that the point of a scratch branch?) > 3. Try to install Modus Themes > > Update the configuration from `package' to `package-vc': >=20=20=20=20 > (with-eval-after-load 'package-vc > (add-to-list 'package-vc-selected-packages 'modus-themes)) >=20=20=20=20 > Delete `modus-themes-' from `~/.emacs.d/elpa'. >=20=20=20=20 > Restart Emacs. > > Got: >=20=20=20=20 > user-error: Unknown package to fetch: nil >=20=20=20=20 > *scratches head* >=20=20=20=20 > Oh, the list! Change the configuration again: >=20=20=20=20 > (with-eval-after-load 'package-vc > (add-to-list 'package-vc-selected-packages '(modus-themes))) >=20=20=20=20 > Restart Emacs. > > Got: >=20=20=20=20 > run-hooks: Symbol=E2=80=99s function definition is void: > modus-themes-load-operandi >=20=20=20=20 > Check `~/.emacs.d/elpa' to see if it contains `modus-themes'. > > It does. >=20=20=20=20 > *scratches head* >=20=20=20=20 > Check `package-vc-selected-packages': > > Its value is ((modus-themes)) >=20=20=20=20 > Try `M-x package-vc-update'. > > Got: >=20=20=20=20 > completing-read-default: Wrong type argument: stringp, t >=20=20=20=20 > Check `load-path' if it contains `modus-themes'. > > It does. >=20=20=20=20 > Execute `M-: (require 'modus-themes)' followed by `M-x > modus-themes-load-operandi'. > > The theme loads. > > *scatches head* >=20=20=20=20 > Think: "It seems that Emacs needs to process auto-loads." >=20=20=20=20 > Tries `package-refresh' again. > > Got: >=20=20=20=20 > completing-read-default: Wrong type argument: stringp, t > > 4. Give up and report back. > > :) > > Amost there! > >> Ah ok, but that is to be excepted for now. I am not part of the MELPA >> project, so I can't "force" them to provide package specifications. >> If they are missing, then we must rely on heuristics to download >> source packages. My hope is that they will add the file too at some >> point. > > I see. One can still install MELPA packages via a URL, right? > > P.S. 1 > > I remain unsure what `refresh' means. According to the documentation, > it "refresh[es] the installation for [the] package". But what does it > mean? The command needs a more detailed documentation and perhaps also > a more descriptive name. I understand the `update', but not the > `refresh'. > > P.S. 2 > > I could not find `package-vc-update-all' akin `package-update-all'. Not > that I needed it, but I looked for it in the case I manage to install > more packages. > > P.S. 3 > > The `package-vc-selected-packages' documentation still does not link the > `package-vc-archive-spec-alist' variable. But I noticed that the > variable has a new name, with a double dash for private use. Either > way, I just wanted to mention this fact for completness. > > Rudy --=-=-=--