From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master d5bf26f488b: Move side-effect-free and pure declarations to function definitions Date: Fri, 17 Feb 2023 16:23:21 +0100 Message-ID: <87edqo1fkm.fsf@gmail.com> References: <167664358623.31938.469093206950588462@vcs2.savannah.gnu.org> <20230217141949.451C7C13918@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26741"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 17 16:23:45 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pT2aO-0006pC-Uf for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Feb 2023 16:23:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pT2a7-000096-QQ; Fri, 17 Feb 2023 10:23:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pT2a6-00008m-Eb for emacs-devel@gnu.org; Fri, 17 Feb 2023 10:23:26 -0500 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pT2a4-0005Th-Hu for emacs-devel@gnu.org; Fri, 17 Feb 2023 10:23:26 -0500 Original-Received: by mail-wr1-x436.google.com with SMTP id bw20so1534300wrb.12 for ; Fri, 17 Feb 2023 07:23:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=A1SzWeQXgNN5A0Epkj+TJf8SzdUv6zjlCVJiM65e4dM=; b=W/ZjKqv2+CXoA20B5pF7GLZrud9qq73A0bfmyDqM3nIfdaAhYSVInDNCBrGk8iaZMK G42S3h/WgKo4Q7emtTntnlXUdEXZHcFWx2knFIsWcHXW/1MOlsMMYVTogG+bD1Qha1q8 9PRANbK097aKw1JHkyDwuWIhA84nhNJczQ8sSc9X8aQVce9NBcyLfUDtFbpSi7QBLr5o JMatVGDSmFE9zItwFIlizL3aG2/TajVdsi4Ygve6D00u+4y4xjTACH0pQVLtzZon97c9 tQxNiOnQ9EHph0KMUeVcmH5WxX+fruv5w4WaI0SjOcloO8cUA5liHJ9xPS1nQO81hrNY SOxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A1SzWeQXgNN5A0Epkj+TJf8SzdUv6zjlCVJiM65e4dM=; b=I2vbTxJ0KQQCLl2O5omTbq17Ml+jaln1LKgsYyMsZTcO4FCzfsO/xNPGhKoCcDV+WE An7M9lERLiqD03uFE5/wab+vzmlDgjK/MuwC92eb/avByROFx42RM+9JdJe1B+/ohYIh uyw0KqxWsvSLmuANtM8Zn6UEpECuerFTgnL1BKoZs0KB4jlSx0aHZQ2SC20J2miOT4We Xn8eYfBJ6K5aMtob/z35UlEHdxhKyqooheoX6iXZY/8ruvFGS2u4+GjtMKr3q/8CHFsW lvJt6F+MBUDozXLpDNaaubxoVrGBxhdbvJEyOSpC/96HGV2KSfhkAc1MA/EpploFwRiL JkQg== X-Gm-Message-State: AO0yUKXZklDRGUxsUBfU3zVQhNOMLGqSg2DH5Sw1B1oThssUU9EmfpbD SJFkIb3esp2H0nT5livPoYyq/J3L1iw= X-Google-Smtp-Source: AK7set9xCxkB287wX4flu1sjFMFQUR2ZClc7ZAs+eQmfzfEp9P1PSLKDuZpVA1ELMNdJQI6uViH6wg== X-Received: by 2002:a5d:6781:0:b0:2c5:52ef:61c5 with SMTP id v1-20020a5d6781000000b002c552ef61c5mr7794462wru.41.1676647402689; Fri, 17 Feb 2023 07:23:22 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id n16-20020adffe10000000b002c58ca558b6sm4234727wrr.88.2023.02.17.07.23.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 07:23:22 -0800 (PST) In-Reply-To: <20230217141949.451C7C13918@vcs2.savannah.gnu.org> ("Mattias =?utf-8?Q?Engdeg=C3=83=C2=A5rd=22's?= message of "Fri, 17 Feb 2023 09:19:46 -0500 (EST)") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=rpluim@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303495 Archived-At: >>>>> On Fri, 17 Feb 2023 09:19:46 -0500 (EST), Mattias Engdeg=C3=83=C2=A5r= d said: Mattias> branch: master Mattias> commit d5bf26f488b7968feed9f43e612a90da2aab15a8 Mattias> Author: Mattias Engdeg=C3=A5rd Mattias> Commit: Mattias Engdeg=C3=A5rd Mattias> Move side-effect-free and pure declarations to function de= finitions =20=20=20=20 Mattias> Some Lisp functions still had their `side-effect-free` and= `pure` Mattias> properties declared in byte-opt.el; do it at their definit= ion instead. Mattias> The lists in byte-opt.el now only contain functions implem= ented in C Mattias> and function aliases. This causes the following failure to bootstrap: Loading env (source)... Error: void-function (macroexp-warn-and-return) mapbacktrace(#[1028 "\1\4\203\24\0\301\302!\210\300\4!\210\301\303!\210\2= 02\35\0\301\304!\210\3\3B\262\1\211\2035\0\300\1@!\210\211A\211\262\2\2035\= 0\301\305!\210\202!\0\301\306!\207" [prin1 princ " " "(" " (" " " ")\n"] = 7 "\n\n(fn EVALD FUNC ARGS FLAGS)"]) debug-early-backtrace() debug-early(error (void-function macroexp-warn-and-return)) macroexp-warn-and-return("=E2=80=98declare=E2=80=99 after =E2=80=98intera= ctive=E2=80=99" nil nil t (declare (side-effect-free t))) #[771 "\2\300\301\4!\302\211\303\6\6%\4\242B\240\207" [macroexp-warn-and-= return format-message nil t] 10 "\n\n(fn WARNINGS MSG FORM)"]((nil) "`decla= re' after `interactive'" (declare (side-effect-free t))) byte-run--parse-body(("Get the value of environment variable VARIABLE.\nV= ARIABLE should be a string. Value is nil if VARIABLE is undefined in\nthe = environment. Otherwise, value is a string.\n\nIf optional parameter FRAME = is non-nil, then it should be a\nframe. This function will look up VARIABL= E in its `environment'\nparameter.\n\nOtherwise, this function searches `pr= ocess-environment' for\nVARIABLE. If it is not found there, then it contin= ues the search\nin the environment list of the selected frame." (interactiv= e (list (read-envvar-name "Get environment variable: " t))) (declare (side-= effect-free t)) (let ((value (getenv-internal (if (multibyte-string-p varia= ble) (encode-coding-string variable locale-coding-system) variable) (and fr= ame (assq 'environment (frame-parameters frame)))))) (if (and enable-multib= yte-characters value) (setq value (decode-coding-string value locale-coding= -system))) (when (called-interactively-p 'interactive) (message "%s" (if va= lue value "Not set"))) value)) t) #[642 "\2\204\11\0\301\302\4\"\210\1<\203\30\0\303\304\305\306\5\"\"\203\= 35\0\301\307\3\"\210\310\1\304\"\211@\1A@\311\38\312\48\313\58\3\205>\0\314= \6\11\6\11\6\6A\315\10%\1\3\244\262\3\211A\3\244\262\3\3\203R\0\3\3B\262\3\= 5\203[\0\5\3B\262\3\2\204b\0\316\262\3\317\320\6\13D\321\322\6\f\6\7BBDE\1\= 203|\0\323\1\3@BB\207\207" [defun-declarations-alist error "Cannot define '= %s' as a function" delq t mapcar symbolp "Malformed arglist: %s" byte-run--= parse-body 2 3 4 byte-run--parse-declarations defun (nil) defalias quote fu= nction lambda prog1] 16 ("/home/rpluim/repos/emacs/lisp/emacs-lisp/byte-run= .elc" . 9649)](getenv (variable &optional frame) "Get the value of environm= ent variable VARIABLE.\nVARIABLE should be a string. Value is nil if VARIA= BLE is undefined in\nthe environment. Otherwise, value is a string.\n\nIf = optional parameter FRAME is non-nil, then it should be a\nframe. This func= tion will look up VARIABLE in its `environment'\nparameter.\n\nOtherwise, t= his function searches `process-environment' for\nVARIABLE. If it is not fo= und there, then it continues the search\nin the environment list of the sel= ected frame." (interactive (list (read-envvar-name "Get environment variabl= e: " t))) (declare (side-effect-free t)) (let ((value (getenv-internal (if = (multibyte-string-p variable) (encode-coding-string variable locale-coding-= system) variable) (and frame (assq 'environment (frame-parameters frame))))= )) (if (and enable-multibyte-characters value) (setq value (decode-coding-s= tring value locale-coding-system))) (when (called-interactively-p 'interact= ive) (message "%s" (if value value "Not set"))) value)) (defun getenv (variable &optional frame) "Get the value of environment va= riable VARIABLE.\nVARIABLE should be a string. Value is nil if VARIABLE is= undefined in\nthe environment. Otherwise, value is a string.\n\nIf option= al parameter FRAME is non-nil, then it should be a\nframe. This function w= ill look up VARIABLE in its `environment'\nparameter.\n\nOtherwise, this fu= nction searches `process-environment' for\nVARIABLE. If it is not found th= ere, then it continues the search\nin the environment list of the selected = frame." (interactive (list (read-envvar-name "Get environment variable: " t= ))) (declare (side-effect-free t)) (let ((value (getenv-internal (if (multi= byte-string-p variable) (encode-coding-string variable locale-coding-system= ) variable) (and frame (assq 'environment (frame-parameters frame)))))) (if= (and enable-multibyte-characters value) (setq value (decode-coding-string = value locale-coding-system))) (when (called-interactively-p 'interactive) (= message "%s" (if value value "Not set"))) value)) load("env") load("loadup.el") I=CA=BCll push the obvious fix to master once savannah comes back to life if nodbody beats me to it. Robert --=20