From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 3c1693d08b0: Fix Elisp code injection vulnerability in emacsclient-mail.desktop Date: Wed, 08 Mar 2023 11:44:09 +0100 Message-ID: <87edpzplom.fsf@gmail.com> References: <167821009581.14664.5608674978571454819@vcs2.savannah.gnu.org> <20230307172816.2D56BC13915@vcs2.savannah.gnu.org> <877cvsozn5.fsf@yahoo.com> <87zg8onfob.fsf@yahoo.com> <87r0tzoeam.fsf@yahoo.com> <87a60no7su.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24601"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , emacs-devel@gnu.org To: Ulrich Mueller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 08 11:44:49 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZrHt-0006IS-0G for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Mar 2023 11:44:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZrHM-0007Kh-MD; Wed, 08 Mar 2023 05:44:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZrHK-0007KV-Gk for emacs-devel@gnu.org; Wed, 08 Mar 2023 05:44:14 -0500 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZrHI-0007kx-Q2 for emacs-devel@gnu.org; Wed, 08 Mar 2023 05:44:14 -0500 Original-Received: by mail-wm1-x32b.google.com with SMTP id fm20-20020a05600c0c1400b003ead37e6588so937414wmb.5 for ; Wed, 08 Mar 2023 02:44:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678272250; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=L1bVuMGn6O6nEueajnwc3cn0pLxjNtHeRpstxmlRy+Y=; b=ffZmmnNd98rIoPJ+mn4OIE+SOfJAsinbjE/1F0jSxKDSH6LUQQXbrGKyyMWMMGxQ/U 8SJp3XYLJua0DZXyAATahM0BEbK/wFhafROZ2F14ZJ/5dVds4lbL1qT8qr9UL2uGScE7 9NUmuVUWyuaUOyziekUJYkje2zvPjcFu1aZ6hbpPrXcHJ4kP0msDh9yw+Sy5XZY6K6pi SQC8rFizpDoYAQqTpqFaI4+v+xBK7BcLX4YTLkCNPjch7GADhr4LLZdhOXZ2DUxXGplq /vlBZuboNr7IIi9u/DMv619HBIEirTbocGVm5a0+nKaE01iCMfO5G1GMcKI7cbtR13xp 3PQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678272250; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L1bVuMGn6O6nEueajnwc3cn0pLxjNtHeRpstxmlRy+Y=; b=xK3F6RjwouiCk2wi7K35u3iKgct+HwbCl2qWwzzseCNkZdlBqphLXDcWPyntd2+cBp nSxYGCVCvSWdcNfp3mUrZ8Ay5nsijM7cKKBAcTgl44a0RH77o0rehZ7ByhBl3to/efm9 3tyLQKvrTuOpgVhjUq09vDI9FkjVPKTmRC6J/YD61Lb8w9vyiLOKhOmtQ0b9k1issjAg IyZwCgsnZ51BJVmoSDB67IDjEgXck5qwN+lXAMfGxI9JMN6kewCqFlACVtHPw/vlrhz/ LvS/zEUIgmwnfTguw7Cxf4f0LxW/WSr3BmLvAzFwikfcPVpIPol5YJw5fLGWK1B9yXFs ihIg== X-Gm-Message-State: AO0yUKV3LgC/OpiZ+JocasnpWkfVd0SiC4PuK5K/eSlgfSGNLpEybbed T0c3WcIKuwX+dGqbJuwZ7OGolRE1b3k= X-Google-Smtp-Source: AK7set9fp7WLASAAao25sdFssbw32cKPiOIyFVqjnvwk7mC7f6QfW4FGuXgkkTi3BV6DmDi5Z8y4uw== X-Received: by 2002:a05:600c:3108:b0:3eb:37ce:4c3d with SMTP id g8-20020a05600c310800b003eb37ce4c3dmr15460701wmo.38.1678272250539; Wed, 08 Mar 2023 02:44:10 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id l3-20020a1c7903000000b003e7c89b3514sm18771546wme.23.2023.03.08.02.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 02:44:10 -0800 (PST) In-Reply-To: (Ulrich Mueller's message of "Wed, 08 Mar 2023 11:39:32 +0100") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304117 Archived-At: >>>>> On Wed, 08 Mar 2023 11:39:32 +0100, Ulrich Mueller said: >>>>> On Wed, 08 Mar 2023, Po Lu wrote: >> Please, fix this so it works without bash, or remove it from emacs-29. >> Once the pretest comes out, I plan to ask many coworkers to try it out. >> Many of their systems use the Korn shell and do not have bash. Ulrich> Sorry, but I've installed this on emacs-29 with an explicit ack from Ulrich> both Eli and Stefan. Fair enough, but is there no way to get it to use `sed' instead? Ulrich> An alternative solution would be to drop emacsclient-mail.desktop Ulrich> altogether, since this desktop file isn't part of any core Ulrich> functionality. It could be readded once emacsclient has gained a Ulrich> --funcall argument, so that arguments can be passed in a sane way. No, I think too many people like using that desktop file for us to yank it like that. Robert --