From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Add more supported primitives in libgccjit IR (was: Shrinking the C core) Date: Mon, 21 Aug 2023 09:17:15 +0000 Message-ID: <87edjw4uw4.fsf@localhost> References: <20230809094655.793FC18A4654@snark.thyrsus.com> <87msym9i4r.fsf@dataswamp.org> <877cpp914t.fsf@localhost> <83fs4dwwdo.fsf@gnu.org> <874jkt90a5.fsf@localhost> <87y1i57jqi.fsf@localhost> <87pm3h7h8k.fsf@localhost> <87h6ot7cf3.fsf@localhost> <87edjx7c0b.fsf@localhost> <831qfxw2cx.fsf@gnu.org> <87v8d95918.fsf@localhost> <87zg2lav4b.fsf@yahoo.com> <87sf8d57wf.fsf@localhost> <87r0nxatu1.fsf@yahoo.com> <87pm3h56ig.fsf@localhost> <87edjxarhz.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7712"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , ams@gnu.org, incal@dataswamp.org, emacs-devel@gnu.org To: Po Lu , Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 21 11:17:55 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qY12p-0001lC-Bl for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Aug 2023 11:17:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qY11s-0000zo-H5; Mon, 21 Aug 2023 05:16:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY11r-0000ze-CF for emacs-devel@gnu.org; Mon, 21 Aug 2023 05:16:55 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY11o-0001yP-Ba for emacs-devel@gnu.org; Mon, 21 Aug 2023 05:16:55 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3EE2824002D for ; Mon, 21 Aug 2023 11:16:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692609410; bh=R3l7hPMjy2YjqHTdkOXwkm67f4A4IhJjYhFKk9+3F0Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=HpDMZ0PU0j69Rf9FcuK14xtSbDiZN+k/inFnKtja7Z8ffkwyKv3U9QHqy38vajzVm dQBjVUlE29TOW+lPjN+g1aHAjXjqlChqXkJ91cXXmnYdq7vnnbBJ9LvkaMa8bOMvRe Lmrg2noF+vjXzE+2VRJZB29N4S+u9bcBh4vygufeFNQxuBUwmQGANIzNl3/2QSbd+D TlLZDYZn4SqRdzQaYL+p0mN3qiC7mfX6RqQPqPFL9o6i89Do4bW7KTWxpxIq+pfGQc UkjjuQBvhjxqVSpgCl9tBF62P5nefgbtxL9NKtNTQODeqBNpVwcrye3zoo+Oswc1YR tPpKpysoCmchw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RTn0r5sJ2z6v03; Mon, 21 Aug 2023 11:16:44 +0200 (CEST) In-Reply-To: <87edjxarhz.fsf@yahoo.com> Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309042 Archived-At: Po Lu writes: > Ihor Radchenko writes: > >> But let me rephrase it in other terms: what you propose will require >> maintaining two separate implementations of subroutines - one in C, and >> one specially tailored to GCC JIT psudocode. This may be doable for a >> small set of core primitives, but not scalable if we want to make more >> subroutines benefit from GGC JIT optimizations. > > I'm inclined to believe that type checks within those more complex > functions do not contribute so much to the runtime of most > native-compiled functions as the small set of arithmetic primitives do. I am pretty sure that it depends on the specific use case. On average, you might be right though. Just to get something going, I executed https://elpa.gnu.org/packages/elisp-benchmarks.html benchmarks and looked into the primitives that take significant amount of time: 3.85% emacs emacs [.] arith_driver 2.62% emacs emacs [.] Fgtr 2.31% emacs emacs [.] check_number_coerce_marker 2.24% emacs emacs [.] Fmemq 2.20% emacs emacs [.] Flss 1.56% emacs emacs [.] arithcompare 1.12% emacs emacs [.] Faset 1.10% emacs emacs [.] Fcar_safe 0.97% emacs emacs [.] Faref 0.94% emacs emacs [.] Fplus 0.93% emacs emacs [.] float_arith_driver 0.58% emacs emacs [.] Feqlsign We may consider directly supporting some of these functions in native compile libgccjit IR code to get rid of runtime type checks. > Can we all stop bikeshedding over this now? By this point, the subject > of this thread bears absolutely no relation to the debate within. The thread evolved to general Elisp performance discussion and this particular branch evolved to compiler discussion. Updating the subject. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at