From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/hyperdrive b5294b4354 4/4: Tidy: Use zerop instead of = 0 Date: Sat, 14 Oct 2023 23:33:11 +0200 Message-ID: <87edhw7uug.fsf@dataswamp.org> References: <169722725606.27637.3820182151024041420@vcs2.savannah.gnu.org> <20231013200057.2C7FCC09BC9@vcs2.savannah.gnu.org> <87mswmqiif.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27712"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:rqtBAAGG6P5jHx0C5lx7X/l0Y8U= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 15 07:09:29 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrtNY-00073y-Qq for ged-emacs-devel@m.gmane-mx.org; Sun, 15 Oct 2023 07:09:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrtMX-0005HT-Ro; Sun, 15 Oct 2023 01:08:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrmGK-0003QF-5m for emacs-devel@gnu.org; Sat, 14 Oct 2023 17:33:32 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrmG7-0005BB-OU for emacs-devel@gnu.org; Sat, 14 Oct 2023 17:33:21 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1qrmG5-0003B1-RF for emacs-devel@gnu.org; Sat, 14 Oct 2023 23:33:17 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 15 Oct 2023 01:08:24 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311465 Archived-At: Philip Kaludercic wrote: > FWIW this doesn't matter that much, you can check the > disassembly to see what is going on after byte compilation: > > (disassemble (byte-compile (lambda (a) (= a 0)))) byte code: args: (a) 0 varref a 1 constant 0 2 eqlsign 3 return > (disassemble (byte-compile (lambda (a) (zerop a)))) byte code: args: (a) 0 varref a 1 constant 0 2 eqlsign 3 return They are identical, is that what you mean it doesn't matter that much? To use `zerop' is maybe more classy - the attitude being to minimize everything as much as possible - as it is a unary function (1 argument) while `=', as it is used here, is binary (2 arguments). BTW = can be used unary as well, then it always returns t - even for nil. (= nil) ; t But why do that? As it is more classy to just use t :) -- underground experts united https://dataswamp.org/~incal