unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master c933f5081fd 1/2: Permit XLFD names to exceed 255 characters
       [not found] ` <20230908024213.996B2C04EEA@vcs2.savannah.gnu.org>
@ 2024-01-12  8:29   ` Michael Albinus
  2024-01-12  9:55     ` Po Lu
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Albinus @ 2024-01-12  8:29 UTC (permalink / raw)
  To: emacs-devel; +Cc: Po Lu

Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:

Hi,

I know this commit happened some months ago, but I'm just in the process
to track errors on emba.gnu.org.

> branch: master
> commit c933f5081fdaadbe7192d2cc1f7e705f0b0fb842
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
>
>     (Ffont_xlfd_name): New arg LONG_XLFDs.  If t, return a
>     dynamically allocated XLFD.  All callers changed.

This results in the following error on emba:

--8<---------------cut here---------------start------------->8---
#12 1409. nsfont.m: In function 'nsfont_open':
#12 1409. nsfont.m:1038:36: error: too few arguments to function 'Ffont_xlfd_name'
#12 1409.  1038 |     font->props[FONT_NAME_INDEX] = Ffont_xlfd_name (font_object, Qnil);
#12 1409.       |                                    ^~~~~~~~~~~~~~~
--8<---------------cut here---------------end--------------->8---

See for example <https://emba.gnu.org/emacs/emacs/-/jobs/79588>. Could
you, please, fix this?

Thnaks, and best regards, Michael.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: master c933f5081fd 1/2: Permit XLFD names to exceed 255 characters
  2024-01-12  8:29   ` master c933f5081fd 1/2: Permit XLFD names to exceed 255 characters Michael Albinus
@ 2024-01-12  9:55     ` Po Lu
  2024-01-12 15:21       ` Michael Albinus
  0 siblings, 1 reply; 3+ messages in thread
From: Po Lu @ 2024-01-12  9:55 UTC (permalink / raw)
  To: Michael Albinus; +Cc: emacs-devel

Michael Albinus <michael.albinus@gmx.de> writes:

> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
> Hi,
>
> I know this commit happened some months ago, but I'm just in the process
> to track errors on emba.gnu.org.
>
>> branch: master
>> commit c933f5081fdaadbe7192d2cc1f7e705f0b0fb842
>> Author: Po Lu <luangruo@yahoo.com>
>> Commit: Po Lu <luangruo@yahoo.com>
>>
>>     (Ffont_xlfd_name): New arg LONG_XLFDs.  If t, return a
>>     dynamically allocated XLFD.  All callers changed.
>
> This results in the following error on emba:
>
> #12 1409. nsfont.m: In function 'nsfont_open':
> #12 1409. nsfont.m:1038:36: error: too few arguments to function 'Ffont_xlfd_name'
> #12 1409.  1038 |     font->props[FONT_NAME_INDEX] = Ffont_xlfd_name (font_object, Qnil);
> #12 1409.       |                                    ^~~~~~~~~~~~~~~
>
> See for example <https://emba.gnu.org/emacs/emacs/-/jobs/79588>. Could
> you, please, fix this?
>
> Thnaks, and best regards, Michael.

Thank for spotting this.  It's not possible for me to install this at
the moment, so could you please replace that statement with:

  ... = Ffont_xlfd_name (font_object, Qnil, Qnil);

?



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: master c933f5081fd 1/2: Permit XLFD names to exceed 255 characters
  2024-01-12  9:55     ` Po Lu
@ 2024-01-12 15:21       ` Michael Albinus
  0 siblings, 0 replies; 3+ messages in thread
From: Michael Albinus @ 2024-01-12 15:21 UTC (permalink / raw)
  To: Po Lu; +Cc: emacs-devel

Po Lu <luangruo@yahoo.com> writes:

Hi,

> Thank for spotting this.  It's not possible for me to install this at
> the moment, so could you please replace that statement with:
>
>   ... = Ffont_xlfd_name (font_object, Qnil, Qnil);

Done. Best regards, Michael.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-01-12 15:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <169414093293.26694.754185634292449030@vcs2.savannah.gnu.org>
     [not found] ` <20230908024213.996B2C04EEA@vcs2.savannah.gnu.org>
2024-01-12  8:29   ` master c933f5081fd 1/2: Permit XLFD names to exceed 255 characters Michael Albinus
2024-01-12  9:55     ` Po Lu
2024-01-12 15:21       ` Michael Albinus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).