* Arranging for windows of particular dimensions in xdisp-tests [not found] <87eddyf27s.fsf.ref@yahoo.com> @ 2024-01-31 6:26 ` Po Lu 2024-01-31 6:41 ` Jim Porter 2024-01-31 13:15 ` Eli Zaretskii 0 siblings, 2 replies; 4+ messages in thread From: Po Lu @ 2024-01-31 6:26 UTC (permalink / raw) To: emacs-devel I've just fixed several hangs in redisplay arising from `display' objects' being denied sufficient space by a line or wrap prefix, and consequently continuation lines being produced in an endless cycle inside move_it_to and display_line. Needless to say, tests for such bugs require that the windows where they execute be set to a particular size, which, considering that ERT tests are expected to run in both interactive sessions and in the initial frame, appears to be impossible. Ideas? Thanks in advance. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Arranging for windows of particular dimensions in xdisp-tests 2024-01-31 6:26 ` Arranging for windows of particular dimensions in xdisp-tests Po Lu @ 2024-01-31 6:41 ` Jim Porter 2024-01-31 13:15 ` Eli Zaretskii 1 sibling, 0 replies; 4+ messages in thread From: Jim Porter @ 2024-01-31 6:41 UTC (permalink / raw) To: Po Lu, emacs-devel On 1/30/2024 10:26 PM, Po Lu wrote: > I've just fixed several hangs in redisplay arising from `display' > objects' being denied sufficient space by a line or wrap prefix, and > consequently continuation lines being produced in an endless cycle > inside move_it_to and display_line. Needless to say, tests for such > bugs require that the windows where they execute be set to a particular > size, which, considering that ERT tests are expected to run in both > interactive sessions and in the initial frame, appears to be impossible. > > Ideas? Thanks in advance. The easiest might be to skip the test when it can't be run (or fail the test if you want to be noisier about it). I suppose you could also spawn a second, entirely-separate Emacs instance to test this part, although I'm not sure I'd *recommend* doing that. In theory though, you could start up that second Emacs and pass it a script to run, exiting with zero if the test succeeded. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Arranging for windows of particular dimensions in xdisp-tests 2024-01-31 6:26 ` Arranging for windows of particular dimensions in xdisp-tests Po Lu 2024-01-31 6:41 ` Jim Porter @ 2024-01-31 13:15 ` Eli Zaretskii 2024-01-31 14:01 ` Po Lu 1 sibling, 1 reply; 4+ messages in thread From: Eli Zaretskii @ 2024-01-31 13:15 UTC (permalink / raw) To: Po Lu; +Cc: emacs-devel > From: Po Lu <luangruo@yahoo.com> > Date: Wed, 31 Jan 2024 14:26:15 +0800 > > I've just fixed several hangs in redisplay arising from `display' > objects' being denied sufficient space by a line or wrap prefix, and > consequently continuation lines being produced in an endless cycle > inside move_it_to and display_line. Needless to say, tests for such > bugs require that the windows where they execute be set to a particular > size, which, considering that ERT tests are expected to run in both > interactive sessions and in the initial frame, appears to be impossible. > > Ideas? Thanks in advance. Our capabilities for testing display code in batch mode are very limited, almost nonexistent. So I suggest to add these tests to test/manual/redisplay-testsuite.el instead -- those can only be run interactively. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Arranging for windows of particular dimensions in xdisp-tests 2024-01-31 13:15 ` Eli Zaretskii @ 2024-01-31 14:01 ` Po Lu 0 siblings, 0 replies; 4+ messages in thread From: Po Lu @ 2024-01-31 14:01 UTC (permalink / raw) To: Eli Zaretskii; +Cc: emacs-devel Eli Zaretskii <eliz@gnu.org> writes: > Our capabilities for testing display code in batch mode are very > limited, almost nonexistent. So I suggest to add these tests to > test/manual/redisplay-testsuite.el instead -- those can only be run > interactively. Right, thanks. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-31 14:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87eddyf27s.fsf.ref@yahoo.com>
2024-01-31 6:26 ` Arranging for windows of particular dimensions in xdisp-tests Po Lu
2024-01-31 6:41 ` Jim Porter
2024-01-31 13:15 ` Eli Zaretskii
2024-01-31 14:01 ` Po Lu
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).