From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jay Kamat Newsgroups: gmane.emacs.devel Subject: Re: NonGNU ELPA: Conditions for accepting a potential new package 'rmsbolt' ? Date: Fri, 01 Mar 2024 09:37:49 -0800 Message-ID: <87edctetlf.fsf@eve> References: <87jzmsmecw.fsf@jeremybryant.net> <877cir8yap.fsf@posteo.net> <877ciqn8wg.fsf@jeremybryant.net> <87y1b6tkk1.fsf@posteo.net> <87msrleuwd.fsf@eve> Mime-Version: 1.0 Content-Type: text/plain; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21939"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.13; emacs 28.2 Cc: Philip Kaludercic , Jeremy Bryant , "emacs-devel@gnu.org" To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 01 19:34:25 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rg7iC-0005Pj-VG for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Mar 2024 19:34:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rg7gs-0006nG-KW; Fri, 01 Mar 2024 13:33:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rg6uf-0003dE-9A for emacs-devel@gnu.org; Fri, 01 Mar 2024 12:43:13 -0500 Original-Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rg6ud-0008Hd-RZ for emacs-devel@gnu.org; Fri, 01 Mar 2024 12:43:13 -0500 Original-Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1dc49b00bdbso24314575ad.3 for ; Fri, 01 Mar 2024 09:43:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709314990; x=1709919790; darn=gnu.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=cZY5fkMIVRp/2q59vA7+abDVmJhxjgzoAgWRLo87PUw=; b=Rdrorcy/As9TJJR1ZqCg+/o/ZhpHKMXPPaDcL/29H47UNmCwrFz7GwRfPKsrpE++uM CYxd5QBtpOG8Dn07socVFKLhl87kISjUw4GTBzJn/XdiiMTQ+QCLqr8PHo+FkVKPoqEx bTCFnx38H7wPZoSUEEJyms3k2ZjvdOXVYsA4Y5FTiKl2Dpd39auCme3Ksqc3rhgzZ99q ceHfCQHL2XnDFfJIfxuPTvNVxbuCKgLxn3qM2dGa6kfDkbFwmZ3Z4M2SR9spCaEeyp/9 foTpoXhYXKI2owIbdP2J4LFoWMYmVTDyNfIsvTgxwF6W65C4OD6Rdtq2gE1UH+SYFlWL WLqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709314990; x=1709919790; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cZY5fkMIVRp/2q59vA7+abDVmJhxjgzoAgWRLo87PUw=; b=RSW1vJtBncPISO1GHT957e7JJRErrRB2nhPT7mZM0UPD7tihV3DQnHe6U+iegTTVaE 95ogppyCAPUlVnNK5rXKIVubV9/t4uQCGELcctqxHm+AKg+KTstFIGmzYZlXfnAOG9wy gIOs057sy8LOnRGu2jiT7RVHNJhU6WAyx5QO8QRPs+dexDLWBgkabbcKBrLwJS3GJUeu zzY4+O1gPUgSnC4fJhQiuQRrtp4MeuwFLwmTT9Io95SolGMVnr1bLTU98I5UX0UTWX4j WsCuw97TPimbv9Uf2zJjluhB04nY8sgt9ZGfhyTCnxrZhxFah8yzT0uf3LqtfR///6qU YTVA== X-Forwarded-Encrypted: i=1; AJvYcCXugoszFZInzuobmg//aB41NeCrd+2Bcjn16tPtZIBOy8rECTopZXMXNfIvBcqfKYabRizxbzLDiDUbst1DRET6XzwZ X-Gm-Message-State: AOJu0YxdKoV1oZAl2VmKI1BBLdXnC5lfMZdB7yKOMbjylW9RDolPjeCh 9AQxYRDmfnoDFihTCHn6VFOAPoOeZ4mnLkCXEqfTHMdsvrIwiPmUQcMpZhxd X-Google-Smtp-Source: AGHT+IE3sp/rbo6F7RUjy7XsBMeNhzsq8NXnjKCEkOZFg0S7RQ3B9j6xTBMGW58VJzyFaIsmzZ9xfQ== X-Received: by 2002:a17:902:654a:b0:1dc:ca72:8318 with SMTP id d10-20020a170902654a00b001dcca728318mr1885562pln.37.1709314989766; Fri, 01 Mar 2024 09:43:09 -0800 (PST) Original-Received: from eve (c-98-207-12-150.hsd1.ca.comcast.net. [98.207.12.150]) by smtp.gmail.com with ESMTPSA id h19-20020a170902f2d300b001db63cfe07dsm3717781plc.283.2024.03.01.09.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:43:09 -0800 (PST) In-reply-to: Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=jaygkamat@gmail.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 01 Mar 2024 13:32:53 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316670 Archived-At: Stefan Monnier writes: > > Also, I see: > > (rmsbolt--convert-file-name-to-system-type > (shell-quote-argument > > which is very weird. The reverse would make more sense. I agree - this system-type function only does something on cygwin systems currently and I don't have any windows machines - so I'm unable to test it at all, which is why I avoided changing this. I might try to swap these around (and probably remove some escaping in the system-type function) and see if anyone complains. > Also I think `shell-quote-argument` should be applied to most parts of > `rmsbolt--demangle-command`. This function is also odd in that it > calls `rmsbolt--convert-file-name-to-system-type` on the files > of the demangler but not those of the `mv`. I agree - I've been a little lax about that, especially in this function - once I get some more time, I'll try to refactor things so there's one "filename quoting" function, that simply runs `shell-quote-argument' on unix and additionally does the cygwin conversion if needed - that way this logic is consistent. Thanks so much for taking a look, regardless, it really helps improve the quality of the codebase! -Jay