Re: NonGNU ELPA: Conditions for accepting a potential new package 'rmsbolt' ?

[Jay Kamat <jaygkamat@gmail.com>]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>
> Also, I see:
>
>           (rmsbolt--convert-file-name-to-system-type
>            (shell-quote-argument
>
> which is very weird.  The reverse would make more sense.

I agree - this system-type function only does something on cygwin systems 
currently and I don't have any windows machines - so I'm unable to test it at 
all, which is why I avoided changing this. I might try to swap these around 
(and probably remove some escaping in the system-type function) and see if 
anyone complains.

> Also I think `shell-quote-argument` should be applied to most parts of
> `rmsbolt--demangle-command`.  This function is also odd in that it
> calls `rmsbolt--convert-file-name-to-system-type` on the files
> of the demangler but not those of the `mv`.

I agree - I've been a little lax about that, especially in this function - 
once I get some more time, I'll try to refactor things so there's one 
"filename quoting" function, that simply runs `shell-quote-argument' on unix 
and additionally does the cygwin conversion if needed - that way this logic is 
consistent.

Thanks so much for taking a look, regardless, it really helps improve the 
quality of the codebase!

-Jay