From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Collin Funk Newsgroups: gmane.emacs.devel Subject: Re: master a86c25c91f3 11/13: Prefer -I to -isystem Date: Wed, 17 Jul 2024 09:20:06 -0700 Message-ID: <87ed7suh1l.fsf@gmail.com> References: <868qy0gmjp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30599"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Paul Eggert , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 17 18:21:23 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sU7P8-0007kX-OB for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Jul 2024 18:21:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sU7OP-0005kv-Ih; Wed, 17 Jul 2024 12:20:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sU7O6-0005fr-TR for emacs-devel@gnu.org; Wed, 17 Jul 2024 12:20:19 -0400 Original-Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sU7O1-0001Xs-Mn; Wed, 17 Jul 2024 12:20:16 -0400 Original-Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1fbfb8e5e0cso50458865ad.0; Wed, 17 Jul 2024 09:20:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721233209; x=1721838009; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jrk96vCKIO5t/+lUXYIMczNeXd/buI/YfLujyQc9Euw=; b=AmleBJycQegpaFVevlLv6aTIqjzyPCB4R48QRsuIowr525LLShEtq1HTr6m/E4YYBw bDrcVwQ49x2/EuwlX4n2NshWB8jYhmeLpjBDHlT07VjVuGAawxrBrSbD8+lal58v6uWd YWdL+bQGTurejeqI/UsHJpyO2cuujZyfwiH4bvNyisHJ28Pjc7H0qDn3xF9HDyDSLPWN IaANr5Q4SGvnW9lgu7FXKNusBntNUzSjfIrAgtptjb/yQLnD4mGMnFTMEwiSUz2HcSVb b2FkXRxigeCGWBxCh+hcy5Tu7XfMKgEJS/yfiu7tHddpnnOLCQU5F9YvBCCGi26H3t1A 3Sew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721233209; x=1721838009; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Jrk96vCKIO5t/+lUXYIMczNeXd/buI/YfLujyQc9Euw=; b=EN5nJj5c3+nbE6uWpgDkJtyQ3kCaFWBGJSGo6zKUm+esq9tnRP5BBPrRp7VscfBvM6 O5+UNui2KYV60dTQ0nmnfGXv2pGvdkrGwIPlSEog8fcByTQ3nt0fx6NWGCedrvnQSlGo zKEp/3tZ+AgOJrn9RJk93fr/aTaMfhC8Ee4JoWOZk5qj0qA/f1xd5/bDcMoawq14HU5N P1HCeL4bB7uWIldEs6Ux0Ecu2rzJ/bhXV+hgP1cmxxDB/FyhAy9ftRlAYYF7mbNdxPjL lr+WOTiy7E/0uyo1JrjHx1/aZCH03YVRpIG8Gg+Iyw1V+30SIkzxwXi07EjVKEWwihF+ o5hw== X-Forwarded-Encrypted: i=1; AJvYcCW6ooJyTQJ0Qb+FHuTF6tjf1DAr1+/rEBtPDr9zD77ctKJw3mhy/GriOdFXUnaM00faQxasUXpEcXSGrdEVSFPoIbGT X-Gm-Message-State: AOJu0YxOOopDbgxUI+d46irpDpJ4nZmxUvZNCfnBK/srcwn9X1txYDTk DE1nMrWQkDm+Zut165+MzSq4sT43GzdoW5NgyXG54DmDfW6/jNTtRK3xmA== X-Google-Smtp-Source: AGHT+IGm32k4FogjNwjkCqB9ZEnWoqG6RBcqw2wW8PBlpIHfXVuOIoNAUs7w7cI9piBz3v4k7AzA2Q== X-Received: by 2002:a17:902:c40a:b0:1fb:72ea:376 with SMTP id d9443c01a7336-1fc4e70b9cdmr14956735ad.65.1721233208864; Wed, 17 Jul 2024 09:20:08 -0700 (PDT) Original-Received: from fedora (c-67-180-36-62.hsd1.ca.comcast.net. [67.180.36.62]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fc0bc44941sm76850175ad.239.2024.07.17.09.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 09:20:08 -0700 (PDT) In-Reply-To: <868qy0gmjp.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 17 Jul 2024 16:44:58 +0300") Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=collin.funk1@gmail.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321758 Archived-At: Eli Zaretskii writes: > d:/usr/include/glib-2.0/gobject/gparam.h:157:35: warning: result of '1 = << 31' requires 33 bits to represent, but 'int' only has 32 bits [-Wshift-o= verflow=3D] > 157 | G_PARAM_DEPRECATED =3D 1 << 31 > | ^~ > > While arguably a bug in Glib, the diagnostic is an annoyance, so I'd > like to avoid it. I've verified that -Wno-system-headers doesn't > remove it. -Wno-shift-overflow does, but I don't think suppressing > that globally is a good idea. It is a bug since (1 * 2^31) is equal to INT_MAX + 1 on most platforms. C23 =C2=A7 6.5.7 says this is undefined behavior [1]. GCC and Clang both seem to handle it fine but the warning is correct. Although it is annoying when it occurs in included headers. I ran into a similar issue with GCC intrinsic doing (1 << 31) too. The glib bug was fixed at some point since my system has: G_PARAM_DEPRECATED =3D (gint)(1u << 31) Which is the same as I did for GCC. Collin [1] https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3096.pdf