Re: : : master 7f97cf31dc3: Create blessmail at build time instead of install time

[Michael Heerdegen via "Emacs development discussions." <emacs-devel@gnu.org>]

Pip Cet <pipcet@protonmail.com> writes:

> +(defun blessmail-command (string)
> +  (if (and (boundp 'blessmail-doit)
> +           blessmail-doit)
> +      (shell-command string)
> +    (message (concat "  " string))))

Better (message "%s" ...) maybe?  But my main point is:

> +    (unless (= ?w (aref modes 8))
> +      (message (concat "Assuming %s is really the mail spool directory, you should\n"
> +                       "run the following commands as root, to give  %s\n"
> +                       "appropriate permissions:\n")
> +               dirname (file-name-nondirectory movemail-path))
> +      (cond
> +       ((= ?w (aref modes 5))
> +	(blessmail-command
> +         (concat "chgrp " (number-to-string (file-attribute-group-id attr))
> +		 " " movemail-path " && chmod g+s " movemail-path)))
> +       ((= ?w (aref modes 2))
> +        (blessmail-command
> +         (concat "chown " (number-to-string (file-attribute-user-id attr))
> +		 " " movemail-path " && chmod u+s " movemail-path)))
> +       (t
> +        (blessmail-command
> +         (concat "chown root " movemail-path " && chmod u+s " movemail-path)))))
> +    (message "\nDo that after running  make install.")))
>  (kill-emacs)

Not an expert for shell stuff, but: wouldn't this cause trouble for
people using a non-posix compliant shell, like the popular fish shell?

AFAIU this will be called before the user can even set `shell-file-name'.


Michael.