unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* A lot of warnings building Emacs master
@ 2024-10-26 23:12 Angelo Graziosi
  2024-10-27  0:37 ` Andy Moreton
  2024-10-27  2:26 ` Sean Whitton
  0 siblings, 2 replies; 10+ messages in thread
From: Angelo Graziosi @ 2024-10-26 23:12 UTC (permalink / raw)
  To: emacs-devel

Building last master (commit 523aade3ea11c188e30e3889f031d1848129cf82) I 
get about 10615 (grep -c ...) "Warning" like this:

org-src.el: Warning: `if-let' is an obsolete macro (as of 31.1); use 
`if-let*' instead.


Ciao,
   Angelo.




^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: A lot of warnings building Emacs master
  2024-10-26 23:12 A lot of warnings building Emacs master Angelo Graziosi
@ 2024-10-27  0:37 ` Andy Moreton
  2024-10-27  6:22   ` Eli Zaretskii
                     ` (2 more replies)
  2024-10-27  2:26 ` Sean Whitton
  1 sibling, 3 replies; 10+ messages in thread
From: Andy Moreton @ 2024-10-27  0:37 UTC (permalink / raw)
  To: emacs-devel

On Sun 27 Oct 2024, Angelo Graziosi wrote:

> Building last master (commit 523aade3ea11c188e30e3889f031d1848129cf82) I get
> about 10615 (grep -c ...) "Warning" like this:
>
> org-src.el: Warning: `if-let' is an obsolete macro (as of 31.1); use `if-let*'
> instead.

I see this also. The change to mark this as obsolete is premature.

Marking as obsolete to avoid new uses being introduced should only be
done after reworking the existing  codebase  to remove the majority of
existing calls.

The current situation of leaving hundreds of lines of warning noise in
the build output makes it harder to see other problems, and is not good.

    AndyM




^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: A lot of warnings building Emacs master
  2024-10-26 23:12 A lot of warnings building Emacs master Angelo Graziosi
  2024-10-27  0:37 ` Andy Moreton
@ 2024-10-27  2:26 ` Sean Whitton
  1 sibling, 0 replies; 10+ messages in thread
From: Sean Whitton @ 2024-10-27  2:26 UTC (permalink / raw)
  To: Angelo Graziosi; +Cc: emacs-devel

Hello,

On Sun 27 Oct 2024 at 01:12am +02, Angelo Graziosi wrote:

> Building last master (commit 523aade3ea11c188e30e3889f031d1848129cf82) I get
> about 10615 (grep -c ...) "Warning" like this:
>
> org-src.el: Warning: `if-let' is an obsolete macro (as of 31.1); use `if-let*'
> instead.

Known issue, sorry for the noise.

-- 
Sean Whitton



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: A lot of warnings building Emacs master
  2024-10-27  0:37 ` Andy Moreton
@ 2024-10-27  6:22   ` Eli Zaretskii
  2024-10-27  7:11     ` Sean Whitton
  2024-10-27  7:06   ` Po Lu
  2024-10-27  8:17   ` Andrea Corallo
  2 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2024-10-27  6:22 UTC (permalink / raw)
  To: Andy Moreton, Sean Whitton; +Cc: emacs-devel

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Sun, 27 Oct 2024 01:37:12 +0100
> 
> On Sun 27 Oct 2024, Angelo Graziosi wrote:
> 
> > Building last master (commit 523aade3ea11c188e30e3889f031d1848129cf82) I get
> > about 10615 (grep -c ...) "Warning" like this:
> >
> > org-src.el: Warning: `if-let' is an obsolete macro (as of 31.1); use `if-let*'
> > instead.
> 
> I see this also. The change to mark this as obsolete is premature.
> 
> Marking as obsolete to avoid new uses being introduced should only be
> done after reworking the existing  codebase  to remove the majority of
> existing calls.
> 
> The current situation of leaving hundreds of lines of warning noise in
> the build output makes it harder to see other problems, and is not good.

Agreed.

Sean, how do we plan to handle this? and how soon?



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: A lot of warnings building Emacs master
  2024-10-27  0:37 ` Andy Moreton
  2024-10-27  6:22   ` Eli Zaretskii
@ 2024-10-27  7:06   ` Po Lu
  2024-10-27  8:17   ` Andrea Corallo
  2 siblings, 0 replies; 10+ messages in thread
From: Po Lu @ 2024-10-27  7:06 UTC (permalink / raw)
  To: Andy Moreton; +Cc: emacs-devel

Andy Moreton <andrewjmoreton@gmail.com> writes:

> On Sun 27 Oct 2024, Angelo Graziosi wrote:
>
>> Building last master (commit 523aade3ea11c188e30e3889f031d1848129cf82) I get
>> about 10615 (grep -c ...) "Warning" like this:
>>
>> org-src.el: Warning: `if-let' is an obsolete macro (as of 31.1); use `if-let*'
>> instead.
>
> I see this also. The change to mark this as obsolete is premature.
>
> Marking as obsolete to avoid new uses being introduced should only be
> done after reworking the existing  codebase  to remove the majority of
> existing calls.
>
> The current situation of leaving hundreds of lines of warning noise in
> the build output makes it harder to see other problems, and is not good.
>
>     AndyM

+1.  I don't understand why it was necessary to obsolete if-let anyway.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: A lot of warnings building Emacs master
  2024-10-27  6:22   ` Eli Zaretskii
@ 2024-10-27  7:11     ` Sean Whitton
  2024-10-27  8:30       ` Michael Albinus
  2024-10-27  9:41       ` Stefan Kangas
  0 siblings, 2 replies; 10+ messages in thread
From: Sean Whitton @ 2024-10-27  7:11 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Andy Moreton, emacs-devel

Hello,

On Sun 27 Oct 2024 at 08:22am +02, Eli Zaretskii wrote:

> Sean, how do we plan to handle this? and how soon?

I fixed all the warnings when I marked it as obsolete, except for
externally maintained packages.

Org I fixed today, after talking to upstream.

Michael reports he has the TRAMP warnings fixed in tramp.git, and
expects to import it to emacs.git within ~5 days.

Then only transient.el remains.  I sent a patch upstream.  But I could
also just commit my patch here to get rid of the warnings?

-- 
Sean Whitton



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: A lot of warnings building Emacs master
  2024-10-27  0:37 ` Andy Moreton
  2024-10-27  6:22   ` Eli Zaretskii
  2024-10-27  7:06   ` Po Lu
@ 2024-10-27  8:17   ` Andrea Corallo
  2 siblings, 0 replies; 10+ messages in thread
From: Andrea Corallo @ 2024-10-27  8:17 UTC (permalink / raw)
  To: Andy Moreton; +Cc: emacs-devel

Andy Moreton <andrewjmoreton@gmail.com> writes:

> On Sun 27 Oct 2024, Angelo Graziosi wrote:
>
>> Building last master (commit 523aade3ea11c188e30e3889f031d1848129cf82) I get
>> about 10615 (grep -c ...) "Warning" like this:
>>
>> org-src.el: Warning: `if-let' is an obsolete macro (as of 31.1); use `if-let*'
>> instead.
>
> I see this also. The change to mark this as obsolete is premature.
>
> Marking as obsolete to avoid new uses being introduced should only be
> done after reworking the existing  codebase  to remove the majority of
> existing calls.
>
> The current situation of leaving hundreds of lines of warning noise in
> the build output makes it harder to see other problems, and is not good.
>
>     AndyM

Agree, we should strive for pushing only warning free commits.

I see Sean is putting effort in fixing this, but I often even see
commits introducing new warnings in the hope that other contributors fix
them in the future, this is not okay.

That said I don't understand as well why was necessary to obsolete
if-let in favor of if-let*, but bug#73853 has some reference to previous
discussions (which I had no time to go through) and the change was
agreed by a maintainer.

  Andrea



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: A lot of warnings building Emacs master
  2024-10-27  7:11     ` Sean Whitton
@ 2024-10-27  8:30       ` Michael Albinus
  2024-10-27  9:41       ` Stefan Kangas
  1 sibling, 0 replies; 10+ messages in thread
From: Michael Albinus @ 2024-10-27  8:30 UTC (permalink / raw)
  To: Sean Whitton; +Cc: Eli Zaretskii, Andy Moreton, emacs-devel

Sean Whitton <spwhitton@spwhitton.name> writes:

> Hello,

Hi,

> Michael reports he has the TRAMP warnings fixed in tramp.git, and
> expects to import it to emacs.git within ~5 days.

If it really matters, I could apply a Tramp patch soon. However, I
prefer to run comprehensive regression tests first in Tramp's git repo,
this will take some few days, as Sean has said.

Best regards, Michael.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: A lot of warnings building Emacs master
  2024-10-27  7:11     ` Sean Whitton
  2024-10-27  8:30       ` Michael Albinus
@ 2024-10-27  9:41       ` Stefan Kangas
  2024-10-27 10:53         ` Sean Whitton
  1 sibling, 1 reply; 10+ messages in thread
From: Stefan Kangas @ 2024-10-27  9:41 UTC (permalink / raw)
  To: Sean Whitton, Eli Zaretskii; +Cc: Andy Moreton, emacs-devel, Jonas Bernoulli

Sean Whitton <spwhitton@spwhitton.name> writes:

> Then only transient.el remains.  I sent a patch upstream.  But I could
> also just commit my patch here to get rid of the warnings?

Please apply that patch, yes.



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: A lot of warnings building Emacs master
  2024-10-27  9:41       ` Stefan Kangas
@ 2024-10-27 10:53         ` Sean Whitton
  0 siblings, 0 replies; 10+ messages in thread
From: Sean Whitton @ 2024-10-27 10:53 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: emacs-devel, Eli Zaretskii

Hello,

On Sun 27 Oct 2024 at 04:41am -05, Stefan Kangas wrote:

> Sean Whitton <spwhitton@spwhitton.name> writes:
>
>> Then only transient.el remains.  I sent a patch upstream.  But I could
>> also just commit my patch here to get rid of the warnings?
>
> Please apply that patch, yes.

Okay, installed that on master, and confirmed with a bootstrap build
that only TRAMP remains.

-- 
Sean Whitton



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-10-27 10:53 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-26 23:12 A lot of warnings building Emacs master Angelo Graziosi
2024-10-27  0:37 ` Andy Moreton
2024-10-27  6:22   ` Eli Zaretskii
2024-10-27  7:11     ` Sean Whitton
2024-10-27  8:30       ` Michael Albinus
2024-10-27  9:41       ` Stefan Kangas
2024-10-27 10:53         ` Sean Whitton
2024-10-27  7:06   ` Po Lu
2024-10-27  8:17   ` Andrea Corallo
2024-10-27  2:26 ` Sean Whitton

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).