From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Merge haskell-ts-mode in upstream Date: Tue, 31 Dec 2024 13:49:03 +0000 Message-ID: <87ed1o2ca8.fsf@posteo.net> References: <87cyhh7t00.fsf@bauherren.ovh> <87msglb89y.fsf@posteo.net> <87ed1s1akm.fsf@bauherren.ovh> <87msgfzsvl.fsf@posteo.net> <87r05rmxhm.fsf@bauherren.ovh> <87cyhazgw5.fsf@posteo.net> <875xn28qzj.fsf@bauherren.ovh> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4754"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Pranshu Sharma via "Emacs development discussions." To: Pranshu Sharma Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 31 14:49:23 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tSccc-000144-Ns for ged-emacs-devel@m.gmane-mx.org; Tue, 31 Dec 2024 14:49:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tSccN-0001q0-VX; Tue, 31 Dec 2024 08:49:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSccM-0001pr-O7 for emacs-devel@gnu.org; Tue, 31 Dec 2024 08:49:06 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tSccL-0004iY-B4 for emacs-devel@gnu.org; Tue, 31 Dec 2024 08:49:06 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 23923240027 for ; Tue, 31 Dec 2024 14:49:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1735652944; bh=UssJyFC39uqvERx50aW/4kjAHs38V8GZO6LdnhIq10E=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=F09Rx0jNRAZjWz1k/2UIgkjR8btIIhlTf4IizYHd0FE/ogM0lWz4htCp+Lw8PxBIy 8lGJu9KqLNhTT4o2XYXbB7i49Kgxxr8tdV3wkTaVeP+nSB4eaqYqAGTc7cmMwje/kd DYA9A3fZZ5/yNvksxMZuV5Azd/uHgyk54HJqHyxv4GVE1567UA1XeE+D+5p8nCplhu uXlMyXkYZLxK+/0G2MqF60H2hDz1+M/qtCmHvDXfw4snDloWeVglunNJiDdr4DnCMj 2o7Wvak8iZ7DysgB/F1wAOqqKcuy7l2gbKXrsw5YhOIm54mB635qtoejlJdBCW2Pit bKcwX4aXVB1wg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YMvTC52DBz9rxD; Tue, 31 Dec 2024 14:49:03 +0100 (CET) In-Reply-To: <875xn28qzj.fsf@bauherren.ovh> (Pranshu Sharma's message of "Mon, 30 Dec 2024 01:10:24 +1000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327503 Archived-At: Pranshu Sharma writes: >>>>> I attach new file, I have also pushed changes to codebrg repo. >>>> >>>> I think it would be someone with more Tree Sitter experience could >>>> take >>>> a look at the code as well. Perhaps we should make this more >>>> formal by >>>> moving over to the bug tracker? >>> >>> Sounds good. >> >> 1+ > > Ok, done > > Thanks again for your inital code reivew and patiant replys It would be helpful if you could prepare a patch against emacs.git, which would also update NEWS and the documentation where applicable, otherwise I can do it but it might take me some time.