From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: VC-SVN problem Date: 08 May 2004 19:16:30 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <87d65exxnl.fsf@floss.red-bean.com> References: <20040508013158.GB7312@fornax.collapsar.net> <878yg4yppi.fsf@floss.red-bean.com> <20040508022659.GC7312@fornax.collapsar.net> Reply-To: kfogel@red-bean.com NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1084084650 14304 80.91.224.253 (9 May 2004 06:37:30 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 9 May 2004 06:37:30 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sun May 09 08:37:23 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BMhwB-0007us-00 for ; Sun, 09 May 2004 08:37:23 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BMhwB-0008RL-00 for ; Sun, 09 May 2004 08:37:23 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.33) id 1BMhvx-0004Ev-PX for emacs-devel@quimby.gnus.org; Sun, 09 May 2004 02:37:09 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.33) id 1BMhtw-0003Zy-K3 for emacs-devel@gnu.org; Sun, 09 May 2004 02:35:04 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.33) id 1BMhsm-00030Q-JK for emacs-devel@gnu.org; Sun, 09 May 2004 02:34:27 -0400 Original-Received: from [207.115.63.73] (helo=pimout5-ext.prodigy.net) by monty-python.gnu.org with esmtp (Exim 4.33) id 1BMhsm-0002s8-4n for emacs-devel@gnu.org; Sun, 09 May 2004 02:33:52 -0400 Original-Received: from floss.red-bean.com (adsl-64-108-195-105.dsl.chcgil.ameritech.net [64.108.195.105]) by pimout5-ext.prodigy.net (8.12.10 milter /8.12.10) with ESMTP id i496XUxx116016 for ; Sun, 9 May 2004 02:33:31 -0400 Original-Received: from kfogel by floss.red-bean.com with local (Exim 3.34 #1 (Debian)) id 1BMbza-0003gM-00 for ; Sat, 08 May 2004 19:16:30 -0500 Original-To: emacs-devel@gnu.org X-Windows: a mistake carried out to perfection. In-Reply-To: <20040508022659.GC7312@fornax.collapsar.net> Original-Lines: 55 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:22969 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:22969 Shawn Boyette wrote regarding vc-svn.el: > > Shawn, in the meantime, see if putting > > > > (require 'cl) > > > > in your .emacs fixes the problem. > > Indeed it does; many thanks. So, I'd like to fix this in vc-svn.el, in the simplest way: by adding (require 'cl) so that 'list*' is available. But that brings me to a larger question, which is, what *are* the criteria for committing to files in Emacs? I've been trying to grok the answer by watching this list, but that's not working as well as I'd hoped. I'm not talking about controversial new features here. Clearly, those need to be discussed on the list, and a consensus should emerge, before they are checked in. I'm just talking about bugfixes (like this one to vc-svn.el) and minor enhancements. In some other projects, a committer can commit anywhere, according to their judgement. If a change is wrong, or non-optimal, this can be brought up on the list later and the problem can be resolved with a new change, or an explanation of why the old change really is okay, or whatever. In other projects, voting is required; in still other projects, approvial by an area maintainer is required. These policies are usually spelled out in some file called HACKING or DEVEL or MAINTENANCE, in the top level of the project. There are no such written guidelines for Emacs, as far as I can tell (?). The only thing I've been able to glean from lurking is that a) RMS seems to have the final say b) certain area maintainers commit without discussion I haven't rethreaded this message, because it might be that the answer is simple and doesn't need to happen in a new thread. (Maybe there's a written guideline, and I just missed it somehow?) Anyway, to return to my original question: is it okay to commit this change to vc-svn.el? Thanks, -Karl P.S. Is emacs-commit unused now? It appears to be all spam since the beginning of this year, according to the archives, though there were real commit mails before then. The exact same situation seems to hold for emacs-diffs, which makes me wonder if they're not two names for the same list... http://mail.gnu.org/archive/html/emacs-commit/ http://mail.gnu.org/archive/html/emacs-diffs/