* Recent changes to Calendar/Diary
@ 2005-09-13 6:32 Romain Francoise
2005-09-13 15:05 ` Stefan Monnier
2005-09-16 16:04 ` Stefan Monnier
0 siblings, 2 replies; 9+ messages in thread
From: Romain Francoise @ 2005-09-13 6:32 UTC (permalink / raw)
With today's Emacs: when I do M-x calendar, instead of just telling me
that there are no diary items for today as it used to, Emacs jumps to
the next diary-anniversary entry in my diary, which is on September
25th.
Is this intentional?
--
Romain Francoise <romain@orebokech.com> | I used to think there is no
it's a miracle -- http://orebokech.com/ | future left at all.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Recent changes to Calendar/Diary
2005-09-13 6:32 Recent changes to Calendar/Diary Romain Francoise
@ 2005-09-13 15:05 ` Stefan Monnier
2005-09-16 16:04 ` Stefan Monnier
1 sibling, 0 replies; 9+ messages in thread
From: Stefan Monnier @ 2005-09-13 15:05 UTC (permalink / raw)
Cc: emacs-devel
> With today's Emacs: when I do M-x calendar, instead of just telling me
> that there are no diary items for today as it used to, Emacs jumps to
> the next diary-anniversary entry in my diary, which is on September
> 25th.
> Is this intentional?
Nope. I must have messed up something. I'll take a look at it later today,
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Recent changes to Calendar/Diary
2005-09-13 6:32 Recent changes to Calendar/Diary Romain Francoise
2005-09-13 15:05 ` Stefan Monnier
@ 2005-09-16 16:04 ` Stefan Monnier
2005-09-16 16:51 ` Romain Francoise
1 sibling, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2005-09-16 16:04 UTC (permalink / raw)
Cc: emacs-devel
> With today's Emacs: when I do M-x calendar, instead of just telling me
> that there are no diary items for today as it used to, Emacs jumps to
> the next diary-anniversary entry in my diary, which is on September
> 25th.
The patch I just installed should have fixed it.
Please confirm,
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Recent changes to Calendar/Diary
2005-09-16 16:04 ` Stefan Monnier
@ 2005-09-16 16:51 ` Romain Francoise
2005-09-19 13:24 ` Stefan Monnier
0 siblings, 1 reply; 9+ messages in thread
From: Romain Francoise @ 2005-09-16 16:51 UTC (permalink / raw)
Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> The patch I just installed should have fixed it.
It doesn't, but reversing the order of with-current-buffer and
save-excursion in your new version of the function does.
--
Romain Francoise <romain@orebokech.com> | The world is a fine place,
it's a miracle -- http://orebokech.com/ | and worth fighting for.
| --Ernest Hemingway
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Recent changes to Calendar/Diary
2005-09-16 16:51 ` Romain Francoise
@ 2005-09-19 13:24 ` Stefan Monnier
2005-09-19 13:46 ` Romain Francoise
0 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2005-09-19 13:24 UTC (permalink / raw)
Cc: emacs-devel
>> The patch I just installed should have fixed it.
> It doesn't, but reversing the order of with-current-buffer and
> save-excursion in your new version of the function does.
Hmm.... curious ... I'll take yet another look,
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Recent changes to Calendar/Diary
2005-09-19 13:24 ` Stefan Monnier
@ 2005-09-19 13:46 ` Romain Francoise
2005-09-19 15:49 ` Stefan Monnier
0 siblings, 1 reply; 9+ messages in thread
From: Romain Francoise @ 2005-09-19 13:46 UTC (permalink / raw)
Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Hmm.... curious ... I'll take yet another look,
Note that I installed a change yesterday to that effect.
--
Romain Francoise <romain@orebokech.com> | I've become someone else's
it's a miracle -- http://orebokech.com/ | nightmare...
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Recent changes to Calendar/Diary
2005-09-19 13:46 ` Romain Francoise
@ 2005-09-19 15:49 ` Stefan Monnier
2005-09-19 16:05 ` Romain Francoise
0 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2005-09-19 15:49 UTC (permalink / raw)
Cc: emacs-devel
>> Hmm.... curious ... I'll take yet another look,
> Note that I installed a change yesterday to that effect.
I think it hides the actual problem.
A `save-excursion' around `with-current-buffer' is just very weird.
What happens if you revert your patch and apply the one below instead?
Stefan
--- calendar.el 12 sep 2005 17:27:05 -0400 1.176
+++ calendar.el 19 sep 2005 11:45:08 -0400
@@ -2900,8 +2900,8 @@
MARK is a single-character string, a list of face attributes/values, or a face.
MARK defaults to `diary-entry-marker'."
(if (calendar-date-is-legal-p date)
+ (with-current-buffer calendar-buffer
(save-excursion
- (set-buffer calendar-buffer)
(calendar-cursor-to-visible-date date)
(let ((mark (or (and (stringp mark) (= (length mark) 1) mark) ; single-char
(and (listp mark) (> (length mark) 0) mark) ; attr list
@@ -2936,7 +2940,7 @@
;; Apply the font aspects
(apply 'set-face-attribute temp-face nil mark)
(overlay-put
- (make-overlay (1- (point)) (1+ (point))) 'face temp-face))))))))
+ (make-overlay (1- (point)) (1+ (point))) 'face temp-face)))))))))
(defun calendar-star-date ()
"Replace the date under the cursor in the calendar window with asterisks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Recent changes to Calendar/Diary
2005-09-19 15:49 ` Stefan Monnier
@ 2005-09-19 16:05 ` Romain Francoise
2005-09-19 17:41 ` Stefan Monnier
0 siblings, 1 reply; 9+ messages in thread
From: Romain Francoise @ 2005-09-19 16:05 UTC (permalink / raw)
Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I think it hides the actual problem.
> A `save-excursion' around `with-current-buffer' is just very weird.
Yup.
> What happens if you revert your patch and apply the one below instead?
My bug is gone, indeed.
I've reverted my change, please install this better patch instead.
Thanks,
--
Romain Francoise <romain@orebokech.com> | I just thought I'd go out
it's a miracle -- http://orebokech.com/ | with a little bit more style.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: Recent changes to Calendar/Diary
2005-09-19 16:05 ` Romain Francoise
@ 2005-09-19 17:41 ` Stefan Monnier
0 siblings, 0 replies; 9+ messages in thread
From: Stefan Monnier @ 2005-09-19 17:41 UTC (permalink / raw)
Cc: emacs-devel
>> I think it hides the actual problem.
>> A `save-excursion' around `with-current-buffer' is just very weird.
> Yup.
>> What happens if you revert your patch and apply the one below instead?
> My bug is gone, indeed.
> I've reverted my change, please install this better patch instead.
Done, thank you,
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2005-09-19 17:41 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-13 6:32 Recent changes to Calendar/Diary Romain Francoise
2005-09-13 15:05 ` Stefan Monnier
2005-09-16 16:04 ` Stefan Monnier
2005-09-16 16:51 ` Romain Francoise
2005-09-19 13:24 ` Stefan Monnier
2005-09-19 13:46 ` Romain Francoise
2005-09-19 15:49 ` Stefan Monnier
2005-09-19 16:05 ` Romain Francoise
2005-09-19 17:41 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).