From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Patch that adds help to isearch Date: Wed, 30 Nov 2005 17:34:23 +0200 Organization: JURTA Message-ID: <87d5kicfpc.fsf@jurta.org> References: <36dd4d936dd9fb.36dd9fb36dd4d9@net.lu.se> <87r78yswf4.fsf@jurta.org> <438D61D4.1040002@student.lu.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1133373935 13112 80.91.229.2 (30 Nov 2005 18:05:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 30 Nov 2005 18:05:35 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 30 19:05:31 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EhVax-0006px-Vr for ged-emacs-devel@m.gmane.org; Wed, 30 Nov 2005 18:18:16 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EhVax-0008DH-2E for ged-emacs-devel@m.gmane.org; Wed, 30 Nov 2005 12:18:15 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EhU86-0002fu-AQ for emacs-devel@gnu.org; Wed, 30 Nov 2005 10:44:22 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EhU7x-0002eR-DZ for emacs-devel@gnu.org; Wed, 30 Nov 2005 10:44:20 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EhU7w-0002eK-G1 for emacs-devel@gnu.org; Wed, 30 Nov 2005 10:44:12 -0500 Original-Received: from [194.126.101.111] (helo=mail.neti.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EhU7q-0002rF-Gh; Wed, 30 Nov 2005 10:44:06 -0500 Original-Received: from mail.neti.ee (80-235-34-14-dsl.mus.estpak.ee [80.235.34.14]) by Relayhost1.neti.ee (Postfix) with ESMTP id 2553D1CB9; Wed, 30 Nov 2005 17:44:21 +0200 (EET) Original-To: Lennart Borgman In-Reply-To: <438D61D4.1040002@student.lu.se> (Lennart Borgman's message of "Wed, 30 Nov 2005 09:24:52 +0100") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:46819 Archived-At: > In the patch I sent before I also added scrolling of the help > buffer. Scrolling of the help buffer is done by the keys the user > has bound to scroll-other-window' and 'scroll-other-window-down'. > It is only active when the other window is the help buffer. Isn't an easier way to achieve this by setting `isearch-allow-scroll' to t? Note that isearch.el already contains: (put 'scroll-other-window 'isearch-scroll t) (put 'scroll-other-window-down 'isearch-scroll t) > However the scrolling could of course be dependent on if C-h and f1 > is bound to isearch-mode-help. A defcustom seems more easy to > understand though. I think it should be rather dependent on if the other window is the help buffer created by isearch-mode-help, than if C-h and f1 is bound, because users can bind isearch-mode-help to other keys. -- Juri Linkov http://www.jurta.org/emacs/