From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: [PATCH] Better error reporting in Gnus splitting. Date: Tue, 18 Jul 2006 18:49:09 -0500 Message-ID: <87d5c2jwy2.fsf@floss.red-bean.com> Reply-To: kfogel@red-bean.com NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1153274288 32223 80.91.229.2 (19 Jul 2006 01:58:08 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 19 Jul 2006 01:58:08 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 19 03:58:07 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G31KA-0008Dz-RB for ged-emacs-devel@m.gmane.org; Wed, 19 Jul 2006 03:58:07 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G31KA-0001Kq-BC for ged-emacs-devel@m.gmane.org; Tue, 18 Jul 2006 21:58:06 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1G31Jy-0001Jv-QI for emacs-devel@gnu.org; Tue, 18 Jul 2006 21:57:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1G31Jw-0001Jj-Bj for emacs-devel@gnu.org; Tue, 18 Jul 2006 21:57:53 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G31Jw-0001Jg-7H for emacs-devel@gnu.org; Tue, 18 Jul 2006 21:57:52 -0400 Original-Received: from [66.146.193.61] (helo=sanpietro.red-bean.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1G31Mx-0006AF-0N for emacs-devel@gnu.org; Tue, 18 Jul 2006 22:00:59 -0400 Original-Received: from localhost ([127.0.0.1]:46356 helo=floss.red-bean.com) by sanpietro.red-bean.com with esmtp (Exim 4.62) (envelope-from ) id 1G31Ju-0006Ip-N1 for emacs-devel@gnu.org; Tue, 18 Jul 2006 20:57:50 -0500 Original-To: emacs-devel@gnu.org Emacs: the only text-editing software to require its own heat sink. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:57304 Archived-At: Any objections if I commit this patch? Without this patch, when splitting encounters an error (say, an invalid regular expression) in the nnmail-split-fancy list, then the user is simply told that there is an error, but is given no details about the error's nature. The mail gets split into the 'bogus' mail group, and the user has no idea why. With this patch, the user is informed about the general nature of the error and may then be able to track it down. (The error report could theoretically be even more informative than this, but I didn't want to make a large change.) The mail is still filtered into 'bogus' group. See simple patch below. -Karl Index: ChangeLog =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/gnus/ChangeLog,v retrieving revision 1.474 diff -u -r1.474 ChangeLog --- ChangeLog 19 Jul 2006 01:06:00 -0000 1.474 +++ ChangeLog 19 Jul 2006 01:51:44 -0000 @@ -1,3 +1,9 @@ +2006-07-18 Karl Fogel + + * nnmail.el (nnmail-article-group): If splitting raises an error, give + some information about the error when saying that the `bogus' mail + group will be used. + 2006-07-18 Andreas Seltenreich [ Backported bug fixes from No Gnus. ] Index: nnmail.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/gnus/nnmail.el,v retrieving revision 1.33 diff -u -r1.33 nnmail.el --- nnmail.el 9 Mar 2006 07:11:51 -0000 1.33 +++ nnmail.el 19 Jul 2006 01:51:45 -0000 @@ -1131,7 +1131,7 @@ (if (and (symbolp nnmail-split-methods) (fboundp nnmail-split-methods)) (let ((split - (condition-case nil + (condition-case error-info ;; `nnmail-split-methods' is a function, so we ;; just call this function here and use the ;; result. @@ -1139,7 +1139,7 @@ '("bogus")) (error (nnheader-message - 5 "Error in `nnmail-split-methods'; using `bogus' mail group") + 5 "Error in `nnmail-split-methods'; using `bogus' mail group: %S" error-info) (sit-for 1) '("bogus"))))) (setq split (mm-delete-duplicates split))