unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Magnus Henoch <mange@freemail.hu>
Subject: Re: url-http.el: error for redirected proxy connections
Date: Fri, 08 Dec 2006 01:46:40 +0100	[thread overview]
Message-ID: <87d56vp633.fsf@freemail.hu> (raw)
In-Reply-To: m3ejrbvkb6.fsf@P131831.SAP.Corp

Klaus Straubinger <KSNetz@UseNet.ArcorNews.DE> writes:

> The change
>
> |	* url-http.el (url-http): Make proxy-object buffer-local, to
> |	handle proxied asynchronous connections correctly.
>
> introduced a problem when the URL package tries to fetch a redirected
> URL trough a proxy connection. The function url-http-create-request has
> not the correct value of the variable proxy-object to extract the host
> name in this case, resulting in an error message.
>
> Simply leaving out the line
>
> 	(make-local-variable 'proxy-object)
>
> in function url-http did solve the problem for me.

That line was introduced because of my ignorance of the unfruitful
interactions of let bindings and buffer-local variables...

> The above mentioned correction introduced this line; its purpose had
> not been clear to me because proxy-object is only used dynamically
> and does not belong to a buffer, as far as I can see.

"Not clear" is indeed an accurate description.  I have now simplified
the code (in particular url-http-create-request), and it seems that
proxies and target URLs are now passed along properly.

Magnus

      reply	other threads:[~2006-12-08  0:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-07 14:42 url-http.el: error for redirected proxy connections Klaus Straubinger
2006-12-08  0:46 ` Magnus Henoch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d56vp633.fsf@freemail.hu \
    --to=mange@freemail.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).