From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Please install: Some improvements to doc-view.el Date: Tue, 02 Oct 2007 16:42:07 +0200 Message-ID: <87d4vxk280.fsf@baldur.tsdh.de> References: <87bqbhkhc6.fsf@baldur.tsdh.de> <58152.128.165.0.81.1191330286.squirrel@webmail.lanl.gov> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1191336206 16763 80.91.229.12 (2 Oct 2007 14:43:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 2 Oct 2007 14:43:26 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 02 16:43:23 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Iciy3-0007nA-9N for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2007 16:43:23 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Icixz-0002lZ-6P for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2007 10:43:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Iciwv-0002Cu-UE for emacs-devel@gnu.org; Tue, 02 Oct 2007 10:42:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Iciwu-0002Bx-WC for emacs-devel@gnu.org; Tue, 02 Oct 2007 10:42:13 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iciwu-0002Bp-Rf for emacs-devel@gnu.org; Tue, 02 Oct 2007 10:42:12 -0400 Original-Received: from out1.smtp.messagingengine.com ([66.111.4.25]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Iciwu-0008Mj-DN for emacs-devel@gnu.org; Tue, 02 Oct 2007 10:42:12 -0400 Original-Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id B26AB2F0B9 for ; Tue, 2 Oct 2007 10:42:10 -0400 (EDT) Original-Received: from heartbeat2.messagingengine.com ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 02 Oct 2007 10:42:10 -0400 X-Sasl-enc: ZsirzaLXyUy7jhAQpRX/cCVdlkVzaW48CILefPktyBUN 1191336130 Original-Received: from baldur.tsdh.de (dslb-084-063-032-134.pools.arcor-ip.net [84.63.32.134]) by mail.messagingengine.com (Postfix) with ESMTP id C82422205B for ; Tue, 2 Oct 2007 10:42:09 -0400 (EDT) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwEAIAAACI8LKTAAAACXBIWXMAAAsSAAALEgHS3X78 AAAACXZwQWcAAAAwAAAAMADO7oxXAAABRUlEQVRo3u2asQ1CMQxEPRjzMAEtFRITMAAbsARjILEK Be3Pl5Oc7Qtc4wZE4pdzHNvY8fC4vk+yLWtCIEACJEACJEACJEACJAsBdH7dnveLAG3g2Efz/fT3 8JlfNX7L4BhqbwBAnApCHaTlLFMFaN4LQwUX8z0CA4QC4fl+FdZeHw2llNatNJ/1IlB2A0IpqDff ea781rpjAT6oIB5AveAWAxSNKecIwwHVYsImfkNtIjqIUHvrXcWw58MZXDO/abVOsgWs6yXNhoYO ECemKl1LQaPFqgCFA8I2rvIfB90NM1QFP198jr2Yy6YaY4/9zLaGxj6aiwlQaPgU30G1/cAFFLTf ZvWkZ9Q0ImKUYJnNcOZiODXNM9tUQFXuLQAos0O4pIL+Ac3U/4M8M6w4ZP51KUqNuPaFx+HoXKZS Q4AESIAq7QehBVaRG6uhLAAAACZ6VFh0Q29tbWVudAAAeNpzLkpNLElNUSjPLMlQCMlIVXD39A0A AFLnByOQy2VwAAAAGnpUWHRqcGVnOmNvbG9yc3BhY2UAAHjaMwIAADMAM4k4IzUAAAAmelRYdGpw ZWc6c2FtcGxpbmctZmFjdG9yAAB42jOqMNIxrDAEYQARgwLpPZcvTwAAAABJRU5ErkJggg== Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: <58152.128.165.0.81.1191330286.squirrel@webmail.lanl.gov> (Davis Herring's message of "Tue, 2 Oct 2007 06:04:46 -0700 (PDT)") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-Detected-Kernel: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80130 Archived-At: "Davis Herring" writes: Hi Davis, >> 2. I added a simple around advice to `view-file' that asks to use >> `doc-view' instead of `view-file' if file is a pdf, ps or dvi file. >> This enables users to use the normal `v' command in dired to open >> document files. > > We would prefer this implemented without advice -- perhaps just by > rebinding v in Dired to a new, simple function > `view-or-doc-view-file', If I rebind this key in doc-view.el then the documentation has to be extended to tell the user that (require 'doc-view) re-binds it. I could change that in dired, too, but there may be users that want to use dired but not doc-view. Maybe the right thing to do is to add an autoload cookie for doc-view and change `dired-view-file' to recognize pdf, ps and dvi files. What do you think? >> The patch is a bit large because the current version was indented >> with spaces, this one uses both spaces and tabs (width 8) as it's the >> default for emacs. > > That makes your patch quite hard to read, and causes CVS conflicts > with everyone who has unchecked-in changes to the file. There's > nothing wrong, I don't think, with fixing the indentation on lines > that you change, but otherwise it's best to leave it alone. Oh, too bad. But now I think I cannot revert the whitespace changes... > (This is why I'm not sure whether your patch makes the set of > doc-viewable file types a user option.) No, that's no user option. For all doc-view supported file-types (pdf, ps and dvi) the user will be queried to open the file with doc-view instead of view-file. Bye, Tassilo