unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* New custom faces for rmail.el
@ 2008-02-11 21:55 Bastien Guerry
  2008-02-12  3:51 ` Richard Stallman
  0 siblings, 1 reply; 14+ messages in thread
From: Bastien Guerry @ 2008-02-11 21:55 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

For now rmail.el uses font-lock-* faces to highlight header fields like
From: or To:.  The patch below defines new faces for the Subject: Date:
From: and To: header fields.

I'd like to commit this change.  Comment?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rmail.el.patch --]
[-- Type: text/x-diff, Size: 3312 bytes --]

--- rmail.el.~1.448.~	2008-02-10 21:13:03.000000000 +0000
+++ rmail.el	2008-02-11 21:08:25.000000000 +0000
@@ -345,6 +345,58 @@
 		 face)
   :group 'rmail-headers)
 
+(defface rmail-subject
+  '((t (:inherit font-lock-comment-face)))
+  "Face to use for highlighting the \"Subject:\" header field."
+  :group 'rmail-headers
+  :version "22.1")
+
+(defcustom rmail-subject-face 'rmail-subject "\
+*Face use be Rmail for highlighting the \"Subject:\" header field."
+  :type '(choice (const :tag "Default" nil)
+		 face)
+  :group 'rmail-headers)
+
+(defface rmail-date
+  '((t (:inherit font-lock-string-face)))
+  "Face to use for highlighting the \"Date:\" header field."
+  :group 'rmail-headers
+  :version "22.1")
+
+(defcustom rmail-date-face 'rmail-date "\
+*Face use be Rmail for highlighting the \"Date:\" header field."
+  :type '(choice (const :tag "Default" nil)
+		 face)
+  :group 'rmail-headers)
+
+(defface rmail-from
+  '((t (:inherit font-lock-function-name-face)))
+  "Face to use for highlighting the \"From:\" header field.
+Also used for this fields: Sender and Resent-From."
+  :group 'rmail-headers
+  :version "22.1")
+
+(defcustom rmail-from-face 'rmail-from "\
+*Face use be Rmail for highlighting the \"From:\" header field.
+Also used for this fields: Sender and Resent-From."
+  :type '(choice (const :tag "Default" nil)
+		 face)
+  :group 'rmail-headers)
+
+(defface rmail-to
+  '((t (:inherit font-lock-keyword-face)))
+  "Face to use for highlighting the \"To:\" header field.
+Also used for this fields: Apparently-To, Cc and Newsgroups."
+  :group 'rmail-headers
+  :version "22.1")
+
+(defcustom rmail-to-face 'rmail-to "\
+*Face use be Rmail for highlighting the \"To:\" header field.
+Also used for this fields: Apparently-To, Cc and Newsgroups."
+  :type '(choice (const :tag "Default" nil)
+		 face)
+  :group 'rmail-headers)
+
 ;;;###autoload
 (defcustom rmail-delete-after-output nil "\
 *Non-nil means automatically delete a message that is copied to a file."
@@ -705,12 +757,12 @@
 	   (cite-prefix "a-z")
 	   (cite-suffix (concat cite-prefix "0-9_.@-`'\"")))
       (list '("^\\(From\\|Sender\\|Resent-From\\):"
-	      . font-lock-function-name-face)
+	      . rmail-from-face)
 	    '("^Reply-To:.*$" . font-lock-function-name-face)
-	    '("^Subject:" . font-lock-comment-face)
+	    '("^Subject:" . rmail-subject-face)
 	    '("^X-Spam-Status:" . font-lock-keyword-face)
 	    '("^\\(To\\|Apparently-To\\|Cc\\|Newsgroups\\):"
-	      . font-lock-keyword-face)
+	      . rmail-to-face)
 	    ;; Use MATCH-ANCHORED to effectively anchor the regexp left side.
 	    `(,cite-chars
 	      (,(concat "\\=[ \t]*"
@@ -720,9 +772,10 @@
 	       (beginning-of-line) (end-of-line)
 	       (1 font-lock-comment-delimiter-face nil t)
 	       (5 font-lock-comment-face nil t)))
-	    '("^\\(X-[a-z0-9-]+\\|In-reply-to\\|Date\\):.*\\(\n[ \t]+.*\\)*$"
-	      . font-lock-string-face))))
-  "Additional expressions to highlight in Rmail mode.")
+	    '("^\\(X-[a-z0-9-]+\\|In-reply-to\\):.*\\(\n[ \t]+.*\\)*$"
+	      . font-lock-string-face)
+	    '("^Date:.*\\(\n[ \t]+.*\\)*$" . rmail-date-face))))
+    "Additional expressions to highlight in Rmail mode.")
 
 ;; Perform BODY in the summary buffer
 ;; in such a way that its cursor is properly updated in its own window.

[-- Attachment #3: Type: text/plain, Size: 13 bytes --]


-- 
Bastien

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: New custom faces for rmail.el
  2008-02-11 21:55 New custom faces for rmail.el Bastien Guerry
@ 2008-02-12  3:51 ` Richard Stallman
  2008-02-12  4:15   ` Bastien
  0 siblings, 1 reply; 14+ messages in thread
From: Richard Stallman @ 2008-02-12  3:51 UTC (permalink / raw)
  To: Bastien Guerry; +Cc: emacs-devel

You seem to be operating on the idea that we should make a separate face
for every use.  I don't think that is a good idea.

I agree that it is more general, and in a certain sense it is cleaner.
But I am concerned that it is also a lot of bloat, and I am not sure
we can afford that.

Absent the intention to make a separate face for every use,
why should we install separate faces for rmail?




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: New custom faces for rmail.el
  2008-02-12  3:51 ` Richard Stallman
@ 2008-02-12  4:15   ` Bastien
  2008-02-12  5:46     ` Glenn Morris
  0 siblings, 1 reply; 14+ messages in thread
From: Bastien @ 2008-02-12  4:15 UTC (permalink / raw)
  To: rms; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

Richard Stallman <rms@gnu.org> writes:

> You seem to be operating on the idea that we should make a separate face
> for every use.  I don't think that is a good idea.
>
> I agree that it is more general, and in a certain sense it is cleaner.
> But I am concerned that it is also a lot of bloat, and I am not sure
> we can afford that.
>
> Absent the intention to make a separate face for every use,
> why should we install separate faces for rmail?

My primary concern was to avoid having different faces for the header
names, which I don't like.  But I didn't want to make a change that
would change the default display of an email, so I added as many new
faces as required for the default display to stay the same.

Personally, I will be fine with just one `rmail-header-name' face.  
This is the way `message-mode' does it, there is just one face for 
every header name: `message-header-name'.

The patch below do this.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rmail.el.patch --]
[-- Type: text/x-diff, Size: 1827 bytes --]

--- rmail.el.~1.448.~	2008-02-10 21:13:03.000000000 +0000
+++ rmail.el	2008-02-12 04:05:42.000000000 +0000
@@ -345,6 +345,19 @@
 		 face)
   :group 'rmail-headers)
 
+(defface rmail-header-name-face
+  '((t (:inherit font-lock-function-name-face)))
+  "Face to use for highlighting the header names."
+  :group 'rmail-headers
+  :version "22.1")
+
+;;;###autoload
+(defcustom rmail-header-name 'rmail-header-name-face "\
+*Face to use for highlighting the header names."
+  :type '(choice (const :tag "Default" nil)
+		 face)
+  :group 'rmail-headers)
+
 ;;;###autoload
 (defcustom rmail-delete-after-output nil "\
 *Non-nil means automatically delete a message that is copied to a file."
@@ -705,12 +718,12 @@
 	   (cite-prefix "a-z")
 	   (cite-suffix (concat cite-prefix "0-9_.@-`'\"")))
       (list '("^\\(From\\|Sender\\|Resent-From\\):"
-	      . font-lock-function-name-face)
-	    '("^Reply-To:.*$" . font-lock-function-name-face)
-	    '("^Subject:" . font-lock-comment-face)
-	    '("^X-Spam-Status:" . font-lock-keyword-face)
+	      . rmail-header-name-face)
+	    '("^Reply-To:.*$" . rmail-header-name-face)
+	    '("^Subject:" . rmail-header-name-face)
+	    '("^X-Spam-Status:" . rmail-header-name-face)
 	    '("^\\(To\\|Apparently-To\\|Cc\\|Newsgroups\\):"
-	      . font-lock-keyword-face)
+	      . rmail-header-name-face))
 	    ;; Use MATCH-ANCHORED to effectively anchor the regexp left side.
 	    `(,cite-chars
 	      (,(concat "\\=[ \t]*"
@@ -721,7 +734,7 @@
 	       (1 font-lock-comment-delimiter-face nil t)
 	       (5 font-lock-comment-face nil t)))
 	    '("^\\(X-[a-z0-9-]+\\|In-reply-to\\|Date\\):.*\\(\n[ \t]+.*\\)*$"
-	      . font-lock-string-face))))
+	      . rmail-header-name-face))))))
   "Additional expressions to highlight in Rmail mode.")
 
 ;; Perform BODY in the summary buffer

[-- Attachment #3: Type: text/plain, Size: 13 bytes --]


-- 
Bastien

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: New custom faces for rmail.el
  2008-02-12  4:15   ` Bastien
@ 2008-02-12  5:46     ` Glenn Morris
  2008-02-12  6:49       ` Bastien Guerry
  0 siblings, 1 reply; 14+ messages in thread
From: Glenn Morris @ 2008-02-12  5:46 UTC (permalink / raw)
  To: Bastien; +Cc: rms, emacs-devel

Bastien wrote:

> +(defface rmail-header-name-face
> +  '((t (:inherit font-lock-function-name-face)))
> +  "Face to use for highlighting the header names."
> +  :group 'rmail-headers
> +  :version "22.1")

"23.1"

Face names should not end in -face.

> +(defcustom rmail-header-name 'rmail-header-name-face "\
> +*Face to use for highlighting the header names."
> +  :type '(choice (const :tag "Default" nil)
> +		 face)
> +  :group 'rmail-headers)

There's no need for a variable, just the face is enough.




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: New custom faces for rmail.el
  2008-02-12  5:46     ` Glenn Morris
@ 2008-02-12  6:49       ` Bastien Guerry
  2008-02-12  6:53         ` Miles Bader
  2008-02-12 13:21         ` Stefan Monnier
  0 siblings, 2 replies; 14+ messages in thread
From: Bastien Guerry @ 2008-02-12  6:49 UTC (permalink / raw)
  To: Glenn Morris; +Cc: rms, emacs-devel

Glenn Morris <rgm@gnu.org> writes:

> Bastien wrote:
>
>> +(defface rmail-header-name-face
>> +  '((t (:inherit font-lock-function-name-face)))
>> +  "Face to use for highlighting the header names."
>> +  :group 'rmail-headers
>> +  :version "22.1")
>
> "23.1"
>
> Face names should not end in -face.

Yes, I know, typo: my intent was to name the face `rmail-header-name'
and to name `rmail-header-name-face' the variable that is set to it.

>> +(defcustom rmail-header-name 'rmail-header-name-face "\
>> +*Face to use for highlighting the header names."
>> +  :type '(choice (const :tag "Default" nil)
>> +		 face)
>> +  :group 'rmail-headers)
>
> There's no need for a variable, just the face is enough.

Okay.  

But AFAICS there are many places where we have both mistakes: 1) have a
face *and* a variable, and 2) name them with the *-face suffix.

See for example, font-lock.el: 

,----
| (defvar font-lock-comment-delimiter-face 'font-lock-comment-delimiter-face
|   "Face name to use for comment delimiters.")
| 
| (defvar font-lock-string-face		'font-lock-string-face
|   "Face name to use for strings.")
| 
| (defvar font-lock-doc-face		'font-lock-doc-face
|   "Face name to use for documentation.")
`----

I think this is very confusing for those who think font-lock.el might be
a good place to learn about faces.  Shall I fix this?

I will fix it in rmail.el when rms tells me when people agree on having
(or not) one single face for all rmail headers.

-- 
Bastien




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: New custom faces for rmail.el
  2008-02-12  6:49       ` Bastien Guerry
@ 2008-02-12  6:53         ` Miles Bader
  2008-02-12  7:26           ` Bastien Guerry
  2008-02-12 13:21         ` Stefan Monnier
  1 sibling, 1 reply; 14+ messages in thread
From: Miles Bader @ 2008-02-12  6:53 UTC (permalink / raw)
  To: Bastien Guerry; +Cc: Glenn Morris, rms, emacs-devel

Bastien Guerry <bzg@altern.org> writes:
> But AFAICS there are many places where we have both mistakes: 1) have a
> face *and* a variable, and 2) name them with the *-face suffix.

font-lock-* is a special case (for historical, not sanity) reasons.

Maybe it too should be changed, but that's a separate issue.

-Miles

-- 
Mayonnaise, n. One of the sauces that serve the French in place of a state
religion.




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: New custom faces for rmail.el
  2008-02-12  6:53         ` Miles Bader
@ 2008-02-12  7:26           ` Bastien Guerry
  2008-02-13  2:00             ` Xavier Maillard
  2008-02-13 22:05             ` New custom faces for rmail.el Bastien Guerry
  0 siblings, 2 replies; 14+ messages in thread
From: Bastien Guerry @ 2008-02-12  7:26 UTC (permalink / raw)
  To: Miles Bader; +Cc: Glenn Morris, rms, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Miles Bader <miles.bader@necel.com> writes:

> Bastien Guerry <bzg@altern.org> writes:
>> But AFAICS there are many places where we have both mistakes: 1) have a
>> face *and* a variable, and 2) name them with the *-face suffix.
>
> font-lock-* is a special case (for historical, not sanity) reasons.
>
> Maybe it too should be changed, but that's a separate issue.

Okay then.

The patch below gets rid of `rmail-highlight-face' and use a single
`rmail-header-name' face.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rmail.el.patch --]
[-- Type: text/x-diff, Size: 2364 bytes --]

--- rmail.el.~1.450.~	2008-02-10 21:13:03.000000000 +0000
+++ rmail.el	2008-02-12 07:20:48.000000000 +0000
@@ -327,8 +327,7 @@
 ;;;###autoload
 (defcustom rmail-highlighted-headers "^From:\\|^Subject:" "\
 *Regexp to match Header fields that Rmail should normally highlight.
-A value of nil means don't highlight.
-See also `rmail-highlight-face'."
+A value of nil means don't highlight."
   :type 'regexp
   :group 'rmail-headers)
 
@@ -338,12 +337,11 @@
   :group 'rmail-headers
   :version "22.1")
 
-;;;###autoload
-(defcustom rmail-highlight-face 'rmail-highlight "\
-*Face used by Rmail for highlighting headers."
-  :type '(choice (const :tag "Default" nil)
-		 face)
-  :group 'rmail-headers)
+(defface rmail-header-name
+  '((t (:inherit font-lock-function-name-face)))
+  "Face to use for highlighting the header names."
+  :group 'rmail-headers
+  :version "23.1")
 
 ;;;###autoload
 (defcustom rmail-delete-after-output nil "\
@@ -705,12 +703,12 @@
 	   (cite-prefix "a-z")
 	   (cite-suffix (concat cite-prefix "0-9_.@-`'\"")))
       (list '("^\\(From\\|Sender\\|Resent-From\\):"
-	      . font-lock-function-name-face)
-	    '("^Reply-To:.*$" . font-lock-function-name-face)
-	    '("^Subject:" . font-lock-comment-face)
-	    '("^X-Spam-Status:" . font-lock-keyword-face)
+	      . 'rmail-header-name)
+	    '("^Reply-To:.*$" . 'rmail-header-name)
+	    '("^Subject:" . 'rmail-header-name)
+	    '("^X-Spam-Status:" . 'rmail-header-name)
 	    '("^\\(To\\|Apparently-To\\|Cc\\|Newsgroups\\):"
-	      . font-lock-keyword-face)
+	      . 'rmail-header-name)
 	    ;; Use MATCH-ANCHORED to effectively anchor the regexp left side.
 	    `(,cite-chars
 	      (,(concat "\\=[ \t]*"
@@ -721,7 +719,7 @@
 	       (1 font-lock-comment-delimiter-face nil t)
 	       (5 font-lock-comment-face nil t)))
 	    '("^\\(X-[a-z0-9-]+\\|In-reply-to\\|Date\\):.*\\(\n[ \t]+.*\\)*$"
-	      . font-lock-string-face))))
+	      . 'rmail-header-name))))
   "Additional expressions to highlight in Rmail mode.")
 
 ;; Perform BODY in the summary buffer
@@ -2975,7 +2973,7 @@
 		(inhibit-read-only t)
 		;; Highlight with boldface if that is available.
 		;; Otherwise use the `highlight' face.
-		(face (or rmail-highlight-face
+		(face (or 'rmail-highlight
 			  (if (face-differs-from-default-p 'bold)
 			      'bold 'highlight)))
 		;; List of overlays to reuse.

[-- Attachment #3: Type: text/plain, Size: 13 bytes --]


-- 
Bastien

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: New custom faces for rmail.el
  2008-02-12  6:49       ` Bastien Guerry
  2008-02-12  6:53         ` Miles Bader
@ 2008-02-12 13:21         ` Stefan Monnier
  2008-02-12 13:24           ` Bastien Guerry
  1 sibling, 1 reply; 14+ messages in thread
From: Stefan Monnier @ 2008-02-12 13:21 UTC (permalink / raw)
  To: Bastien Guerry; +Cc: Glenn Morris, rms, emacs-devel

> But AFAICS there are many places where we have both mistakes: 1) have a
> face *and* a variable, and 2) name them with the *-face suffix.

Having a variable is not necessarily an error.  In the case of
font-lock, this was done originally so as to allow font-lock faces to be
changed on a per-buffer basis (by making the variable buffer-local and
making it point to different faces).  Until Miles installs his changes
that add the ability to change faces on a per-buffer basis, this is
still useful.

As for the -face name, this is historical and should probably be
changed, tho when we changed the others we specifically avoided changing
the font-lock ones.


        Stefan




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: New custom faces for rmail.el
  2008-02-12 13:21         ` Stefan Monnier
@ 2008-02-12 13:24           ` Bastien Guerry
  0 siblings, 0 replies; 14+ messages in thread
From: Bastien Guerry @ 2008-02-12 13:24 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> But AFAICS there are many places where we have both mistakes: 1) have a
>> face *and* a variable, and 2) name them with the *-face suffix.
>
> Having a variable is not necessarily an error.  In the case of
> font-lock, this was done originally so as to allow font-lock faces to be
> changed on a per-buffer basis (by making the variable buffer-local and
> making it point to different faces).  Until Miles installs his changes
> that add the ability to change faces on a per-buffer basis, this is
> still useful.
>
> As for the -face name, this is historical and should probably be
> changed, tho when we changed the others we specifically avoided changing
> the font-lock ones.

Thanks for the clarification.

-- 
Bastien




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: New custom faces for rmail.el
  2008-02-12  7:26           ` Bastien Guerry
@ 2008-02-13  2:00             ` Xavier Maillard
  2008-02-13 10:15               ` Andreas Schwab
  2008-02-13 21:15               ` OT: A non-text attachment was scrubbed... (was: New custom faces for rmail.el) Reiner Steib
  2008-02-13 22:05             ` New custom faces for rmail.el Bastien Guerry
  1 sibling, 2 replies; 14+ messages in thread
From: Xavier Maillard @ 2008-02-13  2:00 UTC (permalink / raw)
  To: Bastien Guerry; +Cc: rgm, emacs-devel, rms, miles

Hi Bastien and all,

I often see such part when reading GNU mailing list. The problem
is that I never ever could access the given link. When I follow
the link as found in the Url part, I am put on the archive site
of the mailing list. How can I "view" such attachement ?

   -------------- next part --------------
   A non-text attachment was scrubbed...
   Name: rmail.el.patch
   Type: text/x-diff
   Size: 2364 bytes
   Desc: not available
   Url : http://lists.gnu.org/pipermail/emacs-devel/attachments/20080212/5a4ff8ff/rmail.el.bin
   -------------- next part --------------

Thank you.

	Xavier
-- 
http://www.gnu.org
http://www.april.org
http://www.lolica.org




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: New custom faces for rmail.el
  2008-02-13  2:00             ` Xavier Maillard
@ 2008-02-13 10:15               ` Andreas Schwab
  2008-02-14  2:00                 ` Xavier Maillard
  2008-02-13 21:15               ` OT: A non-text attachment was scrubbed... (was: New custom faces for rmail.el) Reiner Steib
  1 sibling, 1 reply; 14+ messages in thread
From: Andreas Schwab @ 2008-02-13 10:15 UTC (permalink / raw)
  To: Xavier Maillard; +Cc: miles, Bastien Guerry, emacs-devel, rms, rgm

Xavier Maillard <xma@gnu.org> writes:

> I often see such part when reading GNU mailing list. The problem
> is that I never ever could access the given link. When I follow
> the link as found in the Url part, I am put on the archive site
> of the mailing list. How can I "view" such attachement ?
>
>    -------------- next part --------------
>    A non-text attachment was scrubbed...
>    Name: rmail.el.patch
>    Type: text/x-diff
>    Size: 2364 bytes
>    Desc: not available
>    Url : http://lists.gnu.org/pipermail/emacs-devel/attachments/20080212/5a4ff8ff/rmail.el.bin
>    -------------- next part --------------

Where do you see that?  Looking at
<http://lists.gnu.org/archive/html/emacs-devel/2008-02/msg00939.html> I
see the complete text of the mail, without any such link.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."




^ permalink raw reply	[flat|nested] 14+ messages in thread

* OT: A non-text attachment was scrubbed... (was: New custom faces for rmail.el)
  2008-02-13  2:00             ` Xavier Maillard
  2008-02-13 10:15               ` Andreas Schwab
@ 2008-02-13 21:15               ` Reiner Steib
  1 sibling, 0 replies; 14+ messages in thread
From: Reiner Steib @ 2008-02-13 21:15 UTC (permalink / raw)
  To: emacs-devel

On Wed, Feb 13 2008, Xavier Maillard wrote:

> How can I "view" such attachement ?
>
>    -------------- next part --------------
>    A non-text attachment was scrubbed...
>    Name: rmail.el.patch
>    Type: text/x-diff

<http://www.google.com/search?q=%22A+non-text+attachment+was+scrubbed%22>

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/





^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: New custom faces for rmail.el
  2008-02-12  7:26           ` Bastien Guerry
  2008-02-13  2:00             ` Xavier Maillard
@ 2008-02-13 22:05             ` Bastien Guerry
  1 sibling, 0 replies; 14+ messages in thread
From: Bastien Guerry @ 2008-02-13 22:05 UTC (permalink / raw)
  To: Miles Bader; +Cc: Glenn Morris, rms, emacs-devel

Bastien Guerry <bzg@altern.org> writes:

> The patch below gets rid of `rmail-highlight-face' and use a single
> `rmail-header-name' face.

I have applied this patch.

I still think it would be less confusing to be able to customize several
faces.  At least it would allow to display the headers the same way than
before, as the default values for the new faces would inherit the actual
hardwired faces.

Let me know what you think.

-- 
Bastien




^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: New custom faces for rmail.el
  2008-02-13 10:15               ` Andreas Schwab
@ 2008-02-14  2:00                 ` Xavier Maillard
  0 siblings, 0 replies; 14+ messages in thread
From: Xavier Maillard @ 2008-02-14  2:00 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: bzg, emacs-devel, rms, rgm, miles


   Xavier Maillard <xma@gnu.org> writes:

   > I often see such part when reading GNU mailing list. The problem
   > is that I never ever could access the given link. When I follow
   > the link as found in the Url part, I am put on the archive site
   > of the mailing list. How can I "view" such attachement ?
   >
   >    -------------- next part --------------
   >    A non-text attachment was scrubbed...
   >    Name: rmail.el.patch
   >    Type: text/x-diff
   >    Size: 2364 bytes
   >    Desc: not available
   >    Url : http://lists.gnu.org/pipermail/emacs-devel/attachments/20080212/5a4ff8ff/rmail.el.bin
   >    -------------- next part --------------

   Where do you see that?

Into my rmail message buffer.

	Xavier
-- 
http://www.gnu.org
http://www.april.org
http://www.lolica.org




^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2008-02-14  2:00 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-11 21:55 New custom faces for rmail.el Bastien Guerry
2008-02-12  3:51 ` Richard Stallman
2008-02-12  4:15   ` Bastien
2008-02-12  5:46     ` Glenn Morris
2008-02-12  6:49       ` Bastien Guerry
2008-02-12  6:53         ` Miles Bader
2008-02-12  7:26           ` Bastien Guerry
2008-02-13  2:00             ` Xavier Maillard
2008-02-13 10:15               ` Andreas Schwab
2008-02-14  2:00                 ` Xavier Maillard
2008-02-13 21:15               ` OT: A non-text attachment was scrubbed... (was: New custom faces for rmail.el) Reiner Steib
2008-02-13 22:05             ` New custom faces for rmail.el Bastien Guerry
2008-02-12 13:21         ` Stefan Monnier
2008-02-12 13:24           ` Bastien Guerry

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).