unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Berman <Stephen.Berman@gmx.net>
To: emacs-devel@gnu.org
Subject: Re: 23.0.60; Deja vu font breaks mouse-face highlighting in Gnus
Date: Sun, 17 Feb 2008 14:07:55 +0100	[thread overview]
Message-ID: <87d4qvpw7o.fsf@escher.local.home> (raw)
In-Reply-To: yoij4pc8bejp.fsf@remote2.student.chalmers.se

On Sun, 17 Feb 2008 01:40:58 +0100 bojohan+news@dd.chalmers.se (Johan Bockgård) wrote:

> Stephen Berman <Stephen.Berman@gmx.net> writes:
>
>> Other Dejavu fonts also show the gap in highlighting, but the range of
>> susceptible strings seems to be less than with Dejavu Sans Mono.  I
>> have tried using a number of other fonts but so far haven't found any
>> others that show the display problem.
>
> The problem happens for characters that stick out of their box.  It is
> most noticeable with an italic font.
>
> E.g. try
>
>     (font-lock-mode 0)
>     (insert (propertize "XXXXXX" 'face 'italic 'mouse-face 'highlight))

I had also tried an italic Dejavu and it showed the problem but, as I
said, not with as many strings; here's a case in point:

(progn (font-lock-mode 0)
  (insert (propertize "Re: 23.0.60" 'mouse-face 'highlight))
  (insert (propertize "Re: 23.0.60" 'face 'italic 'mouse-face 'highlight)))

I see a gap in mouse-face highlighting when the cursor is over the
unitalicized "R" and "2" but not when it is over the italicized ones.
Do you see that too?  This seems contrary to you characterization of the
triggering conditions, i.e. characters that stick out of their box, but
I do not know the properties of the font nor understand the code you
pointed to, so maybe it is no contradiction.

> The responsible code is this part in `draw_glyphs':
>
>    /* If there are any glyphs with lbearing < 0 or rbearing > width in
>       the row, redraw some glyphs in front or following the glyph
>       strings built above.  */
>   if (head && !overlaps && row->contains_overlapping_glyphs_p)
>      {
>        ...

How did you figure this out?  Do you just know the code well and realize
that draw_glyphs was involved, or did you arrive there by using gdb?  If
the latter, could you tell me how you did it?  That might help me make
more useful bug reports and perhaps even suggest bug fixes.

Steve Berman





  reply	other threads:[~2008-02-17 13:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-11 15:47 23.0.60; broken mouse-face highlighting in Gnus Stephen Berman
2008-02-16 23:56 ` 23.0.60; Deja vu font breaks " Stephen Berman
2008-02-17  0:40   ` Johan Bockgård
2008-02-17 13:07     ` Stephen Berman [this message]
2008-02-17 20:25       ` Johan Bockgård
2008-02-17 20:47         ` Bad drawing of xft fonts overlapping box cursor Johan Bockgård
2008-02-18  0:36           ` Stephen Berman
2008-02-18  0:58             ` Jason Rumney
2008-02-18  0:36         ` 23.0.60; Deja vu font breaks mouse-face highlighting in Gnus Stephen Berman
2008-02-18  1:12           ` Johan Bockgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d4qvpw7o.fsf@escher.local.home \
    --to=stephen.berman@gmx.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).