From: Chong Yidong <cyd@stupidchicken.com>
To: Alan Mackenzie <acm@muc.de>
Cc: Glenn Morris <rgm@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org
Subject: Re: bug#347: C mode asks twice about local variables
Date: Sat, 26 Jul 2008 11:05:25 -0400 [thread overview]
Message-ID: <87d4l0wuru.fsf@stupidchicken.com> (raw)
In-Reply-To: <20080726104434.GA3800@muc.de> (Alan Mackenzie's message of "Sat, 26 Jul 2008 10:44:34 +0000")
Alan Mackenzie <acm@muc.de> writes:
>> 2008-06-15 Alan Mackenzie <acm@muc.de>
>
>> * progmodes/cc-mode.el (c-before-hack-hook): New function
>> (Top Level): Install c-before-hack-hook on
>> before-hack-local-variables-hook, rather than
>> c-postprocess-file-styles on hack-local-variables-hook.
>
>> * files.el (hack-local-variables-alist): New variable.
>> (before-hack-local-variables-hook): New hook.
>> (hack-local-variables-filter): Refactored version of
>> Hack-local-variables-apply.
>> (hack-local-variables): Call `before-hack-local-variables-hook'.
Looks OK to me, except for two things:
- hack-local-variables-alist, before-hack-local-variables-hook, and
c-before-hack-hook need to be marked as risky local vars.
- how bout renaming hack-local-variables-alist to
file-local-variables-alist (which is a better description), making it
buffer-local, and setting its buffer value instead of let-binding it?
Then it would provide a lasting record what vars were set in this
buffer using the hack-local-variables mechanism, which might be a
useful thing to have.
If no one has any other objections in a couple of days, I'd go ahead and
check it in. Please add a note to NEWS as well.
next prev parent reply other threads:[~2008-07-26 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <s8abi6ccjs.fsf@fencepost.gnu.org>
[not found] ` <20080601172143.GA5899@muc.de>
[not found] ` <jwvfxrvt49x.fsf-monnier+emacsbugreports@gnu.org>
[not found] ` <20080609143651.GA6098@muc.de>
[not found] ` <jwvr6b6r6ci.fsf-monnier+emacsbugreports@gnu.org>
[not found] ` <20080609190750.GC6098@muc.de>
2008-06-11 14:41 ` bug#347: C mode asks twice about local variables Stefan Monnier
2008-06-11 16:37 ` Glenn Morris
2008-06-11 17:51 ` Stefan Monnier
2008-06-15 22:04 ` Alan Mackenzie
2008-07-26 10:44 ` Alan Mackenzie
2008-07-26 15:05 ` Chong Yidong [this message]
2008-07-26 15:58 ` Chong Yidong
2008-07-28 18:11 ` Johan Bockgård
2008-07-31 1:37 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d4l0wuru.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).