unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: emacs-devel@gnu.org
Subject: Re: Finding the source of Change Log entries
Date: Thu, 11 Sep 2008 02:59:55 +0300	[thread overview]
Message-ID: <87d4jbmuwq.fsf@jurta.org> (raw)
In-Reply-To: <868wuii9t7.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 27 Aug 2008 13:37:08 -0500")

> JL> I noticed one difference comparing with the standard behavior of
> JL> next-error.  In ChangeLog files it doesn't switch to the source
> JL> buffer: after calling `next-error', point stays in the ChangeLog buffer
> JL> instead of using pop-to-buffer to switch to the source buffer.
>
> Unfortunately I think making that change would have broken
> `change-log-goto-source', so I run an extra `find-file' after
> `change-log-goto-source'.  Take a look and see if it works for you.  It
> may be more appropriate with find-file-other-window to keep the
> ChangeLog visible.

Still doesn't work.  Replacing `pop-to-buffer' with `display-buffer'
at least doesn't hide the ChangeLog buffer, but point is in the wrong
buffer: unlike occur/grep modes, point stays in the ChangeLog buffer
instead of switching to the source buffer.

> JL> Also I think it is more useful to navigate by entries instead of file names,
> JL> (i.e. using change-log-start-entry-re instead of change-log-file-names-re).
>
> I had that originally, but it's very common to have multi-file commits
> and visiting each file proved (to me) to be useful.  Remember, this is
> to visit the file referenced in the ChangeLog, not the ChangeLog entry
> itself.

I remember we already agreed to add a pair of new next-file functions
to jump the next/previous file like compilation-next-file and
compilation-previous-file.  Such commands would be useful for
all next-error aware modes like occur, grep, ChangeLog, etc.

-- 
Juri Linkov
http://www.jurta.org/emacs/




  parent reply	other threads:[~2008-09-10 23:59 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-12  9:32 Finding the source of Change Log entries martin rudalics
2008-07-12 10:00 ` Lennart Borgman (gmail)
2008-07-12 10:32   ` martin rudalics
2008-07-12 14:52 ` Chong Yidong
2008-07-13  8:33   ` martin rudalics
2008-07-13 22:14     ` Juri Linkov
2008-07-14  8:40       ` martin rudalics
2008-07-14 21:57         ` Juri Linkov
2008-07-16 17:20           ` martin rudalics
2008-08-07 10:10           ` martin rudalics
2008-07-14 13:50   ` Ted Zlatanov
2008-07-14 21:54     ` Juri Linkov
2008-07-15  6:23       ` Andrew W. Nosenko
2008-07-15  9:48         ` Juri Linkov
2008-07-15 14:56           ` Ted Zlatanov
2008-07-15 20:35             ` Juri Linkov
2008-07-16 17:20               ` martin rudalics
2008-08-05 18:43               ` Ted Zlatanov
2008-08-25 15:43                 ` Juri Linkov
2008-08-27 18:37                   ` Ted Zlatanov
2008-08-27 20:43                     ` Stefan Monnier
2008-08-27 20:57                       ` Ted Zlatanov
2008-08-28  2:03                         ` Stefan Monnier
2008-09-10 23:59                     ` Juri Linkov [this message]
2008-09-14 11:27                       ` martin rudalics
2008-07-14 14:00 ` Dan Nicolaescu
2008-07-16 17:18   ` martin rudalics
2008-07-27 21:47     ` Dan Nicolaescu
2008-07-28 18:50       ` martin rudalics
2008-07-28 21:53         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d4jbmuwq.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    --cc=tzz@lifelogs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).