unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: emacs-devel@gnu.org
Subject: Re: patch to fileio.c
Date: Fri, 14 Nov 2008 16:16:44 -0500	[thread overview]
Message-ID: <87d4gyqa83.fsf@stupidchicken.com> (raw)
In-Reply-To: <874p2adnde.fsf@cyd.mit.edu> (Chong Yidong's message of "Fri, 14 Nov 2008 16:11:09 -0500")

Chong Yidong <cyd@stupidchicken.com> writes:

>> The fd file descriptor in this case is closed by emacs_close() at line
>> 3654 and by close_file_unwind() registered at line 3233. When
>> emacs_close(fd) is reached, the unwind_protect registered function
>> should be removed. Unfortunately, in the mean time other stuff has
>> been put in the unwind_protect stack, so you can't just decrement the
>> pointer. It can be done when the handled: label is reached. Hence the
>> flag in my patch.
>
> I've checked in your patch.  Thanks.

BTW, could someone check whether this has any impact on the tar file
crash in Windows?  (Hope springs eternal :-)




  reply	other threads:[~2008-11-14 21:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-26 15:15 patch to fileio.c Fabrice Popineau
2008-11-04 17:20 ` Chong Yidong
2008-11-07  0:17   ` Fabrice Popineau
2008-11-13 15:43     ` Chong Yidong
2008-11-14 19:01       ` Eli Zaretskii
2008-11-14 21:11 ` Chong Yidong
2008-11-14 21:16   ` Chong Yidong [this message]
2008-11-14 22:28     ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d4gyqa83.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).