From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: mode-line-eol-desc needs to use assoc, not assq Date: Sat, 20 Dec 2008 02:20:04 -0500 Message-ID: <87d4fn71p7.fsf@cyd.mit.edu> References: <9aa0cfde0812192311j60e4adcao46753f828bc6a52f@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1229757617 25706 80.91.229.12 (20 Dec 2008 07:20:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 20 Dec 2008 07:20:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Ami Fischman" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 20 08:21:24 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LDw9L-0007sC-Vn for ged-emacs-devel@m.gmane.org; Sat, 20 Dec 2008 08:21:24 +0100 Original-Received: from localhost ([127.0.0.1]:36748 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LDw87-0001U1-Ai for ged-emacs-devel@m.gmane.org; Sat, 20 Dec 2008 02:20:07 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LDw83-0001T4-Fr for emacs-devel@gnu.org; Sat, 20 Dec 2008 02:20:03 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LDw81-0001Rc-Sd for emacs-devel@gnu.org; Sat, 20 Dec 2008 02:20:03 -0500 Original-Received: from [199.232.76.173] (port=34002 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LDw81-0001RV-JW for emacs-devel@gnu.org; Sat, 20 Dec 2008 02:20:01 -0500 Original-Received: from cyd.mit.edu ([18.115.2.24]:56100) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LDw81-0003Py-Dj for emacs-devel@gnu.org; Sat, 20 Dec 2008 02:20:01 -0500 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 1AB0C57E204; Sat, 20 Dec 2008 02:20:04 -0500 (EST) In-Reply-To: <9aa0cfde0812192311j60e4adcao46753f828bc6a52f@mail.gmail.com> (Ami Fischman's message of "Fri, 19 Dec 2008 23:11:31 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:107105 Archived-At: "Ami Fischman" writes: > mode-line-eol-desc uses assq to look up desc in > mode-line-eol-desc-cache, but the key used is computed by > coding-system-eol-type which returns a vector sometimes. This results > in mode-line-eol-desc-cache growing without bounds over the lifetime > of an emacs process. Changing mode-line-eol-desc to use assoc instead > of assq (so that the vectors are compared with equal and so have a > chance of returning t) fixes this. Checked in, thanks.