From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X Date: Sat, 19 Feb 2011 14:15:42 -0500 Message-ID: <87d3mnj0o1.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1298142975 4673 80.91.229.12 (19 Feb 2011 19:16:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 19 Feb 2011 19:16:15 +0000 (UTC) Cc: david+emacsformacosx@porkrind.org, Emacs-devel@gnu.org To: Ben Key Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 19 20:16:11 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PqsHq-0005X7-VZ for ged-emacs-devel@m.gmane.org; Sat, 19 Feb 2011 20:16:11 +0100 Original-Received: from localhost ([127.0.0.1]:40725 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PqsHq-0006tM-EB for ged-emacs-devel@m.gmane.org; Sat, 19 Feb 2011 14:16:10 -0500 Original-Received: from [140.186.70.92] (port=51583 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PqsHk-0006sE-K3 for Emacs-devel@gnu.org; Sat, 19 Feb 2011 14:16:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PqsHj-0002hn-P2 for Emacs-devel@gnu.org; Sat, 19 Feb 2011 14:16:04 -0500 Original-Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]:37806) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PqsHj-0002hd-Mi for Emacs-devel@gnu.org; Sat, 19 Feb 2011 14:16:03 -0500 Original-Received: from furball ([64.134.67.165]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p1JJFsuS014431 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 19 Feb 2011 14:16:00 -0500 Original-Received: by furball (Postfix, from userid 1000) id 016A616081E; Sat, 19 Feb 2011 14:15:42 -0500 (EST) In-Reply-To: (Ben Key's message of "Thu, 17 Feb 2011 22:29:35 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 130.132.50.145 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136234 Archived-At: Ben Key writes: > The first thing I noticed when I began using Emacs on Mac OS X was > that when Emacs is configured to use a bar cursor the cursor is > difficult to see because it is too narrow, even when the width of the > bar cursor is specified by using the (bar . WIDTH) syntax when setting > the value of the cursor-type variable. The following patch fixes this > problem. Thanks. I'll commit your fix to the comments for ns_draw_window_cursor shortly, but I don't think the other changes are quite right. Could you try the following patch instead? *** src/nsterm.m 2011-02-17 10:19:29 +0000 --- src/nsterm.m 2011-02-19 19:13:36 +0000 *************** *** 2264,2269 **** --- 2264,2271 ---- w->phys_cursor_width = 0; return; } + else if (cursor_type == BAR_CURSOR) + w->phys_cursor_width = width; if ((phys_cursor_glyph = get_phys_cursor_glyph (w)) == NULL) {