From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: claudio.bley@gmail.com (Claudio Bley) Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] GnuTLS support on Woe32 Date: Wed, 23 Mar 2011 21:50:59 +0100 Message-ID: <87d3lhimrw.wl%claudio.bley@gmail.com> References: <87ipvwl1nx.wl%claudio.bley@gmail.com> <83oc5ogp89.fsf@gnu.org> <87ipvuwslp.wl%claudio.bley@gmail.com> <87hbbc0zi6.wl%claudio.bley@gmail.com> <83oc5gsdwc.fsf@gnu.org> <87ei6bunxz.wl%claudio.bley@gmail.com> <83tyf6rhgn.fsf@gnu.org> <84zkoy6tah.wl%claudio.bley@gmail.com> <87hbb5a4xq.fsf@lifelogs.com> <84ipvkx1da.wl%claudio.bley@gmail.com> <87d3ls7n3b.fsf@lifelogs.com> <87vczdwjuk.wl%claudio.bley@gmail.com> <87k4fr3koi.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: dough.gmane.org 1300913622 3788 80.91.229.12 (23 Mar 2011 20:53:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 23 Mar 2011 20:53:42 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 23 21:53:38 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q2V3i-0004vi-6W for ged-emacs-devel@m.gmane.org; Wed, 23 Mar 2011 21:53:38 +0100 Original-Received: from localhost ([127.0.0.1]:38955 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q2V3h-0002ku-PE for ged-emacs-devel@m.gmane.org; Wed, 23 Mar 2011 16:53:37 -0400 Original-Received: from [140.186.70.92] (port=36795 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q2V1Q-0001Fn-2i for emacs-devel@gnu.org; Wed, 23 Mar 2011 16:51:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q2V1O-00057s-SZ for emacs-devel@gnu.org; Wed, 23 Mar 2011 16:51:15 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:48416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q2V1O-00057F-Iu for emacs-devel@gnu.org; Wed, 23 Mar 2011 16:51:14 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Q2V1N-0003E5-3i for emacs-devel@gnu.org; Wed, 23 Mar 2011 21:51:13 +0100 Original-Received: from dslb-188-102-233-076.pools.arcor-ip.net ([188.102.233.76]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 23 Mar 2011 21:51:13 +0100 Original-Received: from claudio.bley by dslb-188-102-233-076.pools.arcor-ip.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 23 Mar 2011 21:51:13 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 38 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: dslb-188-102-233-076.pools.arcor-ip.net In-Reply-To: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/23.1 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Mail-Copies-To: never X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137614 Archived-At: At Tue, 22 Mar 2011 01:40:06 -0400, Stefan Monnier wrote: > > +#ifdef HAVE_GNUTLS > > + /* GnuTLS buffers data internally. In lowat mode it leaves some data > > Shouldn't that be "Iowait"? No, it's a "low water" value / mode. Whatever that's supposed to mean... > Also please put 2 spaces after a ".". > > > + && gnutls_record_check_pending(wait_proc->gnutls_state) > 0) > ^^ > needs a space > > > + sc = select (fd + 1, &fdset, (SELECT_TYPE *)0, (SELECT_TYPE *)0, &timeout); > > That seems to go way past column 80. Please fold it. > > > + /* translate WSAEWOULDBLOCK alias > > + EWOULDBLOCK to EAGAIN for > > + GnuTLS */ > > The comment above needs to start with a capital letter and end with a ".". > > > +extern ssize_t emacs_gnutls_pull(gnutls_transport_ptr_t p, > > + void* buf, size_t sz); > > +extern ssize_t emacs_gnutls_push(gnutls_transport_ptr_t p, > > + const void* buf, size_t sz); > > Again, the above needs spaces before the open paren. OK, is there a style guide somewhere or better yet a style checker for these kind of faux pas? - Claudio