unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Tassilo Horn <tassilo@member.fsf.org>, emacs-devel@gnu.org
Subject: Re: Killing a frame sometimes kills emacs
Date: Fri, 18 Nov 2011 10:41:44 +0800	[thread overview]
Message-ID: <87d3cqf8yf.fsf@gnu.org> (raw)
In-Reply-To: <4EC5378C.5020500@cs.ucla.edu> (Paul Eggert's message of "Thu, 17 Nov 2011 08:34:20 -0800")

Paul Eggert <eggert@cs.ucla.edu> writes:

> Also, this code would be easier to read:
>
>     if (! (use_gtk && terminal->type == output_x_window))
>       terminal->reference_count--;
>
> with something like this near the start of the file:
>
>    #ifdef USE_GTK
>     enum { use_gtk = 1 };
>    #else
>     enum { use_gtk = 0 };
>    #endif

We don't follow this practice elsewhere in Emacs; let's not start now.



  parent reply	other threads:[~2011-11-18  2:41 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31 20:16 Killing a frame sometimes kills emacs Tassilo Horn
2011-08-31 20:51 ` joakim
2011-08-31 23:06 ` chad
2011-09-01  2:53 ` Eli Zaretskii
2011-09-01  7:04   ` Tassilo Horn
2011-09-01 10:09   ` Tassilo Horn
2011-09-01 10:27     ` Eli Zaretskii
2011-09-01 10:42       ` Tassilo Horn
2011-09-01 10:56         ` Eli Zaretskii
2011-09-01 11:09           ` Tassilo Horn
2011-09-01 10:33     ` Andreas Schwab
2011-09-01 10:45       ` Tassilo Horn
2011-09-01 12:47         ` Jan D.
2011-09-01 13:05           ` Tassilo Horn
2011-09-01 15:29           ` Eli Zaretskii
2011-09-01 19:30             ` Ken Raeburn
2011-09-02 15:02               ` Andreas Schwab
2011-10-11  6:46             ` Tassilo Horn
2011-10-11 12:53               ` Stefan Monnier
2011-10-11 14:53                 ` Tassilo Horn
2011-10-11 17:38                   ` James Cloos
2011-10-11 19:17                     ` Tassilo Horn
2011-10-11 19:49                       ` Tassilo Horn
2011-10-12  2:04                     ` Chong Yidong
2011-10-12  6:49                       ` Tassilo Horn
2011-10-12 12:57                         ` Stefan Monnier
2011-11-17 10:10                           ` Tassilo Horn
2011-11-17 11:18                             ` Chong Yidong
2011-11-17 13:45                               ` Tassilo Horn
2011-11-17 16:34                                 ` Paul Eggert
2011-11-17 16:58                                   ` Tassilo Horn
2011-11-18  2:41                                   ` Chong Yidong [this message]
2011-11-18  2:05                             ` Stefan Monnier
2011-11-18  9:38                               ` Tassilo Horn
2012-01-20 23:29                                 ` andres.ramirez
2012-01-21  0:34                                   ` Glenn Morris
2012-01-21  8:02                                     ` andres.ramirez
2012-01-20 23:29                                 ` andres.ramirez
2011-10-11 17:56               ` Jan Djärv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d3cqf8yf.fsf@gnu.org \
    --to=cyd@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=tassilo@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).