From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: false warnings when compiling with lexical-binding and cl-lib. Date: Sat, 23 Nov 2013 16:53:23 +0100 Organization: Emacs Helm Message-ID: <87d2lrunbg.fsf@gmail.com> References: <8761rl6ael.fsf@gmail.com> <87ob5bzlvr.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1385222026 28014 80.91.229.3 (23 Nov 2013 15:53:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Nov 2013 15:53:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 23 16:53:50 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VkFWm-0006cH-Sc for ged-emacs-devel@m.gmane.org; Sat, 23 Nov 2013 16:53:49 +0100 Original-Received: from localhost ([::1]:44166 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkFWm-0007GW-I4 for ged-emacs-devel@m.gmane.org; Sat, 23 Nov 2013 10:53:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkFWf-0007GE-9E for emacs-devel@gnu.org; Sat, 23 Nov 2013 10:53:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkFWZ-0005iR-QT for emacs-devel@gnu.org; Sat, 23 Nov 2013 10:53:41 -0500 Original-Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:58538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkFWZ-0005iE-JN for emacs-devel@gnu.org; Sat, 23 Nov 2013 10:53:35 -0500 Original-Received: by mail-we0-f176.google.com with SMTP id t61so2267116wes.35 for ; Sat, 23 Nov 2013 07:53:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=Wtr7itK22Zaitzo1BOMbZnTVYjwWtjyFblcZK9YBojM=; b=V6tY98s3fM8CtJ5FP/SvZgkylMVM70bzlO78XMYmVpz35HTBwxrCQ7umRIFwwC0ytk GrDGC6UbxUX3n1da/6przH45jjbMAc3V9Qoq/j+GsedrgDItFhPYD7rQwkw5MmkAq5fc eAgVEdzpBFx09cn/g/3j/RFiOR2sOvsDe2UgfBYzb/3duAwZIG164htxV4OpFnKf7Sfs /V46PhzKHqOG6JOFMuj718ngfdQc+auCcgrDZAOK2hyM/9YAqctlP6/oMc2f8wU6QBMu VnyVJX0UNZitk7BSMUH3kwMYsfGi8SAgpmM+0JZa7du/y/uAko0H4urZHH2hi8S8lksu siqA== X-Received: by 10.180.187.72 with SMTP id fq8mr7198007wic.26.1385222014437; Sat, 23 Nov 2013 07:53:34 -0800 (PST) Original-Received: from dell-14z (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPSA id gl10sm25672651wib.11.2013.11.23.07.53.33 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 23 Nov 2013 07:53:33 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Sat, 23 Nov 2013 08:51:45 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165624 Archived-At: Stefan Monnier writes: >> This patch avoid adding a new binding by the 'into' clause when the >> binding have been already added by a 'with' clause. >> I wonder if this is correct, real common-lisp return an error in such >> case, WDYT? > > Oh, wait, then the warning is OK. It indicates that the `with lst' is > extraneous and unused. IOW, there's no bug to fix. We could change > cl-loop to signal an error, but it doesn't seem to be worth the trouble. Yes, maybe the error message can be a little more explicit, common-lisp send a message like this: ,---- | Variable LST in INTO clause is a duplicate | current LOOP context: COLLECT I INTO LST FINALLY. | [Condition of type SB-INT:COMPILED-PROGRAM-ERROR] `---- Also the warning is only at compile time, should we return an error on evaluation ? This can be detected and handled from the same function i.e (cl--loop-handle-accum) -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997