unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: asjo@koldfront.dk (Adam Sjøgren)
To: emacs-devel@gnu.org
Subject: Re: emacs-uptime - insert text with C-u [patch]
Date: Tue, 10 Feb 2015 16:24:59 +0100	[thread overview]
Message-ID: <87d25hrdpw.fsf@topper.koldfront.dk> (raw)
In-Reply-To: mvm61b9bxsf.fsf@hawking.suse.de

Andreas writes:

>> +    (if here
>> +        (insert str)
>> +      (if (called-interactively-p 'interactive)
>> +          (message "%s" str)
>> +        str))))

> It think you should always return the same value, which is str.

I thought the same thing, but then I looked at emacs-version, which
doesn't:

    (if here
        (insert version-string)
      (if (called-interactively-p 'interactive)
          (message "%s" version-string)
        version-string))))

Do you think that should be changed as well?


  Best regards,

    Adam

-- 
 "You make a fair point. Knowing when not to say              Adam Sjøgren
  anything is not something the lazyweb had              asjo@koldfront.dk
  historically been good at."




      reply	other threads:[~2015-02-10 15:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-25 18:35 emacs-uptime - insert text with C-u [patch] Adam Sjøgren
2014-12-25 19:53 ` Andreas Schwab
2014-12-25 19:56   ` Adam Sjøgren
2014-12-26  4:54     ` Stephen J. Turnbull
2015-02-10 14:51       ` Adam Sjøgren
2015-02-10 15:18         ` Andreas Schwab
2015-02-10 15:24           ` Adam Sjøgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d25hrdpw.fsf@topper.koldfront.dk \
    --to=asjo@koldfront.dk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).