[Annotation] New package: smart-yank.el

[Annotation] New package: smart-yank.el

[Michael Heerdegen]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

Hello,


I intend to upload the attached package "smart-yank.el" to Gnu Elpa
(does that work again btw?).

Any comments, objections, ...or something like that?  Thanks.


Regards,

Michael.



[-- Attachment #2: smart-yank.el --]
[-- Type: application/emacs-lisp, Size: 6902 bytes --]

Re: [Annotation] New package: smart-yank.el

[Stefan Monnier]

> I intend to upload the attached package "smart-yank.el" to Gnu Elpa
> (does that work again btw?).
> Any comments, objections, ...or something like that?  Thanks.

Sounds good to me.  See nitpicks below.


        Stefan


> (let ((r (smart-yank--stopwatch)))
>   (defun smart-yank-yank-pop (&optional arg)
[...]
> (declare-function smart-yank-yank-pop 'smart-yank)

An arguably cleaner way to get the same result would be:

   (defalias 'smart-yank-yank-pop
     (let ((r (smart-yank--stopwatch)))
       (lambda (&optional arg)
         "blabla"
         ...)))

> (define-minor-mode smart-yank-mode
[...]
>   :global t :keymap smart-yank-map

Please name the keymap `smart-yank-mode-map' and don't use the :keymap
argument at all.

Re: [Annotation] New package: smart-yank.el

[Michael Heerdegen]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>    (defalias 'smart-yank-yank-pop
>      (let ((r (smart-yank--stopwatch)))
>        (lambda (&optional arg)
>          "blabla"
>          ...)))

Yes, this is a bit nicer.


> > (define-minor-mode smart-yank-mode
> [...]
> >   :global t :keymap smart-yank-map
>
> Please name the keymap `smart-yank-mode-map' [...]

Ah, that's the reason why removing the :keymap spec broke the thing when
I had tried it... ;-)


Many Thanks, Stefan!

Michael.