From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695). Date: Wed, 15 Jun 2016 17:09:53 +0200 Message-ID: <87d1nixzcu.fsf@gmx.net> References: <20160614214332.2901.16184@vcs.savannah.gnu.org> <20160614214332.C030F220116@vcs.savannah.gnu.org> <87h9cuyeip.fsf@gmx.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466003552 18178 80.91.229.3 (15 Jun 2016 15:12:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Jun 2016 15:12:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 15 17:12:23 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDCUR-00020v-2x for ged-emacs-devel@m.gmane.org; Wed, 15 Jun 2016 17:12:23 +0200 Original-Received: from localhost ([::1]:42795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDCUQ-00068e-EQ for ged-emacs-devel@m.gmane.org; Wed, 15 Jun 2016 11:12:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDCSC-0004eW-A0 for emacs-devel@gnu.org; Wed, 15 Jun 2016 11:10:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDCS7-0000c4-7w for emacs-devel@gnu.org; Wed, 15 Jun 2016 11:10:03 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:62314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDCS6-0000bn-UM for emacs-devel@gnu.org; Wed, 15 Jun 2016 11:09:59 -0400 Original-Received: from rosalinde ([89.245.94.221]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MFAaV-1bBFKC2x1X-00GGHH; Wed, 15 Jun 2016 17:09:55 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 15 Jun 2016 09:16:22 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:Dfhva88NBk5W4CkiDH1yYqVNfwWWLPJEp+qEJr4C2fKdTJkGIQL 1ZLKbwdOVcGjB+ki9veH3pZWYWZON8xEFel9C5ARsSFDL49IutD+aw4MqQYr14m5pKHOeGB doJjlpnzotr6SeECZrgrNckECTmSHzJnr5Ba0QvtAgE+KIM7+rPBgnvSUtKBFn91kI49qF+ SK6ndzNQP79z6Gr3W8aMQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:XsPckMjmMCo=:0gZJgiXStjSJ/PQMznmgRh gl01xt4YIN+G6sFmBHsfhmWD9ovS+yv2tAf3KtSTVLBPG1V+p3Zjc57to7WEvRrRcnjIBHo5y AM+RVteMaDTBfgSRly1XHtSdNmwWce/9VgdVbsV3jeQuX/be3aQb/yQH1Mw/xWnmShD9+M1QD tCLAW1LStF6SSI0YrPwDrEOiVJsgkOadr9OUjzkDCC1kNhkurk9M4tiu/2JWrQPLTUzuS5nA/ 8EB1TPnLTQX7yUXLZyhUsXdgI45XW2ct64JP3sn05eRWztMG16WUIxJcvvzGo5y3WD7M8wAYI p5GX4yXzFwdGIvxNZelEv0TyfXeBja64cWmQ0CueCKIfky5cKMh6h/UMXqxSQRFLnaw5zkoNG QgPo3iQYnXzpDDcKNvRR1US6jIsE8m3/LOQMzrrUlyuKxE37tqyt/dOexrd/kQZCA98AahkNI uE4bru38r4/KGzdSDALfkypn+cpwk13sLjXFSmXGlva6fQ83Jae47HpcGqK/iAAuBdte1PJDH 2QzYMeaAuUa/Bo8unsnIA+tH+4hDv408c/IZUliHdYMJ4dOMitWyI4FJwC5HTm9JAKtVDfWjF RuHZH0abkQeixvrNjXXfHcBws703HETHbpq2a2Nwfa+pTGDVrzMcnI7Yar6o/SeAoZCXUWxI0 lIaIW+TagRZ116piNWFq8Guro7f9GoCseNiCdIwRgcfRdC/QVz1nydy15z5xTgDDz8pw9iPEr zj4cu2eD0f6n8QElp5vyjZgL+n0c5tmWx+yxL9LTgAUgcB1Zttcq3Xe34ziUY6dpBEO7VSQ6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204392 Archived-At: On Wed, 15 Jun 2016 09:16:22 -0400 Stefan Monnier wrote: >>>> - (let ((map minibuffer-local-completion-map)) >>>> - (define-key map " " nil) >>>> + (let ((minibuffer-local-completion-map >>>> + (copy-keymap minibuffer-local-completion-map))) >>>> + (define-key minibuffer-local-completion-map " " 'self-insert-command) >>> Why bind it to `self-insert-command` rather than to nil? >> Is that a general recommendation, >> e.g. to make the `?' key insert `?' in the minibuffer also bind it to >> nil? > > The question is: do you want to hide the "SPC is completion" binding, or > do you want to force SPC to insert a space. > >> I guess that answers the question.) > > Right, IMO what we want here is to hide the "SPC is completion" binding. > Also, the old code used nil (as can be seen in the chunk of patch still > quoted above). Ok. I suppose that's also the case for most or all of the other packages that bind SPC to self-insert-command in the minibuffer, so they should probably also be changed in due course. >> Are you saying it is generally better to use the latter? > > Yes, it's more efficient. > >> If so, when is it better to use the former? > > Never. Copying is a bad idea. Then shouldn't copy-keymap be obsoleted (or at least deprecated, also in the documentation) and existing uses in Emacs changed? I'll revert the key binding to nil. I assume it's also all right to replace the use of copy-keymap by set-keymap-parent in emacs-25, since copy-keymap was just introduced as a fix there by this commit, but I'll wait for explicit approval (Eli, John W?). Thanks. Steve Berman