From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: RFC: defcustom display-popup-menus for display-popup-menus-p Date: Tue, 27 Dec 2016 15:43:31 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87d1gdhzm4.fsf@lifelogs.com> References: <87y3z9hxs1.fsf@lifelogs.com> <83r35110yv.fsf@gnu.org> <87r351hv1y.fsf@lifelogs.com> <83mvfp0zzd.fsf@gnu.org> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1482871459 32156 195.159.176.226 (27 Dec 2016 20:44:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Dec 2016 20:44:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 27 21:44:16 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cLybW-0007mn-38 for ged-emacs-devel@m.gmane.org; Tue, 27 Dec 2016 21:44:14 +0100 Original-Received: from localhost ([::1]:56169 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cLybb-0000cc-02 for ged-emacs-devel@m.gmane.org; Tue, 27 Dec 2016 15:44:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cLyb2-0000cX-RV for emacs-devel@gnu.org; Tue, 27 Dec 2016 15:43:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cLyaz-0004T6-OG for emacs-devel@gnu.org; Tue, 27 Dec 2016 15:43:44 -0500 Original-Received: from [195.159.176.226] (port=34091 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cLyaz-0004Sy-I2 for emacs-devel@gnu.org; Tue, 27 Dec 2016 15:43:41 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cLyap-0002kO-Vi for emacs-devel@gnu.org; Tue, 27 Dec 2016 21:43:31 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 33 Original-X-Complaints-To: usenet@blaine.gmane.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Cancel-Lock: sha1:YYv7v2LANj8wxG7CSQcVEd7aNHA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210850 Archived-At: On Wed, 21 Dec 2016 22:49:26 +0200 Eli Zaretskii wrote: >> From: Ted Zlatanov >> Date: Wed, 21 Dec 2016 15:43:53 -0500 >> >> I think `use-dialog-box' should be mentioned in the function docstring >> for `read-multiple-choice' maybe? So other people catch it? EZ> Be my guest, but IMO mentioning it will make no sense unless you also EZ> tell that the function uses popup menus under some circumstances. Is this OK? I tried to be as clear and concise as possible since that function's docstring is already pretty long. Thanks Ted diff --git a/lisp/emacs-lisp/subr-x.el b/lisp/emacs-lisp/subr-x.el index fdcfa70..fb88f50 100644 --- a/lisp/emacs-lisp/subr-x.el +++ b/lisp/emacs-lisp/subr-x.el @@ -214,6 +214,11 @@ (defun read-multiple-choice (prompt choices) perform the requested window recentering or scrolling and ask again. +When `use-dialog-box' is t (the default), this function can pop +up a dialog window to collect the user input. That functionality +requires `display-popup-menus-p' to return t. Otherwise, a text +dialog will be used. + The return value is the matching entry from the CHOICES list. Usage example: