unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Katsumi Yamaoka <yamaoka@jpl.org>, emacs-devel@gnu.org
Subject: Re: master 97934ff: Attach text files correctly in Message
Date: Fri, 27 Jan 2017 12:32:01 +0100	[thread overview]
Message-ID: <87d1f8wxfy.fsf@mouse> (raw)
In-Reply-To: <83tw8l0wav.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 27 Jan 2017 09:57:44 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

> When I read those changes, I actually wondered why it was necessary to
> set the buffer unibyte.  It shouldn't be needed with the current Emacs
> codebase, inserting unibyte text into a multibyte buffer and then
> decoding it should "just work".

We want neither encoding nor decoding of octets from files in that part
of the code, so unibyte buffers are the right thing to do in the "file"
part of that code.  Text from other buffers should be handled otherwise,
though... 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2017-01-27 11:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170125162832.21457.64236@vcs.savannah.gnu.org>
     [not found] ` <20170125162832.648B4220158@vcs.savannah.gnu.org>
2017-01-27  2:48   ` master 97934ff: Attach text files correctly in Message Katsumi Yamaoka
2017-01-27  7:57     ` Eli Zaretskii
2017-01-27 11:32       ` Lars Ingebrigtsen [this message]
2017-01-27 11:33     ` Lars Ingebrigtsen
2017-01-27 13:14       ` Katsumi Yamaoka
2017-01-27 13:18         ` Katsumi Yamaoka
2017-01-27 12:42     ` Lars Ingebrigtsen
2017-01-27 12:54     ` Lars Ingebrigtsen
2017-01-29 16:10     ` Lars Ingebrigtsen
2017-01-29 23:33       ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1f8wxfy.fsf@mouse \
    --to=larsi@gnus.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).