From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers, final testing Date: Wed, 12 Jul 2017 22:11:12 -0600 Message-ID: <87d1959dsv.fsf@lylat> References: <83y3s9pm2a.fsf@gnu.org> <874luuyuqy.fsf@lylat> <83wp7po86m.fsf@gnu.org> <87fuecc7vg.fsf@lylat> <83y3s2n5pa.fsf@gnu.org> <878tk1rmjx.fsf@lylat> <83a84gn4z9.fsf@gnu.org> <837ezkmwfg.fsf@gnu.org> <874lumps82.fsf@lylat> <8337a5ja4p.fsf@gnu.org> <83van0i5wl.fsf@gnu.org> <87iniy7ksy.fsf@lylat> <83pod6idqp.fsf@gnu.org> <87zical61u.fsf@lylat> <83mv89ivms.fsf@gnu.org> <87zic9a7tg.fsf@lylat> <8360exijpe.fsf@gnu.org> <87r2xla0e4.fsf@lylat> <8337a1hxhb.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1499919149 32587 195.159.176.226 (13 Jul 2017 04:12:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 13 Jul 2017 04:12:29 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: cloos@jhcloos.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 13 06:12:25 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVVUF-000867-C5 for ged-emacs-devel@m.gmane.org; Thu, 13 Jul 2017 06:12:23 +0200 Original-Received: from localhost ([::1]:57094 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVVUK-0001Cx-Qr for ged-emacs-devel@m.gmane.org; Thu, 13 Jul 2017 00:12:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVVUE-0001Cr-9r for emacs-devel@gnu.org; Thu, 13 Jul 2017 00:12:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVVUB-00057y-3H for emacs-devel@gnu.org; Thu, 13 Jul 2017 00:12:22 -0400 Original-Received: from mail-it0-f68.google.com ([209.85.214.68]:35880) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dVVUA-00055o-SO; Thu, 13 Jul 2017 00:12:19 -0400 Original-Received: by mail-it0-f68.google.com with SMTP id k3so5377887ita.3; Wed, 12 Jul 2017 21:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=nsaCpiMm7I2aWpy5FPh9/UfsZPb/QBbeLQcsvy4whEk=; b=MsBrELyLT2cmTaUplW1ebwGWq3ertnUWBAI0/Nm43RmTnEhMazOMRoUOHcK0TpohwB NQiM/A17/87QVh8/z1MfS5dVCe290Jzln6T6/IeKWWrnx1+RyaR79/Ir8caAvqGXudI8 yB34vl5MSBM2bOSE4iZ/csiaLsUcykZvRip9xNjL2SlV1G6NEXJlvHGV6f5Bahiklkhr LSuxKHtYEN86pT8/dB0wEb4M6kpT7i5pSzSkinh369/7H3pa3cvJCNAL6QP+w7AGCG1e L8Wz7oExpwGdmQ5D11331LY3G5AzH4hPJRVSWIb/Wy4YgoFnoQN03zF58IGDcC7cfi50 p1cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=nsaCpiMm7I2aWpy5FPh9/UfsZPb/QBbeLQcsvy4whEk=; b=nqMPEv1Gk42zOw/rf7rAiQ5hRNhtqME6H8lVfKmbqqUdj2plovcH6gBMsmCttwQaWi i/Cfnk7sqtiPEO06fFXxtUJyHwd99p/fpoV12A2o39fbT+2AEhjTfrNazfUv9lbkzx3/ Sz7d4Tmjm0kEehw2e65KvMEQ8szAR1wTPGY4K/mS0+RwYSo377d/c2+dMY5Swo9Q+/6Z qVQ7z2KDZ5JLIOHp3ulSa1DT5PZQfIFSDNSG9LwKOwktd9bqCwHl12zemVpgqK1MIrhV gIRL+M2ILbHCNYpRdLAUeYCgvcGP58/Z6KQYk0yN7T1Ugwh1CJaPj5Ex58c32pm2stQY ajDQ== X-Gm-Message-State: AIVw110djgKdQrJCB4RfqnOrw57hWRCGPVUHEQmAQLHX4J6OTg5egBg4 4XgkMCutKXh6Zg2Y X-Received: by 10.36.192.197 with SMTP id u188mr11526532itf.4.1499919076011; Wed, 12 Jul 2017 21:11:16 -0700 (PDT) Original-Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id y83sm2943143ioe.17.2017.07.12.21.11.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jul 2017 21:11:14 -0700 (PDT) In-Reply-To: <8337a1hxhb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Jul 2017 05:38:56 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.214.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216569 Archived-At: Eli Zaretskii writes: >> From: Alex >> Cc: cloos@jhcloos.com, emacs-devel@gnu.org >> Date: Wed, 12 Jul 2017 14:03:15 -0600 >>=20 >> Eli Zaretskii writes: >>=20 >> >> From: Alex >> >> Cc: cloos@jhcloos.com, emacs-devel@gnu.org >> >> Date: Wed, 12 Jul 2017 11:22:51 -0600 >> >>=20 >> >> > It should be sensible, I agree. But "sensible" doesn't necessarily >> >> > mean identical to the default face's font. >> >>=20 >> >> Sure, but I maintain in this case that it does mean identical to the >> >> default face's font. >> > >> > I don't understand why, and I don't think I agree. >>=20 >> I don't see a single reason to make it different. > > It's for when the default face uses a variable-pitch font, as I > believe I already explained. I wasn't referring to the fixed-pitch part, just the serif part. The addition of serifs is orthogonal to fixing the case of a variable-pitched default font. In your patch, you injected an unrelated property into the face that has nothing to do with fixing the variable-pitch issue. Just to make myself extra clear: I am in favour of forcing line numbers to be fixed-pitch by default. However, I'm not in favour of using "Monospace Serif" instead of "Monospace" considering that the default is the latter. > And instead of repeating the same arguments again and again, I think > we should simply agree to disagree, and wait for others to offer their > opinions and experiences about this. I don't see how the discussion was about to devolve into repetition (though there appears to have been some miscommunication). While I agree that others should give their input, I find it disappointing that you ignored the rest of my email. >> >> (insert (propertize "hello there!" 'face 'fixed-pitch)) >> >>=20 >> >> This text increases along with the default face with "C-x +". Why does >> >> the same not apply to the line-number face? >> > >> > I don't know. Feel free to investigate and publish the findings. >>=20 >> Well, it definitely seems like a bug to me. text-scale-mode uses >> face-remap-add-relative on 'default, but I don't see why this would >> cause an issue. The manual states that any 'unspecified attributes mean >> that the attributes are taken from the default face, so I don't see why >> adding :inherit 'default should even make a difference. >>=20 >> Perhaps I should file a bug report? > > I don't think I understood what you consider a bug here. Face > attributes are calculated when the face is created, they are not > updated whenever the default face changes. Not in the case of 'unspecified, right? Evaluating (set-face-bold 'default t) changes every face with an 'unspecified bold attribute to bold. Just to be clear, this is what the manual states[1]: Apart from the values given below, each face attribute can have the value =E2=80=98unspecified=E2=80=99. This special value means that the fac= e doesn=E2=80=99t specify that attribute directly. An =E2=80=98unspecified=E2=80=99 attribut= e tells Emacs to refer instead to a parent face (see the description =E2=80=98:inherit=E2= =80=99 attribute below); or, failing that, to an underlying face (*note Displaying Faces::). The =E2=80=98default=E2=80=99 face must specify all a= ttributes. So if I'm understanding this correctly, then you shouldn't have to inherit from 'default since any unspecified attributes already fallback to 'default. The behaviour in this case is different, therefore this is a bug (something isn't handling face-remapping-alist correctly). Footnotes:=20 [1] (info "(elisp) Face Attributes")