From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers landed on master Date: Sun, 16 Jul 2017 01:30:16 -0600 Message-ID: <87d190j0tz.fsf@lylat> References: <83k23jl5ra.fsf@gnu.org> <87r2xqo8p7.fsf@lylat> <83lgnxk7v6.fsf@gnu.org> <87shi5jk2w.fsf@lylat> <83lgnwi3k3.fsf@gnu.org> <87a84crq31.fsf@lylat> <834lujj9d5.fsf@gnu.org> <87pod67lgi.fsf@lylat> <83fue1iur9.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1500190250 2220 195.159.176.226 (16 Jul 2017 07:30:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 16 Jul 2017 07:30:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 16 09:30:43 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWe0o-0008OI-R3 for ged-emacs-devel@m.gmane.org; Sun, 16 Jul 2017 09:30:43 +0200 Original-Received: from localhost ([::1]:44377 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWe0q-0006RS-Q2 for ged-emacs-devel@m.gmane.org; Sun, 16 Jul 2017 03:30:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWe0k-0006RI-4b for emacs-devel@gnu.org; Sun, 16 Jul 2017 03:30:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWe0g-00031z-Ul for emacs-devel@gnu.org; Sun, 16 Jul 2017 03:30:38 -0400 Original-Received: from mail-io0-x22d.google.com ([2607:f8b0:4001:c06::22d]:33617) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dWe0g-00031N-P5; Sun, 16 Jul 2017 03:30:34 -0400 Original-Received: by mail-io0-x22d.google.com with SMTP id h64so30600241iod.0; Sun, 16 Jul 2017 00:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=e6xvEdrTroWhr7c7H6tufSuVgSJMNgfzGmMIeg6tNJw=; b=JHfipX/QyDMH7cT02TqxKpJW4GYvS/r6SsAJrQXd1z+HN7UI5UsEikgeQzIeCO4Zol y8m6HQ8oIRRIM4rqb8YbluP69eXQKPm17n5Zv1k6di4CZV0eV7Y32098MSvEKIqQGDFC 8rH37IABIPcJfaVcEoXPWrC8pHk5iwMFo6Az5cHPC8LrrshHrntLuYNcmiMWEz2oouUV g2TtzbL2BALMMZLvEafMIYTFXjORqAZQJ82hOLhSytqDV2ti4XSES/9wkGHTh7Eeo+77 ov1rdnNcWX009JQy9RzDZgpnTm1x3sLpnPjASE+T0aJ5LC3l/OtPcPSeLezwQLw5+nWl TZgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=e6xvEdrTroWhr7c7H6tufSuVgSJMNgfzGmMIeg6tNJw=; b=rBlqUx41rvhD7HIIvewUE3mSwVXEliMXDdI+UoC3WrZGgTI79vTLcIQelN6b2oOh+/ a/EvbEbtvhp68u2HI+wtkTZEWHc8VaOtBW3FXTnLqMTs5/SoJbPRGbJ0c4bOYFA56zMQ 5P9KsTyzo0D76WHkZpDcPahuqMnAR/HLkhmmhANCk7GEQuL+0tdmS5H9A++lmb55JHd/ dJdaRR+/41ppwgALi7B/xIpciP/wrT7kcFdP7aBvCej7IIRA1/UyQyIr7i8HN98k4HW3 CLmwgLBCbw/YQ/DXnQB4m2nGLuhTOVo7fH36hNnXJeZru466D35evvCB/Be3QY8U1FPI IHbA== X-Gm-Message-State: AIVw110golCrrVmoVenZfWYInJQbG1YUcM0+B6Zl/lPBjgHOpUlrhyPT R9bV1WlL9nKXer1K X-Received: by 10.107.168.1 with SMTP id r1mr14614500ioe.82.1500190232031; Sun, 16 Jul 2017 00:30:32 -0700 (PDT) Original-Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id r21sm3864562ita.16.2017.07.16.00.30.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 16 Jul 2017 00:30:30 -0700 (PDT) In-Reply-To: <83fue1iur9.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 12 Jul 2017 17:40:10 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c06::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216722 Archived-At: Eli Zaretskii writes: >> From: Alex >> Cc: emacs-devel@gnu.org >> Date: Tue, 11 Jul 2017 14:44:13 -0600 >> >> > Sounds OK to me, thanks. I think we do want all the variables to >> > appear in the same customization group, even if they are defined >> > separately. >> >> Well, it seems this cus-edit change doesn't fix it by itself. When >> executing customize-group without display-line-numbers loaded, then the >> lisp-level defcustoms aren't shown. It might be because there's a >> missing entry in cus-load.el, but I don't know how to add a group to it. >> linum, for instance, appears to automatically be added to it. > > cus-load.el is auto-generated. Did the rule which updates it in > lisp/Makefile get running after your changes, and was cus-load.el > regenerated as result? If not, maybe you need to run that rule by > hand. I'm still not well-versed in Emacs's build system. cus-load doesn't get updated automatically for me (I had to manually run the target). Is this expected? It appears that no rule forces cus-load to be regenerated, and only bootstrap-clean removes the file. After pulling changes, all I do is run "make -j4"; is it recommended to run extra rules each time, or just when I notice issues? >> Would it be better to skip creating a new defgroup and have all >> variables just be in the display group, or are you in favour of a new >> group just for line numbers? > > If it's a hassle to make a new group, we can stay in the display > group. It's not a hassle, but I was looking at the git-blame for cus-edit and noticed that most of the entries are quite old. Is this group important enough to add to the file? It looks like I could just leave the defgroup definition in display-line-numbers.el and the variables in cus-start.el can still use it without display-line-numbers.el being preloaded. Which file would you rather have it in?