unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: emacs-devel@gnu.org
Subject: The issue with with-temp-buffer (or with-current-buffer)
Date: Sat, 16 Dec 2017 03:25:58 +0900	[thread overview]
Message-ID: <87d13f97bd.fsf@mail.parknet.co.jp> (raw)

Hi,

The following is the reproduce code of issue,

(let ((buf (get-buffer-create "test-case")))
  (display-buffer buf)
  (with-current-buffer buf
    (erase-buffer)
    (insert "1\n")
    ;; start suspect
    (with-temp-buffer
      (save-window-excursion
	(set-window-buffer nil (current-buffer))))
    ;; end suspect
    (insert "2\n")))

and expected result is

    ---- test-case ----
    2
    1
    -------------------

But actual result is

    ---- test-case ----
    1
    2
    -------------------

[The actual issue that I'm hitted was using `shr-insert-document'
like following. And above is simplied version to reproduce the issue.

  (with-current-buffer buf
    (erase-buffer)
    (insert ...)
    (shr-insert-document '(html nil (body nil ...)))
    (insert ...)))
]

After some debugging, I noticed `with-current-buffer' that is
used in `with-temp-buffer' doesn't restore `point'.

And if I replaced `with-current-buffer' with
save-excursion+set-buffer, the issue is fixed.

I.e. from
	(with-temp-buffer
to
	(save-excursion
	  (set-buffer ,temp-buffer)

Well so, this behavior (doesn't restore point) of
`with-temp-buffer' (or `with-current-buffer') is intented or bug?

And to fix this issue, we should change which one of
with-temp-buffer, with-current-buffer, shr-insert-document, or
user of shr-insert-document?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>



             reply	other threads:[~2017-12-15 18:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15 18:25 OGAWA Hirofumi [this message]
2017-12-15 20:13 ` The issue with with-temp-buffer (or with-current-buffer) OGAWA Hirofumi
2017-12-15 20:51 ` Eli Zaretskii
2017-12-15 21:46   ` OGAWA Hirofumi
2017-12-15 22:40     ` OGAWA Hirofumi
2017-12-16  8:29       ` Eli Zaretskii
2017-12-16 12:55         ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d13f97bd.fsf@mail.parknet.co.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).