From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: handa@gnu.org (K. Handa) Newsgroups: gmane.emacs.devel Subject: Re: Issues with quail.el Date: Fri, 18 May 2018 23:36:16 +0900 Message-ID: <87d0xtowtb.fsf@gnu.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1526654141 15699 195.159.176.226 (18 May 2018 14:35:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 18 May 2018 14:35:41 +0000 (UTC) Cc: amit.ramon@riseup.net, emacs-devel@gnu.org To: Filipp Gunbin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 18 16:35:37 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJgTo-0003ze-LB for ged-emacs-devel@m.gmane.org; Fri, 18 May 2018 16:35:36 +0200 Original-Received: from localhost ([::1]:39345 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJgVv-0002IH-Qv for ged-emacs-devel@m.gmane.org; Fri, 18 May 2018 10:37:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJgUg-0002FS-Ge for emacs-devel@gnu.org; Fri, 18 May 2018 10:36:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJgUe-0003zW-LN for emacs-devel@gnu.org; Fri, 18 May 2018 10:36:30 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJgUV-0003tY-VD; Fri, 18 May 2018 10:36:20 -0400 Original-Received: from fl1-119-240-85-224.iba.mesh.ad.jp ([119.240.85.224]:57210 helo=mongkok) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fJgUV-0007yq-Fu; Fri, 18 May 2018 10:36:19 -0400 Original-Received: from handa by mongkok with local (Exim 4.90_1) (envelope-from ) id 1fJgUS-0001No-B7; Fri, 18 May 2018 23:36:16 +0900 In-Reply-To: (message from Filipp Gunbin on Thu, 17 May 2018 18:44:00 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225404 Archived-At: In article , Filipp Gunbin writes: > On 17/05/2018 21:31 +0900, K. Handa wrote: > > Here's the patch to fix it. Could you please try it? ... > > + ;; This location not available in the current keyboard > > + ;; layout. Check if the location is used to substitute > > + ;; for the other location of the standard layout. > > + (if (setq i (cdr (rassq i quail-keyboard-layout-substitution))) > > + (aref quail-keyboard-layout i) > Cannot understand this part - it seems to look up alist element by cdr > (i), and then set i to the same value. Should there be `(car (rassq..' > instead? You are right. I made quail-keyboard-untranslate by copying quail-keyboard-translate and forgot to adjust the above part correctly. --- K. Handa handa@gnu.org