From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Return value of finished threads Date: Sun, 22 Jul 2018 12:02:19 +0200 Message-ID: <87d0vf1tck.fsf@gmx.de> References: <87h8kuq7kf.fsf@gmx.de> <87h8kt3hcj.fsf@tromey.com> <87wotphqre.fsf@gmx.de> <87lga44u14.fsf@tromey.com> <874lgsivam.fsf@gmx.de> <87h8ks4qot.fsf@tromey.com> <87zhykbqve.fsf@gmx.de> <878t644fph.fsf@tromey.com> <87va98xu35.fsf@gmx.de> <874lgs46bn.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1532253677 8488 195.159.176.226 (22 Jul 2018 10:01:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 22 Jul 2018 10:01:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 22 12:01:13 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhBAu-00023e-TL for ged-emacs-devel@m.gmane.org; Sun, 22 Jul 2018 12:01:13 +0200 Original-Received: from localhost ([::1]:55409 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhBD0-0005cB-6Y for ged-emacs-devel@m.gmane.org; Sun, 22 Jul 2018 06:03:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhBCI-0005c6-HD for emacs-devel@gnu.org; Sun, 22 Jul 2018 06:02:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhBCF-0005pO-Dk for emacs-devel@gnu.org; Sun, 22 Jul 2018 06:02:38 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:59019) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhBCF-0005pG-4G for emacs-devel@gnu.org; Sun, 22 Jul 2018 06:02:35 -0400 Original-Received: from detlef.gmx.de ([213.220.158.134]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MGBdv-1flJed2HCR-00FB2n; Sun, 22 Jul 2018 12:02:20 +0200 In-Reply-To: <874lgs46bn.fsf@tromey.com> (Tom Tromey's message of "Sat, 21 Jul 2018 15:39:08 -0600") X-Provags-ID: V03:K1:2Q7HAnDEd4D21ac4qXRlwJZOv2Qi1zjO13zqiqxkug9mm8lkf67 DabiziOEZ7YI1iFVSWFXQcnS5BiHMhF7Hg3Bf+ZcsNmgKL9AGXX5RfZYXGIPu+bFEi36bYd DqHa/rAlUcRtGNqLRt0DRBenSZ3x+A4O/Gow6XpevSgrxI1vSlof7wlculNpG5xs8J3Sk24 awHrr7syuCrFfdKyjCHhQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:I2YnLjvhyI0=:bmi5Tdot5y1gS1vS3boGaz Fsge7zhASKlUFOJPm+egQbhbTBK+aguRHl7geBHnDBm9/xFoRevrI3+fzl8Kuhy718KPBQr9y pCSLpCYtqWIqf0pGJoq/sBqZoNquNlf+ExGEZ38fDR+lbdGeL/t2btyvqrWr4EG3W1D6kERb3 aotln7uex4bj+RJvaKoUfc6IlZ+3xu2bPkl3E3fKDC1VCLDDvMtnEHFl5CkI8xwEdJrfe2qk6 s+1aLG/Oh4FlALW7V/11lGeniC6mLkEqFv+WFwVW+GbihmuchSP96OkpXyc0JsvUpwrLr++uI gn/9qAs8+NnzddjM1j2j7oEuU+IjicUAun+aNyY+6Wt8g3JZ+7bKUy9ePznah9I9ijquDEIhz DQE4dE2ZKqCaSBxaLiNCMeBOertxGmut6doS2Dtd3yCZSjE45OggnrhEFvMKdHwd0NgdBMHev wfcobjhRLDSR67sL1rxZVf3/nrxW3U83a3ZKX9GiNRn+QSGvwr9t/n/X5wpZvdw3i1QVKz235 UQdsonjluEpHZlZX4Y3q6QC4J+0sxt7iZE97VdLbdCsD1y+Qj0K0v7R391ck5G46HUj3i13Oe Bti6+//10p4U6kkZWy63bL99tjvn3/OlTtWqJemzoNXhgFgjJdRxVixYTrn4kjDhCzSI5m8dd 8yE2hP0D/Y6kOUQZ3FE7EoJdsFkPP3mewzbNOK/WR8spgzjXS7peoz11Uq2Wnv0g1H2Eqdv7f bklLjjoDN7GTXxhMOqsp1jHeW2zbd6g3nAooRbOBP73ZwoSH22NqLnAd+rgct8h0cj6ahWc2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227652 Archived-At: Tom Tromey writes: Hi Tom, > Michael> I'm still lost. Will you provide a respective patch, or does > Michael> it mean I could push my patch as-it-is? > > I think it's already fine. I've pushed this to master, including documentation and NEWS. I've also added some code for signal propagation of the finished thread to the current one. This works OK for the quit signal (see changed threads-mutex-signal test), but this does not work for ordinary errors (see new test threads-join-error, I've marked it as :unstable for the time being). I guess that the handlers catch the error somehow; maybe you could have a look on this. For this reason, I haven't documented signal propagation yet. I'm also uncertain whether it is desired to propagate signals via thread-join in all use cases. Maybe we add an optional NOSIGNAL argument to this function? > Tom Best regards, Michael.