unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Berman <stephen.berman@gmx.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Commit mistake?
Date: Sun, 25 Nov 2018 18:09:07 +0100	[thread overview]
Message-ID: <87d0qtqe30.fsf@gmx.net> (raw)
In-Reply-To: <jwva7lxrtma.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Sun, 25 Nov 2018 11:49:22 -0500")

On Sun, 25 Nov 2018 11:49:22 -0500 Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>> And also tell me how to avoid a possible reoccurrence of in future
>> commits?
>
> Hard to help if you don't give us at least a hint of what commands/UI
> you used to do the commit.  Did you use "git commit" on the command
> line, or Magit, or VC, or something yet different?

I used VC.  The file was listed in *vc-dir*, but it has been for ages
and was never a problem before.  But this time after I committed the
change the status of that file also changed to "up-to-date", which
suprised me but, unfortunately, didn't stop me from pressing `P' to push
the commit (since, again, that file had "always" been there but never
got into a previous commit).  I know I should have stopped to think, and
hopefully I will in future, but I wonder how that file became part of
the commit in the first place (again, I never knowingly touched it).

Steve Berman



  reply	other threads:[~2018-11-25 17:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-25 13:22 Commit mistake? Stephen Berman
2018-11-25 16:34 ` Eli Zaretskii
2018-11-25 16:47   ` Stephen Berman
2018-11-25 17:06     ` Eli Zaretskii
2018-11-25 16:49 ` Stefan Monnier
2018-11-25 17:09   ` Stephen Berman [this message]
2018-11-25 18:16     ` Stefan Monnier
2018-11-25 18:42       ` Stephen Berman
2018-11-25 19:53         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0qtqe30.fsf@gmx.net \
    --to=stephen.berman@gmx.net \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).