From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: send new reply from gnus hangs Date: Mon, 10 Jun 2019 01:25:52 +0200 Message-ID: <87d0jmuyrj.fsf@telefonica.net> References: <87r285nhxb.fsf@telefonica.net> <87k1duml43.fsf@telefonica.net> <87sgsiwehh.fsf@telefonica.net> <87k1du744k.fsf@telefonica.net> <87h88y8ibl.fsf@telefonica.net> <878suas5wv.fsf@telefonica.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="229788"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 10 01:30:22 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ha7GY-000xew-0o for ged-emacs-devel@m.gmane.org; Mon, 10 Jun 2019 01:30:22 +0200 Original-Received: from localhost ([::1]:39024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ha7GX-0001ga-0h for ged-emacs-devel@m.gmane.org; Sun, 09 Jun 2019 19:30:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51803) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ha7GI-0001Rz-4c for emacs-devel@gnu.org; Sun, 09 Jun 2019 19:30:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ha7GG-0000MQ-U0 for emacs-devel@gnu.org; Sun, 09 Jun 2019 19:30:06 -0400 Original-Received: from [195.159.176.226] (port=59204 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ha7GG-0000JB-NP for emacs-devel@gnu.org; Sun, 09 Jun 2019 19:30:04 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1ha7GE-000xGZ-CZ for emacs-devel@gnu.org; Mon, 10 Jun 2019 01:30:02 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:kXLNaH1C2+0RrCoJfyA5d0BLGC0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237377 Archived-At: Óscar Fuentes writes: >>>>>> Andy Moreton writes: >>>>>> >>>>>>> A recent change on the master branch (within the last week) prevents >>>>>>> gnus from sending replies to newsgroups - it gets stuck with >>>>>>> "sending..." in the message area. >>>>>>> >>>>>>> I've looked at the recent commits that might affect gnus, but nothing >>>>>>> obvious jumps out. I'm not sure what the problem is or how to start >>>>>>> debugging it. >>>>>>> >>>>>>> Does anyone have any ideas ? >>>>>> >>>>>> git bisect The problematic commit is master e51adfbdb7587c2b0b5ba154be210b30db82b4ea Author: Oleh Krehel AuthorDate: Thu Jun 6 16:01:10 2019 +0200 Commit: Oleh Krehel CommitDate: Thu Jun 6 16:01:10 2019 +0200 Parent: e188f08fcd lisp/gnus/message.el (message--fold-long-headers): Add docstring Merged: emacs-26 master Containing: master Follows: emacs-26.1 (5471) lisp/gnus/message.el (message--check-continuation-headers): Extract 1 file changed, 13 insertions(+), 21 deletions(-) lisp/gnus/message.el | 34 +++++++++++++--------------------- modified lisp/gnus/message.el @@ -4476,6 +4476,17 @@ message-send-mail-partially (declare-function hashcash-wait-async "hashcash" (&optional buffer)) +(defun message--check-continuation-headers () + (message-check 'continuation-headers + (goto-char (point-min)) + (while (re-search-forward "^[^ \t\n][^ \t\n:]*[ \t\n]" nil t) + (goto-char (match-beginning 0)) + (if (y-or-n-p "Fix continuation lines? ") + (insert " ") + (forward-line 1) + (unless (y-or-n-p "Send anyway? ") + (error "Failed to send the message")))))) + (defun message-send-mail (&optional _) (require 'mail-utils) (let* ((tembuf (message-generate-new-buffer-clone-locals " message temp")) @@ -4527,15 +4538,7 @@ message-send-mail (if news nil message-deletable-headers))) (message-generate-headers headers)) ;; Check continuation headers. - (message-check 'continuation-headers - (goto-char (point-min)) - (while (re-search-forward "^[^ \t\n][^ \t\n:]*[ \t\n]" nil t) - (goto-char (match-beginning 0)) - (if (y-or-n-p "Fix continuation lines? ") - (insert " ") - (forward-line 1) - (unless (y-or-n-p "Send anyway? ") - (error "Failed to send the message"))))) + (message--check-continuation-headers) (message--fold-long-headers) ;; Let the user do all of the above. (run-hooks 'message-header-hook)) @@ -5159,18 +5162,7 @@ message-check-news-header-syntax (if (= (length errors) 1) "this" "these") (if (= (length errors) 1) "" "s") (mapconcat 'identity errors ", "))))))) - ;; Check continuation headers. - (message-check 'continuation-headers - (goto-char (point-min)) - (let ((do-posting t)) - (while (re-search-forward "^[^ \t\n][^ \t\n:]*[ \t\n]" nil t) - (goto-char (match-beginning 0)) - (if (y-or-n-p "Fix continuation lines? ") - (insert " ") - (forward-line 1) - (unless (y-or-n-p "Send anyway? ") - (setq do-posting nil)))) - do-posting)) + (message--check-continuation-headers) ;; Check the Newsgroups & Followup-To headers for syntax errors. (message-check 'valid-newsgroups (let ((case-fold-search t)