From: "Štěpán Němec" <stepnem@gmail.com>
To: Robert Pluim <rpluim@gmail.com>
Cc: Philipp Stephani <phst@google.com>,
Philipp Stephani <p.stephani2@gmail.com>,
emacs-devel@gnu.org
Subject: Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis.
Date: Thu, 02 Apr 2020 11:59:47 +0200 [thread overview]
Message-ID: <87d08qky24.fsf@gmail.com> (raw)
In-Reply-To: <m2d08qz0bm.fsf@gmail.com> (Robert Pluim's message of "Thu, 02 Apr 2020 11:47:09 +0200")
On Thu, 02 Apr 2020 11:47:09 +0200
Robert Pluim wrote:
>>>>>> On Thu, 2 Apr 2020 11:40:45 +0200, Philipp Stephani <phst@google.com> said:
>
> Philipp> Am Do., 2. Apr. 2020 um 11:25 Uhr schrieb Robert Pluim <rpluim@gmail.com>:
> >>
> >> >>>>> On Wed, 1 Apr 2020 19:57:36 +0200, Philipp Stephani <p.stephani2@gmail.com> said:
> >>
> Philipp> * lisp/files.el (auto-save-visited-inhibit): New buffer-local
> Philipp> variable.
> Philipp> (auto-save-visited-mode): Use it.
> >>
> >> Could you expand on why this is needed? What's stopping you from just
> >> turning off auto-save-visited-mode in those buffers, either directly
> >> or via local variables?
>
> Philipp> auto-save-visited-mode is a global mode, it can't be turned off for
> Philipp> individual buffers.
>
> Youʼre right, I saw the 'define-minor-mode' bit and missed that itʼs a
> global minor mode.
Still, wouldn't it be better to add the rationale to the commit message?
IMO there should always be some commentary or explanation, unless it's
just an obvious or trivial fix. I often find myself wondering "why was
this change made?" when browsing the commit history, and I'm sure I'm
not the only one.
--
Štěpán
next prev parent reply other threads:[~2020-04-02 9:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 17:57 [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis Philipp Stephani
2020-04-02 9:24 ` Robert Pluim
2020-04-02 9:40 ` Philipp Stephani
2020-04-02 9:47 ` Robert Pluim
2020-04-02 9:59 ` Štěpán Němec [this message]
2020-04-02 11:15 ` Philipp Stephani
2020-04-02 11:27 ` Štěpán Němec
2020-04-02 13:38 ` Eli Zaretskii
2020-04-02 15:22 ` Stefan Monnier
2020-04-05 9:50 ` Philipp Stephani
2020-04-05 14:18 ` Stefan Monnier
2020-04-05 15:51 ` Philipp Stephani
2020-04-05 18:49 ` Stefan Monnier
2020-04-05 19:58 ` Philipp Stephani
2020-04-08 11:43 ` Philipp Stephani
2020-04-08 12:03 ` Eli Zaretskii
2020-04-08 12:19 ` Philipp Stephani
2020-04-08 13:07 ` Eli Zaretskii
2020-04-08 14:58 ` Stefan Monnier
2020-04-11 16:57 ` Philipp Stephani
2020-04-11 17:11 ` Stefan Monnier
2020-05-25 19:16 ` Philipp Stephani
2020-04-05 9:52 ` Philipp Stephani
2020-04-05 13:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d08qky24.fsf@gmail.com \
--to=stepnem@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=phst@google.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).