From: Colin Baxter <m43cap@yandex.com>
To: Richard Copley <rcopley@gmail.com>
Cc: , Eli Zaretskii <eliz@gnu.org>, Emacs Development <emacs-devel@gnu.org>
Subject: Re: reverting non-existent file
Date: Fri, 15 May 2020 06:36:15 +0100 [thread overview]
Message-ID: <87d075iwts.fsf@yandex.com> (raw)
In-Reply-To: <CAPM58oh9mTTorRYLUJXTmoP5OAvL0PDXu_8ZJYp6_EX9q1jKfg@mail.gmail.com> (Richard Copley's message of "Thu, 14 May 2020 20:54:02 +0100")
>>>>> Richard Copley <rcopley@gmail.com> writes:
> On Thu, 14 May 2020 at 20:03, Eli Zaretskii <eliz@gnu.org> wrote:
>>
>> > From: Colin Baxter <m43cap@yandex.com> > Cc:
>> emacs-devel@gnu.org > Date: Thu, 14 May 2020 19:52:29 +0100
>> >
>> > > I get the error message even if I don't do steps 3 to 6. And
>> that > > is expected, as a non-existent file cannot be reverted.
>> So what > > did you find surprising in this behavior?
>> >
>> > > (I'm guessing that your locale uses UTF-8 as its codeset, so
>> the > > new file's buffer has utf-8 encoding from the get-go, and
>> thus > > adding the local variable doesn't change the
>> coding-system, and > > you are not asked to revert the buffer.
>> Which is also expected.)
>> >
>> > > Confused.
>> >
>> > Not now, thanks. I think I was confused by the response
>> "revert-buffer" > when I knew I'd yet to save it. And yes, my
>> locale is utf-8.
>>
>> Hmm... maybe we should not suggest reverting if the file doesn't
>> exist? Would that make this situation less confusing?
> Why suggest reverting, whether or not the file exists? The buffer
> change just made by add-file-local-variable-prop-line hasn't been
> saved to any file yet. Reverting will undo the change, along with
> any other unsaved changes.
> It seems like a little mistake in the wording of the
> suggestion. It might make more sense to advise the user to save
> and then revert -- except that it wouldn't cause the file-local
> variable to take effect anyway. Perhaps I'm misunderstanding what
> the message means ("revisit"?).
> I think it should say just say to run "normal-mode".
Why must a user who has run 'add-file-local-variable-prop-line' be prompted
with anything? What about just removing 'revert-buffer'?
Best wishes,
Colin.
--
Colin Baxter
URL: http://www.Colin-Baxter.com
next prev parent reply other threads:[~2020-05-15 5:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 16:13 reverting non-existent file Colin Baxter
2020-05-14 18:22 ` Eli Zaretskii
2020-05-14 18:52 ` Colin Baxter
2020-05-14 19:02 ` Eli Zaretskii
2020-05-14 19:54 ` Richard Copley
2020-05-15 5:36 ` Colin Baxter [this message]
2020-05-15 7:15 ` Eli Zaretskii
2020-05-15 6:16 ` Eli Zaretskii
2020-05-14 19:58 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d075iwts.fsf@yandex.com \
--to=m43cap@yandex.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rcopley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).